Re: Review Request 72379: "get_splits" udf ignores limit constraint when creating splits

2020-04-20 Thread Adesh Rao
> On April 20, 2020, 2:19 a.m., Sankar Hariappan wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/AbstractTestJdbcGenericUDTFGetSplits.java > > Lines 181 (patched) > > > > > > Add test for limit with

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-20 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220374 --- Some nits, did not checked all the unit tests changes. Anything I

Re: Review Request 72379: "get_splits" udf ignores limit constraint when creating splits

2020-04-20 Thread Adesh Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72379/ --- (Updated April 20, 2020, 6:10 p.m.) Review request for hive and Sankar

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-20 Thread Denys Kuzmenko via Review Board
> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2727-2730 (original), 2727-2730 (patched) > > > > > > Is this config still needed in this

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-20 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 20, 2020, 8:50 p.m.) Review request for hive, Marton Bod and

[jira] [Created] (HIVE-23259) Fix Apache Rat validation

2020-04-20 Thread Jira
Ismaël Mejía created HIVE-23259: --- Summary: Fix Apache Rat validation Key: HIVE-23259 URL: https://issues.apache.org/jira/browse/HIVE-23259 Project: Hive Issue Type: Bug Components:

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-20 Thread Denys Kuzmenko via Review Board
> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2732 (patched) > > > > > > Maybe rephrase? > > Manages concurrency levels for ACID

[jira] [Created] (HIVE-23262) Remove dependency on activemq

2020-04-20 Thread Ashutosh Chauhan (Jira)
Ashutosh Chauhan created HIVE-23262: --- Summary: Remove dependency on activemq Key: HIVE-23262 URL: https://issues.apache.org/jira/browse/HIVE-23262 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-23261) Check whether encryption is enabled in the cluster before moving files

2020-04-20 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-23261: --- Summary: Check whether encryption is enabled in the cluster before moving files Key: HIVE-23261 URL: https://issues.apache.org/jira/browse/HIVE-23261 Project:

[jira] [Created] (HIVE-23260) Add support for unmodified_metadata capability

2020-04-20 Thread Naveen Gangam (Jira)
Naveen Gangam created HIVE-23260: Summary: Add support for unmodified_metadata capability Key: HIVE-23260 URL: https://issues.apache.org/jira/browse/HIVE-23260 Project: Hive Issue Type:

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-20 Thread Peter Vary via Review Board
> On ápr. 17, 2020, 7:03 du, Peter Vary wrote: > > Thanks Peter for the patch! > > This fix is long overdue! > > > > I do not understand one thing, see below. > > > > Also I would like to ask Denys to confirm, that running the init sqls again > > and again will not cause too much overhead in

[jira] [Created] (HIVE-23249) Prevent infinite loop in TestJdbcWithMiniLlapArrow

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23249: --- Summary: Prevent infinite loop in TestJdbcWithMiniLlapArrow Key: HIVE-23249 URL: https://issues.apache.org/jira/browse/HIVE-23249 Project: Hive Issue

[jira] [Created] (HIVE-23250) Scheduled query related qtests may not finish before it's expected

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23250: --- Summary: Scheduled query related qtests may not finish before it's expected Key: HIVE-23250 URL: https://issues.apache.org/jira/browse/HIVE-23250 Project: Hive

[jira] [Created] (HIVE-23248) avro-mapred should not pull in org.mortbay.jetty

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23248: --- Summary: avro-mapred should not pull in org.mortbay.jetty Key: HIVE-23248 URL: https://issues.apache.org/jira/browse/HIVE-23248 Project: Hive Issue

Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

2020-04-20 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- Review request for hive, Marton Bod and Peter Vary. Bugs: HIVE-19369

Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/ --- Review request for hive and Peter Vary. Repository: hive-git Description

Re: Review Request 72378: HIVE-23201: Improve logging in locking

2020-04-20 Thread Marton Bod
> On April 17, 2020, 1:46 p.m., Peter Vary wrote: > > Mostly agree, few comments. > > I would like to ask you to go through them, and if there are any places > > where the problem should not happen use at least info level. > > > > Thanks, > > Peter Thanks for the review Peter! I've made

[jira] [Created] (HIVE-23246) Reduce MiniDruidCluster memory requeirements

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23246: --- Summary: Reduce MiniDruidCluster memory requeirements Key: HIVE-23246 URL: https://issues.apache.org/jira/browse/HIVE-23246 Project: Hive Issue Type:

[jira] [Created] (HIVE-23247) Increase timeout for some tez tests

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23247: --- Summary: Increase timeout for some tez tests Key: HIVE-23247 URL: https://issues.apache.org/jira/browse/HIVE-23247 Project: Hive Issue Type: Sub-task

Re: Review Request 72380: HIVE-23207 Create integration tests for TxnManager for different rdbms metastores

2020-04-20 Thread Peter Varga via Review Board
> On April 17, 2020, 7:03 p.m., Peter Vary wrote: > > Thanks Peter for the patch! > > This fix is long overdue! > > > > I do not understand one thing, see below. > > > > Also I would like to ask Denys to confirm, that running the init sqls again > > and again will not cause too much overhead

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-20 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220367 --- LGTM, just a few comments

[jira] [Created] (HIVE-23253) Synchronization between external SerDe schemas and Metastore

2020-04-20 Thread Attila Magyar (Jira)
Attila Magyar created HIVE-23253: Summary: Synchronization between external SerDe schemas and Metastore Key: HIVE-23253 URL: https://issues.apache.org/jira/browse/HIVE-23253 Project: Hive

[jira] [Created] (HIVE-23252) Change spark related tests to be optional

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23252: --- Summary: Change spark related tests to be optional Key: HIVE-23252 URL: https://issues.apache.org/jira/browse/HIVE-23252 Project: Hive Issue Type:

[jira] [Created] (HIVE-23251) Provide a way to have only a selection of datasets loaded

2020-04-20 Thread Zoltan Haindrich (Jira)
Zoltan Haindrich created HIVE-23251: --- Summary: Provide a way to have only a selection of datasets loaded Key: HIVE-23251 URL: https://issues.apache.org/jira/browse/HIVE-23251 Project: Hive

[jira] [Created] (HIVE-23254) Upgrade guava version in hive from 19.0 to 27.0-jre

2020-04-20 Thread Ankur Raj (Jira)
Ankur Raj created HIVE-23254: Summary: Upgrade guava version in hive from 19.0 to 27.0-jre Key: HIVE-23254 URL: https://issues.apache.org/jira/browse/HIVE-23254 Project: Hive Issue Type: Bug

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-20 Thread Denys Kuzmenko via Review Board
> On April 20, 2020, 12:19 p.m., Peter Vary wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > > Lines 780 (patched) > > > > > > TXN_META_INFO? What

Re: Review Request 72388: HIVE-23048 Use sequences for TXN_ID generation

2020-04-20 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72388/#review220369 --- This is a really big/scary change. I am really interested in the

Review Request 72392: HIVE-23103 Oracle statement batching

2020-04-20 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72392/ --- Review request for hive, Denys Kuzmenko and Marton Bod. Bugs: HIVE-23103

[jira] [Created] (HIVE-23255) Fix flaky test TestMiniLlapLocalCliDriver[temp_table_multi_insert_partitioned.q]

2020-04-20 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-23255: - Summary: Fix flaky test TestMiniLlapLocalCliDriver[temp_table_multi_insert_partitioned.q] Key: HIVE-23255 URL: https://issues.apache.org/jira/browse/HIVE-23255

[jira] [Created] (HIVE-23256) Fix flaky test TestMiniLlapLocalCliDriver[schema_evol_par_vec_table_dictionary_encoding.q]

2020-04-20 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-23256: - Summary: Fix flaky test TestMiniLlapLocalCliDriver[schema_evol_par_vec_table_dictionary_encoding.q] Key: HIVE-23256 URL: https://issues.apache.org/jira/browse/HIVE-23256

[jira] [Created] (HIVE-23257) Fix flaky test TestMiniLlapLocalCliDriver[schema_evol_par_vec_table_non_dictionary_encoding.q]

2020-04-20 Thread Miklos Gergely (Jira)
Miklos Gergely created HIVE-23257: - Summary: Fix flaky test TestMiniLlapLocalCliDriver[schema_evol_par_vec_table_non_dictionary_encoding.q] Key: HIVE-23257 URL: https://issues.apache.org/jira/browse/HIVE-23257

[jira] [Created] (HIVE-23258) Remove BoneCP Connection Pool

2020-04-20 Thread David Mollitor (Jira)
David Mollitor created HIVE-23258: - Summary: Remove BoneCP Connection Pool Key: HIVE-23258 URL: https://issues.apache.org/jira/browse/HIVE-23258 Project: Hive Issue Type: Improvement