Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

2020-05-20 Thread Denys Kuzmenko via Review Board
> On May 20, 2020, 3:16 p.m., Peter Varga wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 686 (patched) > > > > > > I have concerns here, but I am not sure if they are well founded or > >

Review Request 72532: HIVE-23495 AcidUtils.getAcidState cleanup

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72532/ --- Review request for hive, Karen Coppage and Peter Vary. Repository: hive-git

Re: Review Request 72526: HIVE-23493

2020-05-20 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72526/ --- (Updated May 20, 2020, 6:57 p.m.) Review request for hive and Jesús Camacho

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72465/ --- (Updated May 20, 2020, 12:24 p.m.) Review request for hive and Denys Kuzmenko.

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-20 Thread Peter Varga via Review Board
> On May 19, 2020, 7:54 a.m., Peter Vary wrote: > > Thank you for the review, fixed the issues + removed some parameters from the HMS.startMetaStore, since they were just implementation details unneccessary exposed. - Peter --- This

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/ --- (Updated May 20, 2020, 2:03 p.m.) Review request for hive, Miklos Gergely and

Re: Review Request 72465: HIVE-23340 TxnHandler cleanup

2020-05-20 Thread Peter Varga via Review Board
> On May 18, 2020, 7:33 a.m., Denys Kuzmenko wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnStatus.java > > Lines 32 (patched) > > > > > > Could you please

Re: Review Request 72528: ValidTxnManager doesn't consider txns opened and committed between snapshot generation and locking when evaluating ValidTxnListState

2020-05-20 Thread Peter Varga via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72528/#review220838 --- The patch looks great, but I have concers. See below.

Re: Review Request 72480: HIVE-23242 Fix flaky tests testHouseKeepingThreadExistence

2020-05-20 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72480/#review220839 --- Ship it! Ship It! - Peter Vary On máj. 20, 2020, 2:03 du,

[jira] [Created] (HIVE-23520) REPL: repl dump could add support for immutable dataset

2020-05-20 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-23520: --- Summary: REPL: repl dump could add support for immutable dataset Key: HIVE-23520 URL: https://issues.apache.org/jira/browse/HIVE-23520 Project: Hive

[jira] [Created] (HIVE-23521) REPL: Optimise partition loading during bootstrap

2020-05-20 Thread Rajesh Balamohan (Jira)
Rajesh Balamohan created HIVE-23521: --- Summary: REPL: Optimise partition loading during bootstrap Key: HIVE-23521 URL: https://issues.apache.org/jira/browse/HIVE-23521 Project: Hive Issue

[jira] [Created] (HIVE-23517) Update tpcds queries: q4 q11 q74

2020-05-20 Thread Krisztian Kasa (Jira)
Krisztian Kasa created HIVE-23517: - Summary: Update tpcds queries: q4 q11 q74 Key: HIVE-23517 URL: https://issues.apache.org/jira/browse/HIVE-23517 Project: Hive Issue Type: Task

[jira] [Created] (HIVE-23518) Tez may skip file permission update on intermediate output

2020-05-20 Thread Attila Magyar (Jira)
Attila Magyar created HIVE-23518: Summary: Tez may skip file permission update on intermediate output Key: HIVE-23518 URL: https://issues.apache.org/jira/browse/HIVE-23518 Project: Hive

Review Request 72530: HIVE-23517

2020-05-20 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72530/ --- Review request for hive, Jesús Camacho Rodríguez and Nita Dembla. Bugs:

[jira] [Created] (HIVE-23519) Read Ranger Configs from Classpath

2020-05-20 Thread Aasha Medhi (Jira)
Aasha Medhi created HIVE-23519: -- Summary: Read Ranger Configs from Classpath Key: HIVE-23519 URL: https://issues.apache.org/jira/browse/HIVE-23519 Project: Hive Issue Type: Task