Review Request 56294: Fix for HIVE-15808

2017-02-03 Thread Deepak Jaiswal
/ConvertJoinMapJoin.java 0f9e86b ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad Diff: https://reviews.apache.org/r/56294/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 56294: Fix for HIVE-15808

2017-02-04 Thread Deepak Jaiswal
/GenTezUtils.java aee74ad Diff: https://reviews.apache.org/r/56294/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 56467: HIVE-15853

2017-02-08 Thread Deepak Jaiswal
--- Dont remove semijoin when it is with dynamically partitioned hashjoin. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java e3b293a Diff: https://reviews.apache.org/r/56467/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 56294: Fix for HIVE-15808

2017-02-06 Thread Deepak Jaiswal
/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 0f9e86b ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad Diff: https://reviews.apache.org/r/56294/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 56294: Fix for HIVE-15808

2017-02-06 Thread Deepak Jaiswal
not find a cycle created due to it. Diffs (updated) - ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 0f9e86b ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad Diff: https://reviews.apache.org/r/56294/diff/ Testing --- Thanks, Deepak

Re: Review Request 56070: HIVE-15748

2017-01-31 Thread Deepak Jaiswal
ps://reviews.apache.org/r/56070/#review163620 ------- On Jan. 31, 2017, 12:44 a.m., Deepak Jaiswal wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 56110: Fix ConcurrentModification Excpetion in HIVE-15760

2017-01-31 Thread Deepak Jaiswal
ally generated e-mail. To reply, visit: https://reviews.apache.org/r/56110/#review163636 ------- On Jan. 31, 2017, 3:01 a.m., Deepak Jaiswal wrote: > > --- > This is an au

Re: Review Request 56070: HIVE-15748

2017-01-31 Thread Deepak Jaiswal
/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-22 Thread Deepak Jaiswal
/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 storage-api/src/java/org/apache/hive/common/util/BloomFilter.java e60690d Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
ng this out. - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56070/#review163574 --- On Jan. 30, 2017, 8:30 a.m., Deepak Jais

Re: Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 56110: Fix ConcurrentModification Excpetion in HIVE-15760

2017-01-30 Thread Deepak Jaiswal
in 2nd pass. Did the similar changes for SMBJoin related semijoin removal logic. Diffs - ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cf8e843 Diff: https://reviews.apache.org/r/56110/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 56070: HIVE-15748

2017-01-30 Thread Deepak Jaiswal
ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 13797c0 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out e89526e Diff: https://reviews.apache.org/r/56070/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 56695: Fix for HIVE-15904

2017-02-14 Thread Deepak Jaiswal
/clientpositive/dynamic_semijoin_reduction.q e686af6 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out cacde93 Diff: https://reviews.apache.org/r/56695/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-18 Thread Deepak Jaiswal
the FilterOperator, as I believe > > there are some instances where the predicates may not be pushed to the > > TableScan, but still exist in the FilterOperator. Or possibly done on both > > - DynamicPartitionPruningOptimization seems to apply it to both. > > Deepak Jai

Re: Review Request 55156: Min-max runtime filtering

2017-01-18 Thread Deepak Jaiswal
ache.org/r/55156/diff/8/?file=1608161#file1608161line705> > > > > Most of the time, you should not change formatting on existing code if > > all you are doing is changing whitespace. > > If we need to do formatting changes that can be done in a separate Jira. A

Re: Review Request 55156: Min-max runtime filtering

2017-01-18 Thread Deepak Jaiswal
think this change can be removed if we use the appropriate call to > > OperatorFactory.getAndMakeChild() during > > DynamicPartitionPruningOptimization. I'll try to play with this. > > Deepak Jaiswal wrote: > Can you please elaborate and let me know your find

Re: Review Request 55156: Min-max runtime filtering

2017-01-18 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review161608 ----------- On Jan. 18, 2017, 8:42 p.m., Deepak Jaiswal wrote: > >

Re: Precommit jenkins is failing

2017-01-16 Thread Deepak Jaiswal
Is there anyone who is looking into this? On 1/13/17, 10:46 AM, "Wei Zheng" wrote: [INFO] [INFO] BUILD SUCCESS [INFO]

Re: Review Request 55156: Min-max runtime filtering

2017-01-18 Thread Deepak Jaiswal
storage-api/src/java/org/apache/hive/common/util/BloomFilter.java e60690d Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-20 Thread Deepak Jaiswal
rue after running the 2nd set of statements. updated in latest patch. - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review162321 --------

Build failing on latest Apache master

2017-01-11 Thread Deepak Jaiswal
Hi all, The build is failing on latest Apache master in itests directory. Please find attached the last few lines of build log. Regards, Deepak

Re: Review Request 55156: Min-max runtime filtering

2017-01-13 Thread Deepak Jaiswal
/SearchArgumentFactory.java 8fda95c storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-13 Thread Deepak Jaiswal
atch - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55156/#review161398 --- On Jan. 13, 2017, 9:51 p.m.,

Re: Review Request 55156: Min-max runtime filtering

2017-01-10 Thread Deepak Jaiswal
/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-10 Thread Deepak Jaiswal
/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-06 Thread Deepak Jaiswal
moved if we use the appropriate call to > > OperatorFactory.getAndMakeChild() during > > DynamicPartitionPruningOptimization. I'll try to play with this. Can you please elaborate and let me know your findings? - Deepak --- This is an automatically generated e-mail. To reply, visit: ht

Re: Review Request 55156: Min-max runtime filtering

2017-01-06 Thread Deepak Jaiswal
Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-03 Thread Deepak Jaiswal
/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 55156: Min-max runtime filtering

2017-01-03 Thread Deepak Jaiswal
--- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-03 Thread Deepak Jaiswal
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 55156: Min-max runtime filtering

2017-01-04 Thread Deepak Jaiswal
/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java 8fda95c storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java 10d8c51 Diff: https://reviews.apache.org/r/55156/diff/ Testing --- Thanks, Deepak Jaiswal

Review Request 57903: HIVE-16282 Add faststart for semijoin reducer

2017-03-23 Thread Deepak Jaiswal
://reviews.apache.org/r/57903/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 57903: HIVE-16282 Add faststart for semijoin reducer

2017-03-24 Thread Deepak Jaiswal
/ Changes: https://reviews.apache.org/r/57903/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Review Request 57794: HIVE-16260 : Remove parallel edges between semijoin and mpajoin

2017-03-20 Thread Deepak Jaiswal
/clientpositive/llap/dynamic_semijoin_reduction.q.out d32cb5c Diff: https://reviews.apache.org/r/57794/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 57794: HIVE-16260 : Remove parallel edges between semijoin and mpajoin

2017-03-21 Thread Deepak Jaiswal
/clientpositive/tez/explainuser_3.q.out da52b0a Diff: https://reviews.apache.org/r/57794/diff/2/ Changes: https://reviews.apache.org/r/57794/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Review Request 58390: HIVE-16423

2017-04-12 Thread Deepak Jaiswal
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out a47ce6e583 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58390/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58390: HIVE-16423

2017-04-13 Thread Deepak Jaiswal
--- Thanks, Deepak Jaiswal

Re: Review Request 58390: HIVE-16423

2017-04-19 Thread Deepak Jaiswal
to it's original table operator (assuming it's been > > implemented properly). This might be useful if we want the hints to work > > even with join results. > > Deepak Jaiswal wrote: > Sounds promising. I will investigate. Looks like this function

Review Request 58585: HIVE-16441

2017-04-20 Thread Deepak Jaiswal
://reviews.apache.org/r/58585/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58390: HIVE-16423

2017-04-19 Thread Deepak Jaiswal
/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58390: HIVE-16423

2017-04-19 Thread Deepak Jaiswal
/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 57391: HIVE-16132

2017-03-10 Thread Deepak Jaiswal
://reviews.apache.org/r/57391/diff/2/ Changes: https://reviews.apache.org/r/57391/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Review Request 57391: HIVE-16132

2017-03-07 Thread Deepak Jaiswal
e686af6 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 012db41 Diff: https://reviews.apache.org/r/57391/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58390: HIVE-16423

2017-04-18 Thread Deepak Jaiswal
n is > > replaced by a MapJoin in ConvertJoinMapJoin? It should be. I will investigate. - Deepak ----------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58390/#review172266 -

Re: Review Request 61543: HIVE-17283

2017-08-10 Thread Deepak Jaiswal
/61543/diff/2/ Changes: https://reviews.apache.org/r/61543/diff/1-2/ Testing --- Unit test added. Pending ptests. Thanks, Deepak Jaiswal

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-25 Thread Deepak Jaiswal
/hadoop/hive/ql/exec/tez/tools/KeyValueInputMerger.java 698fa7f69e ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805 Diff: https://reviews.apache.org/r/61087/diff/3/ Changes: https://reviews.apache.org/r/61087/diff/2-3/ Testing --- Added a new test. Thanks, Deepak

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-24 Thread Deepak Jaiswal
--- Added a new test. Thanks, Deepak Jaiswal

Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-24 Thread Deepak Jaiswal
ql/src/test/results/clientpositive/llap/smb_join1.q.out PRE-CREATION Diff: https://reviews.apache.org/r/61087/diff/1/ Testing (updated) --- Added a new test. Thanks, Deepak Jaiswal

Apache ptest broken?

2017-07-24 Thread Deepak Jaiswal
Looks like ptest for hive is broken. https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/# Regards, Deepak

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-27 Thread Deepak Jaiswal
ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805 Diff: https://reviews.apache.org/r/61087/diff/4/ Changes: https://reviews.apache.org/r/61087/diff/3-4/ Testing --- Added a new test. Thanks, Deepak Jaiswal

Re: Review Request 60382: HIVE-16947

2017-06-27 Thread Deepak Jaiswal
://reviews.apache.org/r/60382/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 60478: HIVE-16761 LLAP IO: SMB joins fail elevator

2017-06-27 Thread Deepak Jaiswal
? llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java Lines 183 (patched) <https://reviews.apache.org/r/60478/#comment253457> Why is this code block commented out? Is it not needed anymore? - Deepak Jaiswal On June 27, 2017, 6:24 p.m., Sergey Shelukhin

Review Request 61543: HIVE-17283

2017-08-09 Thread Deepak Jaiswal
5614c26819 ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760 ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 2eedb6efb3 Diff: https://reviews.apache.org/r/61543/diff/1/ Testing --- Unit test added. Pending ptests. Thanks, Deepak Jaiswal

Re: Review Request 61087: HIVE-16965 SMB join may produce incorrect results

2017-07-27 Thread Deepak Jaiswal
/KeyValueInputMerger.java 698fa7f69e ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805 Diff: https://reviews.apache.org/r/61087/diff/5/ Changes: https://reviews.apache.org/r/61087/diff/4-5/ Testing --- Added a new test. Thanks, Deepak Jaiswal

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
er.java > 654f3b1772 > ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 5ea7800528 > ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java > 3143554ec6 > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 032c7bb28d > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > f45daa8828 > ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1 > ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec > > > Diff: https://reviews.apache.org/r/58914/diff/1/ > > > Testing > --- > > > Thanks, > > Deepak Jaiswal > >

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
? > > This feature is not yet fully developed/supported and is off by > > default. > > You might want to try the same queries with this feature off. > > Deepak Jaiswal wrote: > We have to make sure we dont break it. > There are tests below with the feat

Review Request 58973: HIVE-16578

2017-05-03 Thread Deepak Jaiswal
--- Thanks, Deepak Jaiswal

Re: Review Request 58973: HIVE-16578

2017-05-03 Thread Deepak Jaiswal
s.getColumnExpr() ditto - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58973/#review173818 --- On May 3, 2017, 8:12

Re: Review Request 58973: HIVE-16578

2017-05-03 Thread Deepak Jaiswal
://reviews.apache.org/r/58973/diff/2/ Changes: https://reviews.apache.org/r/58973/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: [Announce] New committer: Vineet Garg

2017-05-09 Thread Deepak Jaiswal
Congratulations Vineet! On 5/9/17, 1:51 PM, "Jimmy Xiang" wrote: Congrats!! On Tue, May 9, 2017 at 1:47 PM, Sergio Pena wrote: > Congratulations Vinnet !! > > On Tue, May 9, 2017 at 3:42 PM, Wei Zheng

Review Request 59080: HIVE-16610

2017-05-09 Thread Deepak Jaiswal
/59080/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 59080: HIVE-16610

2017-05-09 Thread Deepak Jaiswal
; place in the code. I will try to simplify the code. - Deepak ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59080/#review174364

Re: Review Request 59080: HIVE-16610

2017-05-10 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59080/#review174436 --- On May 10, 2017, 5:24 a.m., Deepak Jaiswal wrote: > > --

Re: Review Request 59080: HIVE-16610

2017-05-09 Thread Deepak Jaiswal
/src/test/results/clientpositive/llap/semijoin_hint.q.out 3ffc2352a4 Diff: https://reviews.apache.org/r/59080/diff/2/ Changes: https://reviews.apache.org/r/59080/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 59080: HIVE-16610

2017-05-10 Thread Deepak Jaiswal
--- Thanks, Deepak Jaiswal

Review Request 60382: HIVE-16947

2017-06-22 Thread Deepak Jaiswal
handles the 1st one causing cycles preventing the queries from running. Diffs - ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 98fec77010 Diff: https://reviews.apache.org/r/60382/diff/1/ Testing --- Thanks, Deepak Jaiswal

Review Request 59726: HIVE-16804

2017-06-01 Thread Deepak Jaiswal
71fa445ec8 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out ae9bf9bd8b Diff: https://reviews.apache.org/r/59726/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58973: HIVE-16578

2017-05-04 Thread Deepak Jaiswal
://reviews.apache.org/r/58973/diff/2-3/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
5line300> > > > > Should the expectedEntries be 5000 per the hint? ditto - Deepak ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58914/#review173628 --

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
/semijoin_hint.q 5de0c8c8c1 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec Diff: https://reviews.apache.org/r/58914/diff/3/ Changes: https://reviews.apache.org/r/58914/diff/2-3/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58914: HIVE-16550

2017-05-02 Thread Deepak Jaiswal
8828 ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1 ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec Diff: https://reviews.apache.org/r/58914/diff/2/ Changes: https://reviews.apache.org/r/58914/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Review Request 59072: HIVE-16599

2017-05-08 Thread Deepak Jaiswal
--- Thanks, Deepak Jaiswal

Re: Review Request 58973: HIVE-16578

2017-05-04 Thread Deepak Jaiswal
/5/ Changes: https://reviews.apache.org/r/58973/diff/4-5/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 58973: HIVE-16578

2017-05-04 Thread Deepak Jaiswal
nks for bringing this up. I will fix it. - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58973/#review173944 ----------- On May 4, 2017, 7:34 a.m., Deepak Jaiswal wrote: > > -

Re: Review Request 58973: HIVE-16578

2017-05-04 Thread Deepak Jaiswal
://reviews.apache.org/r/58973/diff/3-4/ Testing --- Thanks, Deepak Jaiswal

Review Request 58914: HIVE-16550

2017-05-01 Thread Deepak Jaiswal
://reviews.apache.org/r/58914/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 59726: HIVE-16804

2017-06-05 Thread Deepak Jaiswal
: https://reviews.apache.org/r/59726/diff/2/ Changes: https://reviews.apache.org/r/59726/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 59726: HIVE-16804

2017-06-06 Thread Deepak Jaiswal
ly, visit: https://reviews.apache.org/r/59726/#review177063 --- On June 6, 2017, 12:54 a.m., Deepak Jaiswal wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 59726: HIVE-16804

2017-06-06 Thread Deepak Jaiswal
/59726/diff/3/ Changes: https://reviews.apache.org/r/59726/diff/2-3/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62320: HIVE-17529

2017-09-15 Thread Deepak Jaiswal
://reviews.apache.org/r/62320/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62320: HIVE-17529

2017-09-20 Thread Deepak Jaiswal
/ Changes: https://reviews.apache.org/r/62320/diff/2-3/ Testing --- Thanks, Deepak Jaiswal

Review Request 62320: HIVE-17529

2017-09-13 Thread Deepak Jaiswal
/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62952: HIVE-17792

2017-10-14 Thread Deepak Jaiswal
, Deepak Jaiswal

Re: Review Request 62952: HIVE-17792

2017-10-15 Thread Deepak Jaiswal
/diff/3-4/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62952: HIVE-17792

2017-10-15 Thread Deepak Jaiswal
://reviews.apache.org/r/62952/diff/4-5/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62952: HIVE-17792

2017-10-13 Thread Deepak Jaiswal
/clientpositive/llap/bucket_map_join_tez1.q.out 36cb4ac6c7 Diff: https://reviews.apache.org/r/62952/diff/2/ Changes: https://reviews.apache.org/r/62952/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 61956: HIVE-17323

2017-08-29 Thread Deepak Jaiswal
/queries/clientpositive/dynamic_semijoin_reduction.q b22890bc9d ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out 478b0828a3 Diff: https://reviews.apache.org/r/61956/diff/2/ Changes: https://reviews.apache.org/r/61956/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 61956: HIVE-17323

2017-08-29 Thread Deepak Jaiswal
: https://reviews.apache.org/r/61956/diff/2-3/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 61956: HIVE-17323

2017-08-29 Thread Deepak Jaiswal
lts are added to the output. - Deepak --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61956/#review184080 --- On Aug. 29

Re: Review Request 61956: HIVE-17323

2017-08-29 Thread Deepak Jaiswal
> On Aug. 29, 2017, 6:28 p.m., Gopal V wrote: > > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out > > Line 2667 (original), 2893 (patched) > > <https://reviews.apache.org/r/61956/diff/2/?file=1807067#file1807067line2893> > > > >

Re: Review Request 61985: HIVE-17399

2017-08-30 Thread Deepak Jaiswal
ect, which goes from null -> false/true, so that > > you can encode (not-set, true, false) in one field. > > Deepak Jaiswal wrote: > Will do that. In this case, we have very straightforward states so keeping it as it is. - Deepak ---

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
lts/clientpositive/llap/dynamic_semijoin_reduction.q.out 3bd35bf2d8 Diff: https://reviews.apache.org/r/61985/diff/2/ Changes: https://reviews.apache.org/r/61985/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 61985: HIVE-17399

2017-08-29 Thread Deepak Jaiswal
reviews.apache.org/r/61985/diff/1/?file=1807525#file1807525line115> > > > > Pick a query with a non-zero result, so that we can see when it has > > false negatives (i.e loses rows it is meant to have?). Sure. - Deepak ----------

Review Request 62004: HIVE-17415

2017-08-30 Thread Deepak Jaiswal
e/ql/parse/SemanticAnalyzer.java e8acabefa5 ql/src/test/queries/clientpositive/authorization_view_8.q PRE-CREATION ql/src/test/results/clientpositive/llap/authorization_view_8.q.out PRE-CREATION Diff: https://reviews.apache.org/r/62004/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62150: HIVE-17475

2017-09-07 Thread Deepak Jaiswal
6f379da1e3 ql/src/test/queries/clientpositive/mapjoin_hint.q PRE-CREATION ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out PRE-CREATION Diff: https://reviews.apache.org/r/62150/diff/2/ Changes: https://reviews.apache.org/r/62150/diff/1-2/ Testing --- Thanks, Deepak

Re: Review Request 62150: HIVE-17475

2017-09-07 Thread Deepak Jaiswal
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62150/#review184899 ------- On Sept. 7, 2017, 9:19 p.m., Deepak Jaiswal wrote: > >

Review Request 62150: HIVE-17475

2017-09-07 Thread Deepak Jaiswal
Diff: https://reviews.apache.org/r/62150/diff/1/ Testing --- Thanks, Deepak Jaiswal

Review Request 61956: HIVE-17323

2017-08-28 Thread Deepak Jaiswal
Diff: https://reviews.apache.org/r/61956/diff/1/ Testing --- Thanks, Deepak Jaiswal

Re: Review Request 62004: HIVE-17415

2017-08-31 Thread Deepak Jaiswal
st/results/clientpositive/llap/authorization_view_8.q.out PRE-CREATION Diff: https://reviews.apache.org/r/62004/diff/2/ Changes: https://reviews.apache.org/r/62004/diff/1-2/ Testing --- Thanks, Deepak Jaiswal

  1   2   3   4   5   >