/ConvertJoinMapJoin.java
0f9e86b
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad
Diff: https://reviews.apache.org/r/56294/diff/
Testing
---
Thanks,
Deepak Jaiswal
/GenTezUtils.java aee74ad
Diff: https://reviews.apache.org/r/56294/diff/
Testing
---
Thanks,
Deepak Jaiswal
---
Dont remove semijoin when it is with dynamically partitioned hashjoin.
Diffs
-
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
e3b293a
Diff: https://reviews.apache.org/r/56467/diff/
Testing
---
Thanks,
Deepak Jaiswal
/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
0f9e86b
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad
Diff: https://reviews.apache.org/r/56294/diff/
Testing
---
Thanks,
Deepak Jaiswal
not find a cycle created due to it.
Diffs (updated)
-
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
0f9e86b
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java aee74ad
Diff: https://reviews.apache.org/r/56294/diff/
Testing
---
Thanks,
Deepak
ps://reviews.apache.org/r/56070/#review163620
-------
On Jan. 31, 2017, 12:44 a.m., Deepak Jaiswal wrote:
>
> ---
> This is an automatically generated e-mail.
ally generated e-mail. To reply, visit:
https://reviews.apache.org/r/56110/#review163636
-------
On Jan. 31, 2017, 3:01 a.m., Deepak Jaiswal wrote:
>
> ---
> This is an au
/
Testing
---
Thanks,
Deepak Jaiswal
/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
storage-api/src/java/org/apache/hive/common/util/BloomFilter.java e60690d
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
ng this out.
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56070/#review163574
---
On Jan. 30, 2017, 8:30 a.m., Deepak Jais
/diff/
Testing
---
Thanks,
Deepak Jaiswal
in 2nd pass.
Did the similar changes for SMBJoin related semijoin removal logic.
Diffs
-
ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java cf8e843
Diff: https://reviews.apache.org/r/56110/diff/
Testing
---
Thanks,
Deepak Jaiswal
ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q 13797c0
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
e89526e
Diff: https://reviews.apache.org/r/56070/diff/
Testing
---
Thanks,
Deepak Jaiswal
/clientpositive/dynamic_semijoin_reduction.q e686af6
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
cacde93
Diff: https://reviews.apache.org/r/56695/diff/
Testing
---
Thanks,
Deepak Jaiswal
the FilterOperator, as I believe
> > there are some instances where the predicates may not be pushed to the
> > TableScan, but still exist in the FilterOperator. Or possibly done on both
> > - DynamicPartitionPruningOptimization seems to apply it to both.
>
> Deepak Jai
ache.org/r/55156/diff/8/?file=1608161#file1608161line705>
> >
> > Most of the time, you should not change formatting on existing code if
> > all you are doing is changing whitespace.
> > If we need to do formatting changes that can be done in a separate Jira.
A
think this change can be removed if we use the appropriate call to
> > OperatorFactory.getAndMakeChild() during
> > DynamicPartitionPruningOptimization. I'll try to play with this.
>
> Deepak Jaiswal wrote:
> Can you please elaborate and let me know your find
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55156/#review161608
-----------
On Jan. 18, 2017, 8:42 p.m., Deepak Jaiswal wrote:
>
>
Is there anyone who is looking into this?
On 1/13/17, 10:46 AM, "Wei Zheng" wrote:
[INFO]
[INFO] BUILD SUCCESS
[INFO]
storage-api/src/java/org/apache/hive/common/util/BloomFilter.java e60690d
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
rue after running the 2nd set of statements.
updated in latest patch.
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55156/#review162321
--------
Hi all,
The build is failing on latest Apache master in itests directory. Please find
attached the last few lines of build log.
Regards,
Deepak
/SearchArgumentFactory.java
8fda95c
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
atch
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55156/#review161398
---
On Jan. 13, 2017, 9:51 p.m.,
/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
moved if we use the appropriate call to
> > OperatorFactory.getAndMakeChild() during
> > DynamicPartitionPruningOptimization. I'll try to play with this.
Can you please elaborate and let me know your findings?
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
ht
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
---
Thanks,
Deepak Jaiswal
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentFactory.java
8fda95c
storage-api/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgumentImpl.java
10d8c51
Diff: https://reviews.apache.org/r/55156/diff/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/57903/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
/
Changes: https://reviews.apache.org/r/57903/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
/clientpositive/llap/dynamic_semijoin_reduction.q.out
d32cb5c
Diff: https://reviews.apache.org/r/57794/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
/clientpositive/tez/explainuser_3.q.out da52b0a
Diff: https://reviews.apache.org/r/57794/diff/2/
Changes: https://reviews.apache.org/r/57794/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
a47ce6e583
ql/src/test/results/clientpositive/llap/semijoin_hint.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/58390/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
---
Thanks,
Deepak Jaiswal
to it's original table operator (assuming it's been
> > implemented properly). This might be useful if we want the hints to work
> > even with join results.
>
> Deepak Jaiswal wrote:
> Sounds promising. I will investigate.
Looks like this function
://reviews.apache.org/r/58585/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
/
Testing
---
Thanks,
Deepak Jaiswal
/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/57391/diff/2/
Changes: https://reviews.apache.org/r/57391/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
e686af6
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
012db41
Diff: https://reviews.apache.org/r/57391/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
n is
> > replaced by a MapJoin in ConvertJoinMapJoin?
It should be. I will investigate.
- Deepak
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58390/#review172266
-
/61543/diff/2/
Changes: https://reviews.apache.org/r/61543/diff/1-2/
Testing
---
Unit test added.
Pending ptests.
Thanks,
Deepak Jaiswal
/hadoop/hive/ql/exec/tez/tools/KeyValueInputMerger.java
698fa7f69e
ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805
Diff: https://reviews.apache.org/r/61087/diff/3/
Changes: https://reviews.apache.org/r/61087/diff/2-3/
Testing
---
Added a new test.
Thanks,
Deepak
---
Added a new test.
Thanks,
Deepak Jaiswal
ql/src/test/results/clientpositive/llap/smb_join1.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/61087/diff/1/
Testing (updated)
---
Added a new test.
Thanks,
Deepak Jaiswal
Looks like ptest for hive is broken.
https://builds.apache.org/view/H-L/view/Hive/job/PreCommit-HIVE-Build/#
Regards,
Deepak
ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805
Diff: https://reviews.apache.org/r/61087/diff/4/
Changes: https://reviews.apache.org/r/61087/diff/3-4/
Testing
---
Added a new test.
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/60382/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
?
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
Lines 183 (patched)
<https://reviews.apache.org/r/60478/#comment253457>
Why is this code block commented out? Is it not needed anymore?
- Deepak Jaiswal
On June 27, 2017, 6:24 p.m., Sergey Shelukhin
5614c26819
ql/src/test/queries/clientpositive/dynamic_semijoin_reduction.q d631401760
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
2eedb6efb3
Diff: https://reviews.apache.org/r/61543/diff/1/
Testing
---
Unit test added.
Pending ptests.
Thanks,
Deepak Jaiswal
/KeyValueInputMerger.java
698fa7f69e
ql/src/test/results/clientpositive/llap/llap_smb.q.out 87b33db805
Diff: https://reviews.apache.org/r/61087/diff/5/
Changes: https://reviews.apache.org/r/61087/diff/4-5/
Testing
---
Added a new test.
Thanks,
Deepak Jaiswal
er.java
> 654f3b1772
> ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 5ea7800528
> ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeDynamicListDesc.java
> 3143554ec6
> ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 032c7bb28d
> ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java
> f45daa8828
> ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1
> ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec
>
>
> Diff: https://reviews.apache.org/r/58914/diff/1/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Deepak Jaiswal
>
>
?
> > This feature is not yet fully developed/supported and is off by
> > default.
> > You might want to try the same queries with this feature off.
>
> Deepak Jaiswal wrote:
> We have to make sure we dont break it.
> There are tests below with the feat
---
Thanks,
Deepak Jaiswal
s.getColumnExpr()
ditto
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58973/#review173818
---
On May 3, 2017, 8:12
://reviews.apache.org/r/58973/diff/2/
Changes: https://reviews.apache.org/r/58973/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
Congratulations Vineet!
On 5/9/17, 1:51 PM, "Jimmy Xiang" wrote:
Congrats!!
On Tue, May 9, 2017 at 1:47 PM, Sergio Pena
wrote:
> Congratulations Vinnet !!
>
> On Tue, May 9, 2017 at 3:42 PM, Wei Zheng
/59080/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
; place in the code.
I will try to simplify the code.
- Deepak
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59080/#review174364
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59080/#review174436
---
On May 10, 2017, 5:24 a.m., Deepak Jaiswal wrote:
>
> --
/src/test/results/clientpositive/llap/semijoin_hint.q.out 3ffc2352a4
Diff: https://reviews.apache.org/r/59080/diff/2/
Changes: https://reviews.apache.org/r/59080/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
---
Thanks,
Deepak Jaiswal
handles the
1st one causing cycles preventing the queries from running.
Diffs
-
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java
98fec77010
Diff: https://reviews.apache.org/r/60382/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
71fa445ec8
ql/src/test/results/clientpositive/llap/semijoin_hint.q.out ae9bf9bd8b
Diff: https://reviews.apache.org/r/59726/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/58973/diff/2-3/
Testing
---
Thanks,
Deepak Jaiswal
5line300>
> >
> > Should the expectedEntries be 5000 per the hint?
ditto
- Deepak
-------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58914/#review173628
--
/semijoin_hint.q 5de0c8c8c1
ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec
Diff: https://reviews.apache.org/r/58914/diff/3/
Changes: https://reviews.apache.org/r/58914/diff/2-3/
Testing
---
Thanks,
Deepak Jaiswal
8828
ql/src/test/queries/clientpositive/semijoin_hint.q 5de0c8c8c1
ql/src/test/results/clientpositive/llap/semijoin_hint.q.out bc248930ec
Diff: https://reviews.apache.org/r/58914/diff/2/
Changes: https://reviews.apache.org/r/58914/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
---
Thanks,
Deepak Jaiswal
/5/
Changes: https://reviews.apache.org/r/58973/diff/4-5/
Testing
---
Thanks,
Deepak Jaiswal
nks for bringing this up. I will fix it.
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58973/#review173944
-----------
On May 4, 2017, 7:34 a.m., Deepak Jaiswal wrote:
>
> -
://reviews.apache.org/r/58973/diff/3-4/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/58914/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
: https://reviews.apache.org/r/59726/diff/2/
Changes: https://reviews.apache.org/r/59726/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
ly, visit:
https://reviews.apache.org/r/59726/#review177063
---
On June 6, 2017, 12:54 a.m., Deepak Jaiswal wrote:
>
> ---
> This is an automatically generated e-mail. To re
/59726/diff/3/
Changes: https://reviews.apache.org/r/59726/diff/2-3/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/62320/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
/
Changes: https://reviews.apache.org/r/62320/diff/2-3/
Testing
---
Thanks,
Deepak Jaiswal
/1/
Testing
---
Thanks,
Deepak Jaiswal
,
Deepak Jaiswal
/diff/3-4/
Testing
---
Thanks,
Deepak Jaiswal
://reviews.apache.org/r/62952/diff/4-5/
Testing
---
Thanks,
Deepak Jaiswal
/clientpositive/llap/bucket_map_join_tez1.q.out 36cb4ac6c7
Diff: https://reviews.apache.org/r/62952/diff/2/
Changes: https://reviews.apache.org/r/62952/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
/queries/clientpositive/dynamic_semijoin_reduction.q b22890bc9d
ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
478b0828a3
Diff: https://reviews.apache.org/r/61956/diff/2/
Changes: https://reviews.apache.org/r/61956/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
: https://reviews.apache.org/r/61956/diff/2-3/
Testing
---
Thanks,
Deepak Jaiswal
lts are added to the output.
- Deepak
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61956/#review184080
---
On Aug. 29
> On Aug. 29, 2017, 6:28 p.m., Gopal V wrote:
> > ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction.q.out
> > Line 2667 (original), 2893 (patched)
> > <https://reviews.apache.org/r/61956/diff/2/?file=1807067#file1807067line2893>
> >
> >
ect, which goes from null -> false/true, so that
> > you can encode (not-set, true, false) in one field.
>
> Deepak Jaiswal wrote:
> Will do that.
In this case, we have very straightforward states so keeping it as it is.
- Deepak
---
lts/clientpositive/llap/dynamic_semijoin_reduction.q.out
3bd35bf2d8
Diff: https://reviews.apache.org/r/61985/diff/2/
Changes: https://reviews.apache.org/r/61985/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
reviews.apache.org/r/61985/diff/1/?file=1807525#file1807525line115>
> >
> > Pick a query with a non-zero result, so that we can see when it has
> > false negatives (i.e loses rows it is meant to have?).
Sure.
- Deepak
----------
e/ql/parse/SemanticAnalyzer.java e8acabefa5
ql/src/test/queries/clientpositive/authorization_view_8.q PRE-CREATION
ql/src/test/results/clientpositive/llap/authorization_view_8.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/62004/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
6f379da1e3
ql/src/test/queries/clientpositive/mapjoin_hint.q PRE-CREATION
ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/62150/diff/2/
Changes: https://reviews.apache.org/r/62150/diff/1-2/
Testing
---
Thanks,
Deepak
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62150/#review184899
-------
On Sept. 7, 2017, 9:19 p.m., Deepak Jaiswal wrote:
>
>
Diff: https://reviews.apache.org/r/62150/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
Diff: https://reviews.apache.org/r/61956/diff/1/
Testing
---
Thanks,
Deepak Jaiswal
st/results/clientpositive/llap/authorization_view_8.q.out
PRE-CREATION
Diff: https://reviews.apache.org/r/62004/diff/2/
Changes: https://reviews.apache.org/r/62004/diff/1-2/
Testing
---
Thanks,
Deepak Jaiswal
1 - 100 of 406 matches
Mail list logo