Review Request 70832: HIVE-21815

2019-06-11 Thread Krisztian Kasa
tests. Thanks, Krisztian Kasa

Review Request 71014: HIVE-21938: Add database and table filter options to PreUpgradeTool

2019-07-04 Thread Krisztian Kasa
/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd Diff: https://reviews.apache.org/r/71014/diff/1/ Testing --- New UTs for testing filtering Thanks, Krisztian Kasa

Re: Review Request 71014: HIVE-21938

2019-07-04 Thread Krisztian Kasa
/hive/upgrade/acid/RunOptions.java PRE-CREATION upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd Diff: https://reviews.apache.org/r/71014/diff/1/ Testing --- New UTs for testing filtering Thanks, Krisztian Kasa

Re: Review Request 71014: HIVE-21938

2019-07-05 Thread Krisztian Kasa
-CREATION upgrade-acid/pre-upgrade/src/test/java/org/apache/hadoop/hive/upgrade/acid/TestPreUpgradeTool.java 90230d5dbd Diff: https://reviews.apache.org/r/71014/diff/2/ Changes: https://reviews.apache.org/r/71014/diff/1-2/ Testing --- New UTs for testing filtering Thanks, Krisztian

Review Request 71045: HIVE-21948

2019-07-10 Thread Krisztian Kasa
. deploy ambari and HDP 2.6.5 cluster. 2. create some hive tables and insert/update values 3. run PreUpgradeTool and check logs and output script Thanks, Krisztian Kasa

Review Request 71038: HIVE-21965

2019-07-10 Thread Krisztian Kasa
/apache/hadoop/hive/ql/util/CloseableThreadLocalTest.java PRE-CREATION ql/src/test/org/apache/hadoop/hive/ql/util/TestHiveStrictManagedMigration.java PRE-CREATION Diff: https://reviews.apache.org/r/71038/diff/1/ Testing --- New UT for testing migration. Thanks, Krisztian Kasa

Re: Review Request 71038: HIVE-21965

2019-07-11 Thread Krisztian Kasa
/TestHiveStrictManagedMigration.java PRE-CREATION Diff: https://reviews.apache.org/r/71038/diff/2/ Changes: https://reviews.apache.org/r/71038/diff/1-2/ Testing --- New UT for testing migration. Thanks, Krisztian Kasa

Re: Review Request 71045: HIVE-21948

2019-07-11 Thread Krisztian Kasa
/update values 3. run PreUpgradeTool and check logs and output script Thanks, Krisztian Kasa

Re: Review Request 71038: HIVE-21965

2019-07-11 Thread Krisztian Kasa
ically generated e-mail. To reply, visit: https://reviews.apache.org/r/71038/#review216522 --- On July 11, 2019, noon, Krisztian Kasa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.a

Re: Review Request 71014: HIVE-21938

2019-07-08 Thread Krisztian Kasa
filtering Exsiting and new UTs passed. Manually: 1. deploy ambari and HDP 2.6.5 cluster. 2. create some hive tables and insert/update values 3. run PreUpgradeTool and check logs and output script Thanks, Krisztian Kasa

Review Request 70988: HIVE-21941

2019-07-02 Thread Krisztian Kasa
checkstyle:checkstyle less target/checkstyle-result.xml ``` ``` ... ... ``` Thanks, Krisztian Kasa

Re: Review Request 71458: HIVE-22163

2019-09-12 Thread Krisztian Kasa
/results/clientpositive/llap/join_reordering_no_stats.q.out fddffbb0a8 Diff: https://reviews.apache.org/r/71458/diff/3/ Changes: https://reviews.apache.org/r/71458/diff/2-3/ Testing --- New qtest: cbo_stats_estimation.q Thanks, Krisztian Kasa

Re: Review Request 71458: HIVE-22163

2019-09-11 Thread Krisztian Kasa
/results/clientpositive/llap/join_reordering_no_stats.q.out fddffbb0a8 Diff: https://reviews.apache.org/r/71458/diff/2/ Changes: https://reviews.apache.org/r/71458/diff/1-2/ Testing --- New qtest: cbo_stats_estimation.q Thanks, Krisztian Kasa

Review Request 71458: HIVE-22163

2019-09-09 Thread Krisztian Kasa
/ Testing --- New qtest: cbo_stats_estimation.q Thanks, Krisztian Kasa

Re: Review Request 71458: HIVE-22163

2019-09-13 Thread Krisztian Kasa
/results/clientpositive/llap/join_reordering_no_stats.q.out fddffbb0a8 Diff: https://reviews.apache.org/r/71458/diff/4/ Changes: https://reviews.apache.org/r/71458/diff/3-4/ Testing --- New qtest: cbo_stats_estimation.q Thanks, Krisztian Kasa

Review Request 71561: HIVE-22250

2019-09-30 Thread Krisztian Kasa
d055d9ca03 ql/src/test/results/clientpositive/desc_function.q.out 1f804bba60 Diff: https://reviews.apache.org/r/71561/diff/1/ Testing --- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa

Review Request 71571: HIVE-22240

2019-10-01 Thread Krisztian Kasa
/clientpositive/udaf_percentile_disc.q.out 3ef0cf9874 Diff: https://reviews.apache.org/r/71571/diff/1/ Testing --- Existing q tests are extended with calling percentile_cont/disc with array parameters Thanks, Krisztian Kasa

Re: Review Request 71571: HIVE-22240

2019-10-02 Thread Krisztian Kasa
parameters Thanks, Krisztian Kasa

Re: Review Request 71561: HIVE-22250

2019-10-02 Thread Krisztian Kasa
://reviews.apache.org/r/71561/diff/2/ Changes: https://reviews.apache.org/r/71561/diff/1-2/ Testing --- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa

Re: Review Request 71708: HIVE-22435

2019-11-11 Thread Krisztian Kasa
is is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71708/#review218562 --- On Nov. 11, 2019, 2:25 p.m., Krisztian Kasa wrote: > > --- > Thi

Re: Review Request 71708: HIVE-22435

2019-11-11 Thread Krisztian Kasa
/71708/diff/1-2/ Testing --- run q test: vector_topnkey and limit_pushdown3 after applying the patch for TopNKey pushdown (https://issues.apache.org/jira/secure/attachment/12984389/HIVE-20150.15.patch) Thanks, Krisztian Kasa

Review Request 71730: HIVE-22464

2019-11-06 Thread Krisztian Kasa
PRE-CREATION Diff: https://reviews.apache.org/r/71730/diff/1/ Testing --- - Extend topnkey.q with creating a test table and adding rows with null values. - Query from the test tanle table. Thanks, Krisztian Kasa

Review Request 71708: HIVE-22435

2019-10-31 Thread Krisztian Kasa
) Thanks, Krisztian Kasa

Review Request 71761: HIVE-22489

2019-11-13 Thread Krisztian Kasa
://reviews.apache.org/r/71761/diff/1/ Testing --- Run tests: - TestExecDriver.java - order_null.q - sample10.q - vector_char_2.q - vector_order_null.q - vector_windowing_gby2.q Thanks, Krisztian Kasa

Re: Review Request 71708: HIVE-22435

2019-11-18 Thread Krisztian Kasa
://reviews.apache.org/r/71708/diff/4-5/ Testing --- run q test: vector_topnkey and limit_pushdown3 after applying the patch for TopNKey pushdown (https://issues.apache.org/jira/secure/attachment/12984389/HIVE-20150.15.patch) Thanks, Krisztian Kasa

Re: Review Request 71708: HIVE-22435

2019-11-12 Thread Krisztian Kasa
and limit_pushdown3 after applying the patch for TopNKey pushdown (https://issues.apache.org/jira/secure/attachment/12984389/HIVE-20150.15.patch) Thanks, Krisztian Kasa

Re: Review Request 71730: HIVE-22464

2019-11-12 Thread Krisztian Kasa
and adding rows with null values. - Query from the test table. Thanks, Krisztian Kasa

Re: Review Request 71730: HIVE-22464

2019-11-12 Thread Krisztian Kasa
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71730/#review218593 --- On Nov. 12, 2019, 9:26 a.m., Krisztian Kasa wrote: > > --

Re: Review Request 71730: HIVE-22464

2019-11-12 Thread Krisztian Kasa
and adding rows with null values. - Query from the test table. Thanks, Krisztian Kasa

Re: Review Request 71645: HIVE-22292

2019-11-05 Thread Krisztian Kasa
: TestParseWithinGroupClause.java Thanks, Krisztian Kasa

Re: Review Request 71730: HIVE-22464

2019-11-06 Thread Krisztian Kasa
/objectinspector/ObjectComparator.java PRE-CREATION Diff: https://reviews.apache.org/r/71730/diff/1/ Testing (updated) --- - Extend topnkey.q with creating a test table and adding rows with null values. - Query from the test table. Thanks, Krisztian Kasa

Re: Review Request 71645: HIVE-22292

2019-11-03 Thread Krisztian Kasa
exception will be thrown. - Krisztian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71645/#review218480 --- On Oct. 22,

Re: Review Request 71645: HIVE-22292

2019-11-03 Thread Krisztian Kasa
: TestParseWithinGroupClause.java Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-03 Thread Krisztian Kasa
ive/topnkey.q.out cecbe89b1c Diff: https://reviews.apache.org/r/71820/diff/6/ Changes: https://reviews.apache.org/r/71820/diff/5-6/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-02 Thread Krisztian Kasa
ive/topnkey.q.out cecbe89b1c Diff: https://reviews.apache.org/r/71820/diff/5/ Changes: https://reviews.apache.org/r/71820/diff/4-5/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-09 Thread Krisztian Kasa
e used when pushing through ROJ and FOJ so I would like to refactor this in a follow-up patch which implements those scenarios. Anyway I removed `static` because it is used only in this class. - Krisztian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71820/#review2189

Re: Review Request 71820: HIVE-20150

2019-12-09 Thread Krisztian Kasa
y.q Thanks, Krisztian Kasa

Re: Review Request 71835: HIVE-22508

2019-12-09 Thread Krisztian Kasa
/TestObjectInspectorUtilsCompareNull.java PRE-CREATION Diff: https://reviews.apache.org/r/71835/diff/2/ Changes: https://reviews.apache.org/r/71835/diff/1-2/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey_order_null.q TestCliDriver hypothetical_set_aggregates.q Thanks, Krisztian Kasa

Re: Review Request 71835: HIVE-22508

2019-12-09 Thread Krisztian Kasa
cally generated e-mail. To reply, visit: https://reviews.apache.org/r/71835/#review218966 --- On Dec. 9, 2019, 12:12 p.m., Krisztian Kasa wrote: > > --- > This is an automati

Re: Review Request 71820: HIVE-20150

2019-12-09 Thread Krisztian Kasa
ges: https://reviews.apache.org/r/71820/diff/8-9/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-09 Thread Krisztian Kasa
ges: https://reviews.apache.org/r/71820/diff/7-8/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-12 Thread Krisztian Kasa
tps://reviews.apache.org/r/71820/diff/11-12/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-13 Thread Krisztian Kasa
tps://reviews.apache.org/r/71820/diff/12-13/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-14 Thread Krisztian Kasa
tps://reviews.apache.org/r/71820/diff/13-14/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2019-12-17 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Dec. 17, 2019, 8:57 a.m.) Review request for hive, Jesús Camacho

Re: Review Request 71820: HIVE-20150

2019-12-12 Thread Krisztian Kasa
tps://reviews.apache.org/r/71820/diff/10-11/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2019-12-12 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Dec. 12, 2019, 2:59 p.m.) Review request for hive, Jesús Camacho

Re: Review Request 71669: HIVE-22321

2019-10-25 Thread Krisztian Kasa
Thanks, Krisztian Kasa

Re: Review Request 71669: HIVE-22321

2019-10-27 Thread Krisztian Kasa
://reviews.apache.org/r/71669/diff/3-4/ Testing --- Run existing q tests Thanks, Krisztian Kasa

Re: Review Request 71571: HIVE-22240

2019-10-14 Thread Krisztian Kasa
parameters Thanks, Krisztian Kasa

Review Request 71645: HIVE-22292

2019-10-22 Thread Krisztian Kasa
Aggregate Functions: hypothetical_set_aggregates.q Run q tests: hypothetical_set_aggregates.q, udaf_percentile_cont.q, udaf_percentile_disc.q Run unit test: TestParseWithinGroupClause.java Thanks, Krisztian Kasa

Review Request 71669: HIVE-22321

2019-10-24 Thread Krisztian Kasa
/windowing_gby2.q.out d8de2fb86b Diff: https://reviews.apache.org/r/71669/diff/1/ Testing --- Run existing q test Thanks, Krisztian Kasa

Re: Review Request 71669: HIVE-22321

2019-10-25 Thread Krisztian Kasa
) --- Run existing q tests Thanks, Krisztian Kasa

Re: Review Request 71708: HIVE-22435

2019-11-19 Thread Krisztian Kasa
/jira/secure/attachment/12984389/HIVE-20150.15.patch) Thanks, Krisztian Kasa

Re: Review Request 71708: HIVE-22435

2019-11-19 Thread Krisztian Kasa
/jira/secure/attachment/12984389/HIVE-20150.15.patch) Thanks, Krisztian Kasa

Review Request 71779: HIVE-22507

2019-11-25 Thread Krisztian Kasa
/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java ab1cfdcdb5 Diff: https://reviews.apache.org/r/71779/diff/1/ Testing --- Run topnkey.q using TestMiniLlapLocalCliDriver Thanks, Krisztian Kasa

Review Request 71820: HIVE-20150

2019-11-26 Thread Krisztian Kasa
ver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Review Request 71821: HIVE-22544

2019-11-26 Thread Krisztian Kasa
/src/test/results/clientpositive/llap/explainuser_1.q.out 735296f814 Diff: https://reviews.apache.org/r/71821/diff/1/ Testing --- TestMiniLlapLocalCliDriver: explainuser_1.q Thanks, Krisztian Kasa

Review Request 71835: HIVE-22508

2019-11-27 Thread Krisztian Kasa
://reviews.apache.org/r/71835/diff/1/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey_order_null.q TestCliDriver hypothetical_set_aggregates.q Thanks, Krisztian Kasa

Review Request 71804: HIVE-22481

2019-11-22 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71804/ --- Review request for hive and Jesús Camacho Rodríguez. Bugs: HIVE-22481

Re: Review Request 71821: HIVE-22544

2019-11-28 Thread Krisztian Kasa
--- TestMiniLlapLocalCliDriver: explainuser_1.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-11-28 Thread Krisztian Kasa
ing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71821: HIVE-22544

2019-11-28 Thread Krisztian Kasa
/diff/3/ Changes: https://reviews.apache.org/r/71821/diff/2-3/ Testing --- TestMiniLlapLocalCliDriver: explainuser_1.q Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-11-29 Thread Krisztian Kasa
ive/topnkey.q.out cecbe89b1c Diff: https://reviews.apache.org/r/71820/diff/4/ Changes: https://reviews.apache.org/r/71820/diff/3-4/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71821: HIVE-22544

2019-11-29 Thread Krisztian Kasa
--- TestMiniLlapLocalCliDriver: explainuser_1.q Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2019-11-29 Thread Krisztian Kasa
- vector_char_2.q - vector_order_null.q - vector_windowing_gby2.q Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2019-11-29 Thread Krisztian Kasa
b1ee7ecf14 Diff: https://reviews.apache.org/r/71761/diff/2/ Testing --- Run tests: - TestExecDriver.java - order_null.q - sample10.q - vector_char_2.q - vector_order_null.q - vector_windowing_gby2.q Thanks, Krisztian Kasa

Re: Review Request 71645: HIVE-22292

2019-11-04 Thread Krisztian Kasa
: TestParseWithinGroupClause.java Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-11-27 Thread Krisztian Kasa
ql/src/test/results/clientpositive/topnkey.q.out cecbe89b1c Diff: https://reviews.apache.org/r/71820/diff/2/ Changes: https://reviews.apache.org/r/71820/diff/1-2/ Testing --- Run q tests using TestMiniLlapLocalCliDriver topnkey.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 71561: HIVE-22250

2019-10-06 Thread Krisztian Kasa
://reviews.apache.org/r/71561/diff/5/ Changes: https://reviews.apache.org/r/71561/diff/4-5/ Testing --- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa

Re: Review Request 71561: HIVE-22250

2019-10-03 Thread Krisztian Kasa
/71561/diff/3/ Changes: https://reviews.apache.org/r/71561/diff/2-3/ Testing --- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa

Re: Review Request 71561: HIVE-22250

2019-10-04 Thread Krisztian Kasa
://reviews.apache.org/r/71561/diff/4/ Changes: https://reviews.apache.org/r/71561/diff/3-4/ Testing --- Added test cases to `desc_function.q`: ``` DESCRIBE FUNCTION dense_rank; DESCRIBE FUNCTION EXTENDED dense_rank; ``` Thanks, Krisztian Kasa

Re: Review Request 71571: HIVE-22240

2019-10-14 Thread Krisztian Kasa
parameters Thanks, Krisztian Kasa

Review Request 71932: HIVE-22652

2019-12-19 Thread Krisztian Kasa
: topnkey_grouping_sets.q - Run `src/test/queries/clientpositive/perf/query*.q` tests with TestTezPerfCliDriver, TestTezPerfConstraintsCliDriver Thanks, Krisztian Kasa

Re: Review Request 71820: HIVE-20150

2019-12-17 Thread Krisztian Kasa
ated e-mail. To reply, visit: https://reviews.apache.org/r/71820/#review219047 ------- On Dec. 14, 2019, 10:31 a.m., Krisztian Kasa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.or

Re: Review Request 71932: HIVE-22652

2019-12-20 Thread Krisztian Kasa
, Krisztian Kasa

Re: Review Request 71932: HIVE-22652

2019-12-20 Thread Krisztian Kasa
*.q` tests with TestTezPerfCliDriver, TestTezPerfConstraintsCliDriver Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2019-12-19 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Dec. 19, 2019, 11:35 a.m.) Review request for hive, Jesús Camacho

Re: Review Request 71820: HIVE-20150

2019-12-09 Thread Krisztian Kasa
y.q vector_topnkey.q Thanks, Krisztian Kasa

Re: Review Request 72108: HIVE-22867

2020-02-12 Thread Krisztian Kasa
=TestMiniLlapLocalCliDriver -Dqfile=vector_windowing_streaming.q,subquery_notin.q,subquery_in.q,windowing_filter.q,topnkey_windowing.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Review Request 72168: HIVE-22929

2020-02-27 Thread Krisztian Kasa
/GenericUDTFGetSplits.java 389f5cc86b Diff: https://reviews.apache.org/r/72168/diff/1/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=quotedid_basic.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Review Request 72175: HIVE-22929

2020-02-28 Thread Krisztian Kasa
0296a3d74e Diff: https://reviews.apache.org/r/72175/diff/1/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestMiniLlapLocalCliDriver -Dqfile=quotedid_basic.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 71783: Implement TopNKeyFilter efficiency check

2020-02-27 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71783/#review219672 --- Ship it! +1 LGTM - Krisztian Kasa On Feb. 27, 2020, 12:57

Review Request 72073: HIVE-22808

2020-01-31 Thread Krisztian Kasa
=intersect_all_rj.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 72073: HIVE-22808

2020-02-03 Thread Krisztian Kasa
/ Changes: https://reviews.apache.org/r/72073/diff/1-2/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 72073: HIVE-22808

2020-02-04 Thread Krisztian Kasa
: https://reviews.apache.org/r/72073/diff/2-3/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 72073: HIVE-22808

2020-02-05 Thread Krisztian Kasa
/ Changes: https://reviews.apache.org/r/72073/diff/3-4/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=intersect_all_rj.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa
,tablevalues.q,cte_join.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Review Request 72108: HIVE-22867

2020-02-11 Thread Krisztian Kasa
=vector_windowing_streaming.q,subquery_notin.q,subquery_in.q,windowing_filter.q,topnkey_windowing.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa
--- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=cte_join.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 72143: HIVE-22892

2020-02-17 Thread Krisztian Kasa
://reviews.apache.org/r/72143/diff/2/ Changes: https://reviews.apache.org/r/72143/diff/1-2/ Testing --- mvn test -Dtest.output.overwrite -DskipSparkTests -Dtest=TestCliDriver -Dqfile=cte_join.q -pl itests/qtest -Pitests Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2020-01-09 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Jan. 9, 2020, 8:03 a.m.) Review request for hive, Jesús Camacho

Review Request 71984: HIVE-22666

2020-01-13 Thread Krisztian Kasa
,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q existing UT: TestCommonKeyPrefix Thanks, Krisztian Kasa

Re: Review Request 71984: HIVE-22666

2020-01-15 Thread Krisztian Kasa
q test were added topnkey_windowing.q,topnkey_windowing_order.q New UT: TestTopNKeyFilter.java existing: windowing_filter.q,topnkey.q,topnkey_grouping_sets.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q existing UT: TestCommonKeyPrefix Thanks, Krisztian Kasa

Review Request 72013: HIVE-22735

2020-01-16 Thread Krisztian Kasa
Thanks, Krisztian Kasa

Re: Review Request 71984: HIVE-22666

2020-01-19 Thread Krisztian Kasa
,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q existing UT: TestCommonKeyPrefix Thanks, Krisztian Kasa

Re: Review Request 71761: HIVE-22489

2020-01-13 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Jan. 13, 2020, 1:32 p.m.) Review request for hive, Jesús Camacho

Re: Review Request 71761: HIVE-22489

2020-01-14 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71761/ --- (Updated Jan. 14, 2020, 8:39 p.m.) Review request for hive, Jesús Camacho

Re: Review Request 71984: HIVE-22666

2020-01-21 Thread Krisztian Kasa
,topnkey_grouping_sets.q,topnkey_grouping_sets_functions.q,topnkey_grouping_sets_order.q existing UT: TestCommonKeyPrefix Thanks, Krisztian Kasa

Re: Review Request 71995: TopN Key optimizer should use array instead of priority queue

2020-01-22 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71995/#review219355 --- Ship it! Ship It! - Krisztian Kasa On Jan. 22, 2020, 12:09

  1   2   3   >