Re: Review Request 62975: HIVE-17798: When replacing the src table names in BeeLine testing, the table names shouldn't be changed to lower case

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62975/#review188023 --- Ship it! Ship It! - Peter Vary On Oct. 13, 2017, 2:21 p.m.,

Re: Review Request 62935: HIVE-17787: Apply more filters on the BeeLine test output files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62935/#review187800 --- Ship it! Ship It! - Peter Vary On Oct. 12, 2017, 2:45 p.m.,

Re: Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/#review190136 --- Ship it! Ship It! - Peter Vary On Oct. 26, 2017, 7:04 p.m.,

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

> On Nov. 2, 2017, 10:40 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 265 (patched) > > > > > > Shouldn't we use > > parts =

Re: Review Request 63528: HIVE-17969: Metastore to alter table in batches of partitions when renaming table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63528/#review189979 --- Looks good. One question only. Thanks, Peter

Re: Review Request 62810: HIVE-17300 WebUI query plan graphs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62810/ --- (Updated Oct. 30, 2017, 4:23 p.m.) Review request for hive, Karen Coppage,

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

> On May 11, 2018, 8:51 p.m., Bharathkrishna Guruvayoor Murali wrote: > > Should I handle String inputs like 2018-05-10 12:20:10 to retain the time > > part. > > I did not do this because the inputs can have several formats if it is > > String (whereas timestamp is only in one format and it

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

> On May 11, 2018, 10:08 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAddMonths.java > > Lines 74 (patched) > > > > > > Do we think this is a better approach then the one

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

> On May 11, 2018, 10:32 a.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 2334 (patched) > > > > > > Is it possible to end up with overflowed long? You can use Java8 method.

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated May 9, 2018, 1 p.m.) Review request for hive, Alexander Kolbasov,

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202911 --- All of my other comments are fixed. Thanks, Peter

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review202907 --- Hi Bharath, Thanks for the patch! Few quick questions there (not

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > > Do you have some way of testing that all the objects are actually deleted > > from the DB? I will create an followup jira to find a way to do this. HIVE-19503 > On May 10, 2018, 11:49 a.m., Alexander Kolbasov wrote: > >

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated May 11, 2018, 2:13 p.m.) Review request for hive, Alexander Kolbasov,

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review202625 --- Almost there. Mostly just formatting questions, so you will have

Re: Review Request 66290: HIVE-14388 : Add number of rows inserted message after insert command in Beeline

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66290/#review203121 --- Ship it! +1 pending tests - Peter Vary On May 14, 2018,

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review203340 --- Ship it! +1 pending tests - Peter Vary On May 16, 2018,

Re: Review Request 67073: HIVE-19370 : Retain time part in add_months function on timestamp datatype fields in hive

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67073/#review203208 --- Thanks for the patch Bharath! One question, and one suggestion is

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

> On May 14, 2018, 7:07 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/MetaStoreDirectSql.java > > Lines 2545 (patched) > > > > > > Why not LOG.error? My

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

> On June 5, 2018, 7:37 p.m., Alexander Kolbasov wrote: > > Thanks for the review Sasha! Dropped the ones I think are should not be part of this change, but feel free to reopen them if you think otherwise. > On June 5, 2018, 7:37 p.m., Alexander Kolbasov wrote: > >

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/ --- (Updated June 6, 2018, 11:05 a.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

> On jún. 13, 2018, 4:50 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 2545 (original), 2538 (patched) > > > > > > My concern

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 14, 2018, 10:57 de) Review request for hive, Alexander Kolbasov

Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/ --- Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs:

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/ --- (Updated June 4, 2018, 9:51 a.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/ --- (Updated June 1, 2018, 10:23 a.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

> On May 31, 2018, 10:36 p.m., Vihang Karajgaonkar wrote: > > Thanks for the tests. Can we add a one more test which repeats the same > > test accross multiple sessions (can be simulated by using objectstore > > instances)? So for example: > > > > 1. Session 1 : list partitions with jdo,

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67351/ --- (Updated June 5, 2018, 7:54 a.m.) Review request for hive, Alexander Kolbasov

Re: Review Request 67351: HIVE-19718 Adding partitions in bulk also fetches table for each partition

> On June 4, 2018, 6:21 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java > > Lines 2411-2416 (original) > > > > > > Why do we need to remove

Review Request 67484: HIVE-19782 Flash out TestObjectStore.testDirectSQLDropParitionsCleanup

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67484/ --- Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs:

Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs:

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated June 7, 2018, 10:31 a.m.) Review request for hive, Alexander Kolbasov

Review Request 67399: HIVE-19503 Create a test that checks for dropPartitions with directSql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67399/ --- Review request for hive, Alexander Kolbasov and Vihang Karajgaonkar. Bugs:

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205424 --- Thanks for the fixes!

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

> On jún. 27, 2018, 12:53 du, Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 526 (patched) > > > > > > Are we sure that the location is not

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205435 --- Ship it! Great job! Thanks for all the fixes! Do not forget

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

> On jún. 27, 2018, 12:53 du, Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 526 (patched) > > > > > > Are we sure that the location is not

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 21, 2018, 8 de) Review request for hive, Alexander Kolbasov and

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

> On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > > Thanks a lot for the changes. Mostly looks good to me. Couple of minor > > suggestions. Thanks for the review Vihang! > On jún. 20, 2018, 3:06 du, Vihang Karajgaonkar wrote: > >

Re: Review Request 67753: HIVE-16950 : Dropping hive database/table which was created explicitly in default database location, deletes all databases data from default database location

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67753/#review205421 --- Thanks for the patch! Good to have these guards in place, so the

Re: Review Request 66800: HIVE-6980 Drop table by using direct sql

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66800/ --- (Updated April 26, 2018, 3:58 p.m.) Review request for hive, Alexander

Re: Review Request 66935: HIVE-18977: Listing partitions returns different results with JDO and direct SQL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66935/#review202350 --- Ship it! Ship It! - Peter Vary On May 3, 2018, 1:53 p.m.,

Re: Review Request 63144: HIVE-16748: Integreate YETUS to Pre-Commit

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63144/#review188672 --- Thanks for the patch Adam! Mostly looks good to me. Only some

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 11, 2018, 12:54 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 350 (patched) > > > > > > I think we should catch

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > Thanks for the review Vihang! > On Jan. 10, 2018, 3:35 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDatabases.java > > Lines 52 (patched) > >

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 10, 2018, 3:44 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 9, 2018, 2:50 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 8, 2018, 3:15 p.m., Marta Kuczora wrote: > > Thanks a lot for creating this testing infra for HMS testing!!! > > Overall it looks great to me, I would have only a few suggestions regarding > > the database tests. Please see my notes in the file. Thanks for the review Marta! > On

Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195795 --- Thanks for the patch Adam. Questions, and some minor comments.

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review195811 --- Thanks Marta for the patch. Some questions below. Also I think it

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review195809 --- Thanks Marta for the patch. Just one question. Peter

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- (Updated Jan. 23, 2018, 11:48 a.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

> On Jan. 23, 2018, 11:06 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > > Lines 323 (patched) > > > > > > Maybe

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

> On Jan. 23, 2018, 10:56 a.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > > Lines 285 (patched) > > > > > > Might worth to add

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- (Updated Jan. 23, 2018, 11:18 a.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review196309 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 4:37 p.m.,

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

> On Jan. 24, 2018, 5:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > > Lines 63 (patched) > > > > > > A lot of the setup and

Re: Review Request 65349: HIVE-18544: Create tests to cover methods for appending Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196338 --- Ship it! Ship It! - Peter Vary On Jan. 26, 2018, 1:03 p.m.,

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65018/ --- (Updated Jan. 12, 2018, 11:58 a.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65018: HIVE-18372 Create testing infra to test different HMS instances

> On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > > Overall looks good. Thanks for taking this up. I suggested some small > > improvements to the tests below. Thanks Adam and Vihang for the review! > On Jan. 10, 2018, 6:35 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196234 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 2:02 p.m.,

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

> On Jan. 24, 2018, 5:50 p.m., Sahil Takiar wrote: > > Thanks for the review Sahil! > On Jan. 24, 2018, 5:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > > Lines 63 (patched) > >

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- (Updated Jan. 25, 2018, 1:01 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/#review196254 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 4:37 p.m.,

Re: Review Request 65284: Create tests to cover listPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/#review196255 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 1:47 p.m.,

Re: Review Request 65219: HIVE-18486: Create tests to cover methods for adding Partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65219/#review196256 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2018, 2:40 p.m.,

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review196257 --- Ship it! Ship It! - Peter Vary On Jan. 24, 2018, 3:41 p.m.,

Re: Review Request 65353: Create tests to cover getTableMeta method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65353/#review196416 --- Thanks for the patch Adam. I was only be able to come up 1 more

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196431 --- Nice throughout test cases. Thanks Marta! Fix it and ship it!

Re: Review Request 65380: HIVE-18566: Create tests to cover adding partitions from PartitionSpec

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196516 --- Ship it! Ship It! - Peter Vary On Jan. 30, 2018, 8:15 a.m.,

Re: Review Request 65331: HIVE-17751 Separate HMS Client and HMS server into separate sub-modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65331/#review196978 --- Thanks for the proposal Sasha! I agree, that we should separate

Re: Review Request 65507: HIVE-18580: Create tests to cover exchange partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196982 --- Ship it! Ship It! - Peter Vary On Feb. 5, 2018, 6:01 p.m.,

Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- Review request for hive, Marta Kuczora, Sahil Takiar, and Adam Szita. Bugs:

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

> On Feb. 22, 2018, 4:45 p.m., Sahil Takiar wrote: > > so just to clarify, the creation of metastore instances is moving from the > > individual contructors to a `BeforeClass` method? Thanks for the review! Yes! This is the main change in the patch - run start the metastore instances once per

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 6:49 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 7:02 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65730: HIVE-18697: The HiveMetastore.exchange_partitions method throws FileNotFoundException if the given partition doesn't exist in the source table

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65730/#review197847 --- Ship it! Ship It! - Peter Vary On Feb. 21, 2018, 10:36

Re: Review Request 65716: HIVE-18696: The partition folders might not get cleaned up properly in the HiveMetaStore.add_partitions_core method if an exception occurs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65716/#review197843 --- Thanks for the patch Marta! Mostly just questions. Peter

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review197848 --- Thanks Marta! Just a quick querstion.

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67485/ --- (Updated jún. 19, 2018, 12:23 du) Review request for hive, Alexander Kolbasov

Re: Review Request 67485: HIVE-19783 Retrieve only locations in HiveMetaStore.dropPartitionsAndGetLocations

> On jún. 13, 2018, 4:50 du, Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Line 2545 (original), 2538 (patched) > > > > > > My concern

Re: Review Request 68496: Optimized & cleaned up HBaseQTest runner

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68496/#review207858 --- Thank you Denis for the patch! Nice work, just 1 question and

Re: Review Request 68523: Improve org.apache.hadoop.hive.ql.exec.FunctionTask Experience

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68523/#review208033 --- Thanks for the patch. LGTM, just one question regarding the

Re: Review Request 67801: HIVE-19337 Partition whitelist regex doesn't work (and never did)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67801/#review205844 --- Looks good. Might be good idea to have a test for this.

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 24, 2018, 10:52 a.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > A few comments, in general the tests look very thorough. Nice work! Thanks for the review Sahil! > On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > >

Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- Review request for hive, Alan Gates, Marta Kuczora, Adam Szita, and Vihang

Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/#review195898 --- Nice job, looks good to me, one minor question

Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar.

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 22, 2018, 2:33 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 409 (patched) > > > > > > After dropping the functions,

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- (Updated Jan. 22, 2018, 3:36 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- (Updated Jan. 22, 2018, 3:38 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195904 --- Thanks for the patch Marta! Only one question below

Re: Review Request 65285: Create tests to cover getPartition(s) methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196018 --- Just 2 more test cases I can come up with. Is it worth to create

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 23, 2018, 4:47 p.m.) Review request for hive, Alan Gates, Marta

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

> On Jan. 23, 2018, 2:07 p.m., Adam Szita wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 103 (patched) > > > > > > Should we extract > >

  1   2   3   >