Re: Review Request 62816: HIVE-17729 Add Database & Explain related blobstore tests

2017-11-01 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62816/#review189798 --- Ship it! Ship It! - Sergio Pena On Oct. 6, 2017, 7:13 p.m.,

Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

2018-05-06 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66979/ --- Review request for hive and Vihang Karajgaonkar. Bugs: HIVE-19374

Review Request 67121: HIVE-19527: Preparing for 2.4 development

2018-05-14 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67121/ --- Review request for hive and Peter Vary. Bugs: HIVE-19527

Re: Review Request 66979: HIVE-19374: Parse and process ALTER TABLE SET OWNER command syntax

2018-05-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66979/ --- (Updated May 8, 2018, 11:57 p.m.) Review request for hive and Vihang

Re: Review Request 67186: HIVE-19585: Add UNKNOWN to PrincipalType

2018-05-17 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67186/#review203369 ---

Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

2018-05-01 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66890/ --- Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang

Review Request 66909: HIVE-19372: Add table ownerType to JDO/SQL and ObjectStore

2018-05-02 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66909/ --- Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang

Re: Review Request 66890: HIVE-19371: Add table ownerType to HMS thrift API

2018-05-02 Thread Sergio Pena via Review Board
> On May 2, 2018, 5:49 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb > > Lines 1071 (patched) > > > > > > Is it possible to write a test to make sure this

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
> On March 13, 2018, 3:35 a.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 362 (patched) > > > > > > Would it make sense to move

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
> On March 12, 2018, 4:45 p.m., Na Li wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 372 (patched) > > > > > > why when db name is changed at alter

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/ --- (Updated March 15, 2018, 5:45 p.m.) Review request for hive, Alexander

Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-08 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/ --- Review request for hive, Alexander Kolbasov, Sahil Takiar, and Vihang

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/ --- (Updated April 4, 2018, 4:06 p.m.) Review request for hive, Alexander

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

2018-12-20 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review211465 ---

Re: Review Request 69642: HIVE-20977: Lazy evaluate the table object in PreReadTableEvent to improve get_partition performance

2019-01-03 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69642/#review211643 ---