Review Request 26172: HiveServer2 in http-kerberos & doAs=true is failing with org.apache.hadoop.security.AccessControlException

2014-09-30 Thread Vaibhav Gumashta
/cli/thrift/ThriftCLIService.java c4b273c service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpCLIService.java 795115e Diff: https://reviews.apache.org/r/26172/diff/ Testing --- Manually on a secure cluster. Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive Committer - John Pullokkaran

2014-10-01 Thread Vaibhav Gumashta
Congrats John! On Wed, Oct 1, 2014 at 12:28 PM, Hari Subramaniyan < hsubramani...@hortonworks.com> wrote: > Congrats John! > > On Wed, Oct 1, 2014 at 11:06 AM, Thejas Nair > wrote: > > > Congrats John! > > > > > > On Wed, Oct 1, 2014 at 11:00 AM, Szehon Ho wrote: > > > Congratulations John! >

Re: Review Request 19880: HiveServer2 needs to map kerberos name to local name before proxy check

2014-10-01 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19880/#review55137 --- Ship it! Ship It! - Vaibhav Gumashta On Oct. 1, 2014, 9:13 p.m

Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-01 Thread Vaibhav Gumashta
/java/org/apache/hive/service/server/ServerOptionsProcessor.java bbb2a42 service/src/test/org/apache/hive/service/server/TestServerOptionsProcessor.java 1aea0b8 Diff: https://reviews.apache.org/r/26255/diff/ Testing --- Manually with multiple HS2 instances. Thanks, Vaibhav Gumashta

Review Request 26277: Shim KerberosName (causes build failure on hadoop-1)

2014-10-02 Thread Vaibhav Gumashta
://reviews.apache.org/r/26277/diff/ Testing --- Thanks, Vaibhav Gumashta

Review Request 26282: Hook HiveServer2 dynamic service discovery with session time out

2014-10-02 Thread Vaibhav Gumashta
/service/auth/TestPlainSaslHelper.java fb784aa service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 47d3a56 Diff: https://reviews.apache.org/r/26282/diff/ Testing --- Manually with ZooKeeper. Thanks, Vaibhav Gumashta

Re: Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-02 Thread Vaibhav Gumashta
Message, e); Sure, will do. - Vaibhav ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26255/#review55262 --- On Oc

Re: Review Request 26277: Shim KerberosName (causes build failure on hadoop-1)

2014-10-03 Thread Vaibhav Gumashta
/Hadoop23Shims.java 0731108 shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 4fcaa1e Diff: https://reviews.apache.org/r/26277/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26277: Shim KerberosName (causes build failure on hadoop-1)

2014-10-03 Thread Vaibhav Gumashta
/Hadoop23Shims.java 0731108 shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 4fcaa1e Diff: https://reviews.apache.org/r/26277/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.

2014-10-03 Thread Vaibhav Gumashta
ache.org/r/26321/#comment95741> Can you add a comment here explaining the intent of using HIVE_HADOOP_CLASSPATH? - Vaibhav Gumashta On Oct. 3, 2014, 6:27 p.m., XIAOBING ZHOU wrote: > > --- > This is an automatically

Review Request 26325: HiveServer2 dynamic service discovery should let the JDBC client use default ZooKeeper namespace

2014-10-03 Thread Vaibhav Gumashta
://reviews.apache.org/r/26325/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26321: HiveServer2 service doesn't stop backend jvm process, which prevents follow-up service start.

2014-10-03 Thread Vaibhav Gumashta
> On Oct. 3, 2014, 7:06 p.m., Vaibhav Gumashta wrote: > > bin/ext/hiveserver2.cmd, line 82 > > <https://reviews.apache.org/r/26321/diff/1/?file=713542#file713542line82> > > > > I don't think the "-hiveconf" paramaters should be part of the cmd

Re: Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-06 Thread Vaibhav Gumashta
multiple HS2 instances. Thanks, Vaibhav Gumashta

Re: Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-06 Thread Vaibhav Gumashta
multiple HS2 instances. Thanks, Vaibhav Gumashta

Re: Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-06 Thread Vaibhav Gumashta
multiple HS2 instances. Thanks, Vaibhav Gumashta

Re: Review Request 26255: HiveServer2 dynamic discovery should create znodes organized by version number & add support for removing server uri's of a particular version from the server script.

2014-10-07 Thread Vaibhav Gumashta
multiple HS2 instances. Thanks, Vaibhav Gumashta

Re: [VOTE] officially stop supporting hadoop 0.20.x in hive 0.14 ?

2014-10-07 Thread Vaibhav Gumashta
+1. Thanks, --Vaibhav On Tue, Oct 7, 2014 at 3:53 PM, Thejas Nair wrote: > I think it is time to revisit the support for hive support for hadoop > 0.20. Trying to maintain support for it puts additional burden on hive > contributors. > > The last hadoop 0.20.x version was released on Feb 2010.

Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
use httpPath like so: jdbc:hive2://:/dbName;httpPath= Connected to: Apache Hive (version 0.14.0-SNAPSHOT) Driver: Hive JDBC (version 0.14.0-SNAPSHOT) Transaction isolation: TRANSACTION_REPEATABLE_READ Thanks, Vaibhav Gumashta

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
ted. 14/10/07 16:22:24 WARN jdbc.Utils: Please use httpPath like so: jdbc:hive2://:/dbName;httpPath= Connected to: Apache Hive (version 0.14.0-SNAPSHOT) Driver: Hive JDBC (version 0.14.0-SNAPSHOT) Transaction isolation: TRANSACTION_REPEATABLE_READ Thanks, Vaibhav Gumashta

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
-------- On Oct. 7, 2014, 11:50 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26429/ > -

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-07 Thread Vaibhav Gumashta
nks, Vaibhav Gumashta

Re: Review Request 26429: jdbc HTTP configuration options should be part of sessionConf part of connection string

2014-10-09 Thread Vaibhav Gumashta
ion: TRANSACTION_REPEATABLE_READ Thanks, Vaibhav Gumashta

Re: updating a patch while the precommit build is in Jenkins queue

2014-10-10 Thread Vaibhav Gumashta
AFAIK, it runs the latest patch. Thanks, --Vaibhav On Fri, Oct 10, 2014 at 12:53 PM, Sergey Shelukhin wrote: > Hi. > I have a JIRA that is in Jenkins queue for precommit build. It won't run > for a while. Does anyone know if the queued job will run the patch that > triggered it, or the latest p

Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-16 Thread Vaibhav Gumashta
/HadoopShims.java 99a2bcf Diff: https://reviews.apache.org/r/26844/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-16 Thread Vaibhav Gumashta
/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 99a2bcf Diff: https://reviews.apache.org/r/26844/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-16 Thread Vaibhav Gumashta
6e1ad03 shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 99a2bcf Diff: https://reviews.apache.org/r/26844/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-16 Thread Vaibhav Gumashta
/ZooKeeperHiveHelper.java <https://reviews.apache.org/r/26844/#comment97541> I'll turn the debug mode off. - Vaibhav Gumashta On Oct. 16, 2014, 11:54 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-17 Thread Vaibhav Gumashta
/HadoopShimsSecure.java 6e1ad03 shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 99a2bcf Diff: https://reviews.apache.org/r/26844/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 26844: HiveServer2 dynamic service discovery: figure out best ZooKeeper ACLs for security

2014-10-17 Thread Vaibhav Gumashta
/HadoopShimsSecure.java 6e1ad03 shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShims.java 99a2bcf Diff: https://reviews.apache.org/r/26844/diff/ Testing --- Thanks, Vaibhav Gumashta

Review Request 26893: Enable Kerberized SSL for HiveServer2 in http mode

2014-10-17 Thread Vaibhav Gumashta
Diff: https://reviews.apache.org/r/26893/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive PMC Member - Alan Gates

2014-10-27 Thread Vaibhav Gumashta
Congratulations Alan! On Mon, Oct 27, 2014 at 3:54 PM, Chris Drome wrote: > Congratulations Alan! > > From: Carl Steinbach > Reply-To: "u...@hive.apache.org" > Date: Monday, October 27, 2014 at 3:38 PM > To: "dev@hive.apache.org" , "u...@hive.apache.org" < > u...@hive.apache.org>, "ga...@ap

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

2014-10-27 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27263/#review58777 --- Ship it! Ship It! - Vaibhav Gumashta On Oct. 28, 2014, 3:12 a.m

Re: Review Request 27216: HIVE-8557 : automatically setup ZooKeeperTokenStore to use kerberos authentication when kerberos is enabled

2014-10-28 Thread Vaibhav Gumashta
nStore.java <https://reviews.apache.org/r/27216/#comment100016> Nit: it will be good to have a self documenting variable name instead of csv. - Vaibhav Gumashta On Oct. 28, 2014, 6:35 a.m., Thejas Nair wrote: > > --- > Th

Re: Review Request 27216: HIVE-8557 : automatically setup ZooKeeperTokenStore to use kerberos authentication when kerberos is enabled

2014-10-28 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27216/#review58961 --- Ship it! Ship It! - Vaibhav Gumashta On Oct. 29, 2014, 12:29

Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-29 Thread Vaibhav Gumashta
pom.xml 69f4413 service/pom.xml 9d47a69 service/src/java/org/apache/hive/service/server/HiveServer2.java 0aab3f9 Diff: https://reviews.apache.org/r/27362/diff/ Testing --- Manual testing with ZK. Thanks, Vaibhav Gumashta

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
/ Testing (updated) --- Manual testing with ZK on secure cluster & with 10 threads opening concurrent connection, executing queries for an hour. Thanks, Vaibhav Gumashta

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
eviews.apache.org/r/27362/#review59104 --- On Oct. 30, 2014, 8:19 a.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27362/ >

Re: Review Request 27362: Use Apache Curator in JDBC Driver and HiveServer2 for better reliability

2014-10-30 Thread Vaibhav Gumashta
gn with Thejas. Indentation looks fine. - Vaibhav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27362/#review59217 --- On Oct. 30, 2014,

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-25 Thread Vaibhav Gumashta
: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-26 Thread Vaibhav Gumashta
/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

Re: Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-08-26 Thread Vaibhav Gumashta
as well? Sorry about this. Editor settings were adding the cleanup. - Vaibhav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23320/#review51558 ---------

Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-02 Thread Vaibhav Gumashta
/ Testing --- Manual testing + test cases. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
ot trying to set its value). I'll create a follow up jira to do that cleanup. And I agree, we can keep variable names short in sess_var_list and probably use a camelCase convention to keep the intent clear. - Vaibhav --------

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
------ On Sept. 2, 2014, 10:05 a.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25245/ > --

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
://reviews.apache.org/r/25245/diff/ Testing --- Manual testing + test cases. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-07 Thread Vaibhav Gumashta
://reviews.apache.org/r/25245/diff/ Testing (updated) --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-08 Thread Vaibhav Gumashta
.java 124996c service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-08 Thread Vaibhav Gumashta
/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 47fe508 Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
5dce16f ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f149a Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
5dce16f ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 5bbf3f6 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 08f149a Diff: https://reviews.apache.org/r/25460/diff/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 25460: Recursive root scratch directory creation is not using hdfs umask properly

2014-09-09 Thread Vaibhav Gumashta
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25460/#review52795 ------- On Sept. 9, 2014, 11:06 p.m., Vaibhav Gumashta wrote: > > -

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-10 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-10 Thread Vaibhav Gumashta
eviews.apache.org/r/25245/#review52637 --- On Sept. 10, 2014, 9:43 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Timeline for release of Hive 0.14

2014-09-11 Thread Vaibhav Gumashta
Hi Vikram, Can we also add: https://issues.apache.org/jira/browse/HIVE-6799 & https://issues.apache.org/jira/browse/HIVE-7935 to the list. Thanks, --Vaibhav On Wed, Sep 10, 2014 at 12:18 AM, Satish Mittal wrote: > Hi, > Can you please include HIVE-7892 (Thrift Set type not working with Hive) a

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
<https://reviews.apache.org/r/25245/#comment92378> I'll get rid of this import - leftover from different things I was trying. service/src/java/org/apache/hive/service/cli/CLIService.java <https://reviews.apache.org/r/25245/#comment92379> Will get rid of this too. - Vaib

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
change. - Vaibhav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review53067 --- On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta w

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
e-mail. To reply, visit: https://reviews.apache.org/r/25245/#review53095 ------- On Sept. 11, 2014, 1:08 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generate

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-11 Thread Vaibhav Gumashta
hanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-12 Thread Vaibhav Gumashta
service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New Hive Committer - Eugene Koifman

2014-09-12 Thread Vaibhav Gumashta
Congrats Eugene! On Fri, Sep 12, 2014 at 3:35 PM, Carl Steinbach wrote: > The Apache Hive PMC has voted to make Eugene Koifman a committer on the > Apache Hive Project. > > Please join me in congratulating Eugene! > > Thanks. > > - Carl > > -- CONFIDENTIALITY NOTICE NOTICE: This message is int

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-14 Thread Vaibhav Gumashta
--- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-15 Thread Vaibhav Gumashta
4067106 service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Re: Review Request 25245: Support dynamic service discovery for HiveServer2

2014-09-15 Thread Vaibhav Gumashta
4067106 service/src/java/org/apache/hive/service/server/HiveServer2.java 124996c service/src/test/org/apache/hive/service/cli/session/TestSessionGlobalInitFile.java 66fc1fc Diff: https://reviews.apache.org/r/25245/diff/ Testing --- Manual testing. Thanks, Vaibhav Gumashta

Review Request 25711: Create root scratch dir with 733 instead of 777 perms

2014-09-16 Thread Vaibhav Gumashta
b430cae itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHS2.java 241d315 ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d7227ed Diff: https://reviews.apache.org/r/25711/diff/ Testing --- Unit + manual Thanks, Vaibhav Gumashta

Re: Review Request 25711: Create root scratch dir with 733 instead of 777 perms

2014-09-16 Thread Vaibhav Gumashta
Thanks, Vaibhav Gumashta

Review Request 26005: HiveServer2 in http-kerberos mode is restrictive on client usernames

2014-09-24 Thread Vaibhav Gumashta
/ThriftHttpServlet.java 99ef8bc Diff: https://reviews.apache.org/r/26005/diff/ Testing --- Manual testing on secure cluster. Thanks, Vaibhav Gumashta

Review Request 26124: JDBC uber jar is missing some classes required in secure setup.

2014-09-27 Thread Vaibhav Gumashta
. Thanks, Vaibhav Gumashta

Re: Review Request 26124: JDBC uber jar is missing some classes required in secure setup.

2014-09-28 Thread Vaibhav Gumashta
/ Testing --- Manually on a secure cluster. Thanks, Vaibhav Gumashta

Re: [ANNOUNCE] New PMC Member : Peter Vary

2018-08-01 Thread Vaibhav Gumashta
Congrats Peter! On 8/1/18, 11:31 AM, "Chaoyu Tang" wrote: Congratulations, Peter. On Wed, Aug 1, 2018 at 2:08 PM, Peter Vary wrote: > Thanks everyone! > > Rajesh Balamohan ezt írta (időpont: 2018. júl. > 31., > Ke 13:41): > > > Congratulations

Re: [ANNOUNCE] New PMC Member : Sahil Takiar

2018-08-01 Thread Vaibhav Gumashta
Congrats Sahil! On 8/1/18, 11:32 AM, "Chaoyu Tang" wrote: Congratulations Sahil! On Tue, Jul 31, 2018 at 7:40 AM, Rajesh Balamohan wrote: > Congratulations Sahil! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:57 PM Marta Kuczora > > wrote:

Re: [ANNOUNCE] New PMC Member : Vineet Garg

2018-08-01 Thread Vaibhav Gumashta
Congrats Vineet! On 8/1/18, 11:33 AM, "Chaoyu Tang" wrote: Congratulations Vineet! On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan < rajesh.balamo...@gmail.com> wrote: > Congratulations Vineet! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:34 PM Ma

Re: [ANNOUNCE] New PMC Member : Vihang Karajgaonkar

2018-08-01 Thread Vaibhav Gumashta
Congrats Vihang! On 8/1/18, 11:33 AM, "Chaoyu Tang" wrote: Congratulations Vihang. On Tue, Jul 31, 2018 at 7:39 AM, Rajesh Balamohan wrote: > Congratulations Vihang! > > ~Rajesh.B > > > On Tue, Jul 31, 2018 at 3:35 PM Marta Kuczora > > wrot

Re: [ANNOUNCE] New committer: Andrew Sherman

2018-09-04 Thread Vaibhav Gumashta
Congratulations Andrew! On 9/4/18, 10:36 AM, "Sahil Takiar" wrote: Congrats Andrew! On Tue, Sep 4, 2018 at 12:02 AM Antal Sinkovits wrote: > Congratulations Andrew! > > Deepak Jaiswal ezt írta (időpont: 2018. szept. > 4., K 7:34): > > > Congratulat

Re: [ANNOUNCE] New committer: Nishant Bangarwa

2018-10-19 Thread Vaibhav Gumashta
Congrats Nishant. On 10/19/18, 11:12 AM, "Prasanth Jayachandran" wrote: Congratulations! > On Oct 19, 2018, at 11:10 AM, Vihang Karajgaonkar wrote: > > Congrats Nishant! > > On Fri, Oct 19, 2018 at 11:02 AM, Deepak Jaiswal > wrote: > >> Congratula

Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-10-24 Thread Vaibhav Gumashta
/hive/metastore/cache/TestCachedStore.java bb20d9f42a standalone-metastore/metastore-server/src/test/resources/log4j2.properties 365687e1c9 Diff: https://reviews.apache.org/r/69143/diff/1/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69143: CachedStore: Add more UT coverage (outside of .q files)

2018-11-01 Thread Vaibhav Gumashta
/ Testing --- Thanks, Vaibhav Gumashta

Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-15 Thread Vaibhav Gumashta
/r/69367/diff/1/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-18 Thread Vaibhav Gumashta
in there (unlikely, since the sql query we run adds a partition filter). - Vaibhav ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69367/#review210589 ---

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-18 Thread Vaibhav Gumashta
or compactions - are > > current config params adequate? Should do at least the 2nd part in a > > follow up jira, maybe both. > > Vaibhav Gumashta wrote: > Created https://jira.apache.org/jira/browse/HIVE-20933 NM, addressing this as part of this jira itself as it&#x

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2018-11-19 Thread Vaibhav Gumashta
/udf/generic/GenericUDFValidateAcidSortOrder.java PRE-CREATION Diff: https://reviews.apache.org/r/69367/diff/2/ Changes: https://reviews.apache.org/r/69367/diff/1-2/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-08 Thread Vaibhav Gumashta
/GenericUDFValidateAcidSortOrder.java PRE-CREATION Diff: https://reviews.apache.org/r/69367/diff/3/ Changes: https://reviews.apache.org/r/69367/diff/2-3/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-10 Thread Vaibhav Gumashta
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java PRE-CREATION Diff: https://reviews.apache.org/r/69367/diff/4/ Changes: https://reviews.apache.org/r/69367/diff/3-4/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-18 Thread Vaibhav Gumashta
://reviews.apache.org/r/69367/diff/4-5/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-18 Thread Vaibhav Gumashta
://reviews.apache.org/r/69367/diff/5-6/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-21 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-25 Thread Vaibhav Gumashta
awRecordMerger.java > fbb931cbcd > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java > 6d4578e7a0 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 4d55592b63 > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java > 0e5b3e5473 > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > dc05e1990e > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Initiator.java > a0df82cb20 > > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFValidateAcidSortOrder.java > PRE-CREATION > ql/src/test/results/clientpositive/show_functions.q.out 0fdcbda66f > > > Diff: https://reviews.apache.org/r/69367/diff/7/ > > > Testing > --- > > > Thanks, > > Vaibhav Gumashta > >

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-25 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-01-28 Thread Vaibhav Gumashta
--- Thanks, Vaibhav Gumashta

Re: Review Request 69367: Query based compactor for full CRUD Acid tables

2019-02-01 Thread Vaibhav Gumashta
quot;currentTransaction": 3, "row": {"a": 3, "b": 4, "c": 1002}} {"operation": 0, "originalTransaction": 3, "bucket": 536936448, "rowId": 2, "currentTransaction": 3, "row": {"a": 4, &

Re: Null pointer exception on running compaction against an MM table

2019-02-15 Thread Vaibhav Gumashta
t;dev@hive.apache.org" Cc: Eugene Koifman , Vaibhav Gumashta , Gopal Vijayaraghavan Subject: Null pointer exception on running compaction against an MM table [mage removed by sender.] Hi, I was trying to run compaction on MM table but got a null pointer exception while getting HDFS session path.

Re: Null pointer exception on running compaction against an MM table

2019-02-18 Thread Vaibhav Gumashta
The approach is similar, but it is not identical. Let me go over the query based compaction codepath to see if I spot this bug there. Thanks, --Vaibhav From: Aditya Shah Date: Saturday, February 16, 2019 at 3:44 AM To: Vaibhav Gumashta Cc: "dev@hive.apache.org" , Eugene Koifma

Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-10 Thread Vaibhav Gumashta
/TestExecDriver.java 78f25856a4 ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java a75103d60d Diff: https://reviews.apache.org/r/71044/diff/1/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-10 Thread Vaibhav Gumashta
/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 78f25856a4 ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java a75103d60d Diff: https://reviews.apache.org/r/71044/diff/2/ Changes: https://reviews.apache.org/r/71044/diff/1-2/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-12 Thread Vaibhav Gumashta
/org/apache/hadoop/hive/ql/exec/TestExecDriver.java 78f25856a4 ql/src/test/org/apache/hadoop/hive/ql/exec/TestFileSinkOperator.java a75103d60d Diff: https://reviews.apache.org/r/71044/diff/3/ Changes: https://reviews.apache.org/r/71044/diff/2-3/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 71044: ACID: explore how we can avoid a move step during inserts/compaction

2019-07-12 Thread Vaibhav Gumashta
/mm_all.q.out 6cb34e2c79 ql/src/test/results/clientpositive/mm_all.q.out 2c0247a539 Diff: https://reviews.apache.org/r/71044/diff/4/ Changes: https://reviews.apache.org/r/71044/diff/3-4/ Testing --- Thanks, Vaibhav Gumashta

Review Request 71091: ACID: getAcidState() should cache a recursive dir listing locally

2019-07-17 Thread Vaibhav Gumashta
b5958fa9cc ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java 8451462023 streaming/src/test/org/apache/hive/streaming/TestStreaming.java c6d7e7f27c Diff: https://reviews.apache.org/r/71091/diff/1/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 71091: ACID: getAcidState() should cache a recursive dir listing locally

2019-07-18 Thread Vaibhav Gumashta
://reviews.apache.org/r/71091/diff/1-2/ Testing --- Thanks, Vaibhav Gumashta

Re: Review Request 71091: ACID: getAcidState() should cache a recursive dir listing locally

2019-07-22 Thread Vaibhav Gumashta
://reviews.apache.org/r/71091/diff/2-3/ Testing --- Thanks, Vaibhav Gumashta

Review Request 23320: HiveServer2 using embedded MetaStore leaks JDOPersistanceManager

2014-07-07 Thread Vaibhav Gumashta
/SQLOperation.java de54ca1 Diff: https://reviews.apache.org/r/23320/diff/ Testing --- Manual testing using Yourkit. Thanks, Vaibhav Gumashta

  1   2   3   4   5   6   7   8   9   10   >