Re: Review Request 27699: HIVE-8435
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 19, 2014, 11:51 a.m.) Review request for hive and Ashutosh Chauhan. Changes --- Only observed changes in results in infer_bucket_sort.q, multiMapJoin1.q, windowing.q, and in Tez mrr.q (change of order of results). The rest are changes in the plans. Ashutosh, can you check? Repository: hive-git Description (updated) --- HIVE-8435 Patch with the most conservative approach of project remover optimization. Diffs (updated) - accumulo-handler/src/test/results/positive/accumulo_queries.q.out 254eeaba4b8d633c63c706c0c74bb1165089 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8411c9edb2f2db84cf2540deb20133c36152103 hbase-handler/src/test/results/positive/hbase_queries.q.out b1e7936738b1121c14132909178646290ee8b4d5 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 718b43c6e0fc2c28981f8caf0f38c1360e69837d ql/src/test/results/clientpositive/auto_join0.q.out 9261ce02f3cfcfd9f048f15fe7357846bb386c31 ql/src/test/results/clientpositive/auto_join10.q.out 3d2bcc216dea80522002f149e5777a73ca52fe5b ql/src/test/results/clientpositive/auto_join11.q.out 8dbad6724475b71dc53d1198c77e36dfe752484e ql/src/test/results/clientpositive/auto_join12.q.out 037116c2c6994fe8bc7bccbb89950a13854cd9af ql/src/test/results/clientpositive/auto_join13.q.out 0cb9b4ffc460121584887f395eb1697bd53013c3 ql/src/test/results/clientpositive/auto_join16.q.out f96bae3590f5e26b059458650dd508b3dd4b1235 ql/src/test/results/clientpositive/auto_join18.q.out 0de3f2a2c8ca5646071fb852c838337b76aab9f9 ql/src/test/results/clientpositive/auto_join18_multi_distinct.q.out 46559a746f51fa3ad516629220bcf0f31bef685a ql/src/test/results/clientpositive/auto_join24.q.out 1fa3e6ea54f809c529d4ec7b50d5d5191284939f ql/src/test/results/clientpositive/auto_join26.q.out d494d95785283b7083820d0defaadb351f783085 ql/src/test/results/clientpositive/auto_join27.q.out c16992f2bed4de9dd23dcfbe004825f37abbe56e ql/src/test/results/clientpositive/auto_join30.q.out 608ca22323e3b4f1900dd5077a7aecf54d8a8ca2 ql/src/test/results/clientpositive/auto_join31.q.out b0df20270ba3dbb9115c529c50aaca5d13d57a95 ql/src/test/results/clientpositive/auto_join32.q.out bc2d56c0199133e84efd213dff1538173f1686c7 ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 2583d9a50d4a07db50dca7f88c6db141c392a3b8 ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 5a7f174a52d60028f524a7aac14a9b326d060af8 ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 7606dd2adcd43ca410e66e0c8f1799084fa4f39e ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 8372a6312a2fe85fd78f0c6da0665164b49b320c ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3c30a315d9028fda114def015e41a6171341153a ql/src/test/results/clientpositive/auto_sortmerge_join_14.q.out 69bd43af9a8210b19cbea17181f90bf707d93e85 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out 10b20d84eb06a30ed3655e346431bc52dfb486fe ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 72242bbd713baa216d41c40749f9c732271102cb ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 35fa02fa60f6c50d6acf55ed3fae1570a644c1e1 ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 4fea70d4e47bbd75530e92f5b2a8be2edd66bdbd ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 1904cc246729a8d3fd2cd1815e563b50e261da6a ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out e5e2a6a770d5064df944c69576d81d07b1d95c77 ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out abb1db4a87e6b8e820ff7df53d21a4036254b098 ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 9226dc6b2929c2b185f5904bd607a7b18e356dca ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 1a7fdf9650f3e5650400ecc24177637856701536 ql/src/test/results/clientpositive/bucket_map_join_1.q.out b194a2be3e39c0294df14c00fe69c6d6f9283702 ql/src/test/results/clientpositive/bucket_map_join_2.q.out 07c887854179e333e4c68d02c247216b1c06dee7 ql/src/test/results/clientpositive/bucketcontext_1.q.out 0ea304dbff38d878d271930cda22b852f0175329 ql/src/test/results/clientpositive/bucketcontext_2.q.out e961f062d1cf21d058566c6c9c6a73db16a3454e ql/src/test/results/clientpositive/bucketcontext_3.q.out 1de62119c2909f4ff49dcec0a50843df7a00419a
Re: Review Request 27699: HIVE-8435
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 18, 2014, 7:13 p.m.) Review request for hive and Ashutosh Chauhan. Summary (updated) - HIVE-8435 Repository: hive-git Description (updated) --- HIVE-8435 HIVE-8435 Diffs (updated) - accumulo-handler/src/test/results/positive/accumulo_queries.q.out 254eeaba4b8d633c63c706c0c74bb1165089 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8411c9edb2f2db84cf2540deb20133c36152103 contrib/src/test/results/clientpositive/lateral_view_explode2.q.out 74a7e1719f8e026aaecd53fc147258620a75ccc4 hbase-handler/src/test/results/positive/hbase_queries.q.out b1e7936738b1121c14132909178646290ee8b4d5 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 ql/src/test/queries/clientpositive/identity_proj_remove.q PRE-CREATION ql/src/test/results/clientpositive/identity_proj_remove.q.out PRE-CREATION ql/src/test/results/compiler/plan/groupby1.q.xml PRE-CREATION Diff: https://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez
Re: Review Request 27699: HIVE-8435
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 18, 2014, 7:21 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description (updated) --- HIVE-8435 Patch with the most conservative approach of project remover optimization. Diffs (updated) - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8411c9edb2f2db84cf2540deb20133c36152103 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 Diff: https://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez
Re: Review Request 27699: HIVE-8435
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/#review61985 --- contrib/src/test/results/clientpositive/lateral_view_explode2.q.out https://reviews.apache.org/r/27699/#comment103905 Results are changed. Looks suspicious. ql/src/test/results/compiler/plan/groupby1.q.xml https://reviews.apache.org/r/27699/#comment103904 you need to rebase your git repo. These test cases were deleted via HIVE-8862 - Ashutosh Chauhan On Nov. 18, 2014, 7:21 p.m., Jesús Camacho Rodríguez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 18, 2014, 7:21 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- HIVE-8435 Patch with the most conservative approach of project remover optimization. Diffs - common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8411c9edb2f2db84cf2540deb20133c36152103 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 Diff: https://reviews.apache.org/r/27699/diff/ Testing --- Thanks, Jesús Camacho Rodríguez
Re: Review Request 27699: HIVE-8435: Add identity project remover optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 8, 2014, 5:26 p.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Patch with the most conservative approach of project remover optimization. Still four tests failing with CliDriver: - lateral_view.q - load_dyn_part15_test.q - multi_insert_lateral_view.q - ppd_field_garbage.q Diffs (updated) - accumulo-handler/src/test/results/positive/accumulo_queries.q.out 254eeaba4b8d633c63c706c0c74bb1165089 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 87f67d128e01117c5b950c2a3d25a662427b230d contrib/src/test/results/clientpositive/lateral_view_explode2.q.out 74a7e1719f8e026aaecd53fc147258620a75ccc4 hbase-handler/src/test/results/positive/hbase_queries.q.out b1e7936738b1121c14132909178646290ee8b4d5 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 ql/src/test/queries/clientpositive/identity_proj_remove.q PRE-CREATION ql/src/test/results/clientnegative/udf_assert_true.q.out 4a5b30de3b20e560b3f064d6a4e5ccab8539f85e ql/src/test/results/clientnegative/udf_assert_true2.q.out 3684a3f6c5c4d8f49c3cd2dd3fdfbcd85afda473 ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 718b43c6e0fc2c28981f8caf0f38c1360e69837d ql/src/test/results/clientpositive/auto_join0.q.out 9261ce02f3cfcfd9f048f15fe7357846bb386c31 ql/src/test/results/clientpositive/auto_join10.q.out 3d2bcc216dea80522002f149e5777a73ca52fe5b ql/src/test/results/clientpositive/auto_join11.q.out 8dbad6724475b71dc53d1198c77e36dfe752484e ql/src/test/results/clientpositive/auto_join12.q.out 037116c2c6994fe8bc7bccbb89950a13854cd9af ql/src/test/results/clientpositive/auto_join13.q.out 0cb9b4ffc460121584887f395eb1697bd53013c3 ql/src/test/results/clientpositive/auto_join16.q.out f96bae3590f5e26b059458650dd508b3dd4b1235 ql/src/test/results/clientpositive/auto_join18.q.out 0de3f2a2c8ca5646071fb852c838337b76aab9f9 ql/src/test/results/clientpositive/auto_join18_multi_distinct.q.out 46559a746f51fa3ad516629220bcf0f31bef685a ql/src/test/results/clientpositive/auto_join24.q.out 1fa3e6ea54f809c529d4ec7b50d5d5191284939f ql/src/test/results/clientpositive/auto_join26.q.out d494d95785283b7083820d0defaadb351f783085 ql/src/test/results/clientpositive/auto_join27.q.out c16992f2bed4de9dd23dcfbe004825f37abbe56e ql/src/test/results/clientpositive/auto_join30.q.out 608ca22323e3b4f1900dd5077a7aecf54d8a8ca2 ql/src/test/results/clientpositive/auto_join31.q.out b0df20270ba3dbb9115c529c50aaca5d13d57a95 ql/src/test/results/clientpositive/auto_join32.q.out bc2d56c0199133e84efd213dff1538173f1686c7 ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 2583d9a50d4a07db50dca7f88c6db141c392a3b8 ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 5a7f174a52d60028f524a7aac14a9b326d060af8 ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 7606dd2adcd43ca410e66e0c8f1799084fa4f39e ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 8372a6312a2fe85fd78f0c6da0665164b49b320c ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3c30a315d9028fda114def015e41a6171341153a ql/src/test/results/clientpositive/auto_sortmerge_join_14.q.out 69bd43af9a8210b19cbea17181f90bf707d93e85 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out 10b20d84eb06a30ed3655e346431bc52dfb486fe ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 72242bbd713baa216d41c40749f9c732271102cb ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 35fa02fa60f6c50d6acf55ed3fae1570a644c1e1 ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 4fea70d4e47bbd75530e92f5b2a8be2edd66bdbd ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 1904cc246729a8d3fd2cd1815e563b50e261da6a ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out e5e2a6a770d5064df944c69576d81d07b1d95c77 ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out abb1db4a87e6b8e820ff7df53d21a4036254b098 ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 9226dc6b2929c2b185f5904bd607a7b18e356dca ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 1a7fdf9650f3e5650400ecc24177637856701536 ql/src/test/results/clientpositive/bucket_map_join_1.q.out b194a2be3e39c0294df14c00fe69c6d6f9283702 ql/src/test/results/clientpositive/bucket_map_join_2.q.out 07c887854179e333e4c68d02c247216b1c06dee7 ql/src/test/results/clientpositive/bucketcontext_1.q.out
Re: Review Request 27699: HIVE-8435: Add identity project remover optimization
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27699/ --- (Updated Nov. 7, 2014, 12:36 a.m.) Review request for hive and Ashutosh Chauhan. Repository: hive-git Description --- Patch with the most conservative approach of project remover optimization. Still four tests failing with CliDriver: - lateral_view.q - load_dyn_part15_test.q - multi_insert_lateral_view.q - ppd_field_garbage.q Diffs - accumulo-handler/src/test/results/positive/accumulo_queries.q.out 254eeaba4b8d633c63c706c0c74bb1165089 common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 87f67d128e01117c5b950c2a3d25a662427b230d contrib/src/test/results/clientpositive/lateral_view_explode2.q.out 74a7e1719f8e026aaecd53fc147258620a75ccc4 hbase-handler/src/test/results/positive/hbase_queries.q.out b1e7936738b1121c14132909178646290ee8b4d5 ql/src/java/org/apache/hadoop/hive/ql/exec/SelectOperator.java 95d2d76c80aa59b62e9464f704523d921302d401 ql/src/java/org/apache/hadoop/hive/ql/optimizer/IdentityProjectRemover.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java 5be0e4540a6843c6b40cb5c22db6e90e1f0da922 ql/src/test/queries/clientpositive/identity_proj_remove.q PRE-CREATION ql/src/test/results/clientnegative/udf_assert_true.q.out 4a5b30de3b20e560b3f064d6a4e5ccab8539f85e ql/src/test/results/clientnegative/udf_assert_true2.q.out 3684a3f6c5c4d8f49c3cd2dd3fdfbcd85afda473 ql/src/test/results/clientpositive/annotate_stats_groupby.q.out 718b43c6e0fc2c28981f8caf0f38c1360e69837d ql/src/test/results/clientpositive/auto_join0.q.out 9261ce02f3cfcfd9f048f15fe7357846bb386c31 ql/src/test/results/clientpositive/auto_join10.q.out 3d2bcc216dea80522002f149e5777a73ca52fe5b ql/src/test/results/clientpositive/auto_join11.q.out 8dbad6724475b71dc53d1198c77e36dfe752484e ql/src/test/results/clientpositive/auto_join12.q.out 037116c2c6994fe8bc7bccbb89950a13854cd9af ql/src/test/results/clientpositive/auto_join13.q.out 0cb9b4ffc460121584887f395eb1697bd53013c3 ql/src/test/results/clientpositive/auto_join16.q.out f96bae3590f5e26b059458650dd508b3dd4b1235 ql/src/test/results/clientpositive/auto_join18.q.out 0de3f2a2c8ca5646071fb852c838337b76aab9f9 ql/src/test/results/clientpositive/auto_join18_multi_distinct.q.out 46559a746f51fa3ad516629220bcf0f31bef685a ql/src/test/results/clientpositive/auto_join24.q.out 1fa3e6ea54f809c529d4ec7b50d5d5191284939f ql/src/test/results/clientpositive/auto_join26.q.out d494d95785283b7083820d0defaadb351f783085 ql/src/test/results/clientpositive/auto_join27.q.out c16992f2bed4de9dd23dcfbe004825f37abbe56e ql/src/test/results/clientpositive/auto_join30.q.out 608ca22323e3b4f1900dd5077a7aecf54d8a8ca2 ql/src/test/results/clientpositive/auto_join31.q.out b0df20270ba3dbb9115c529c50aaca5d13d57a95 ql/src/test/results/clientpositive/auto_join32.q.out bc2d56c0199133e84efd213dff1538173f1686c7 ql/src/test/results/clientpositive/auto_smb_mapjoin_14.q.out 2583d9a50d4a07db50dca7f88c6db141c392a3b8 ql/src/test/results/clientpositive/auto_sortmerge_join_1.q.out 5a7f174a52d60028f524a7aac14a9b326d060af8 ql/src/test/results/clientpositive/auto_sortmerge_join_10.q.out 7606dd2adcd43ca410e66e0c8f1799084fa4f39e ql/src/test/results/clientpositive/auto_sortmerge_join_11.q.out 8372a6312a2fe85fd78f0c6da0665164b49b320c ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out 3c30a315d9028fda114def015e41a6171341153a ql/src/test/results/clientpositive/auto_sortmerge_join_14.q.out 69bd43af9a8210b19cbea17181f90bf707d93e85 ql/src/test/results/clientpositive/auto_sortmerge_join_15.q.out 10b20d84eb06a30ed3655e346431bc52dfb486fe ql/src/test/results/clientpositive/auto_sortmerge_join_2.q.out 72242bbd713baa216d41c40749f9c732271102cb ql/src/test/results/clientpositive/auto_sortmerge_join_3.q.out 35fa02fa60f6c50d6acf55ed3fae1570a644c1e1 ql/src/test/results/clientpositive/auto_sortmerge_join_4.q.out 4fea70d4e47bbd75530e92f5b2a8be2edd66bdbd ql/src/test/results/clientpositive/auto_sortmerge_join_5.q.out 1904cc246729a8d3fd2cd1815e563b50e261da6a ql/src/test/results/clientpositive/auto_sortmerge_join_6.q.out e5e2a6a770d5064df944c69576d81d07b1d95c77 ql/src/test/results/clientpositive/auto_sortmerge_join_7.q.out abb1db4a87e6b8e820ff7df53d21a4036254b098 ql/src/test/results/clientpositive/auto_sortmerge_join_8.q.out 9226dc6b2929c2b185f5904bd607a7b18e356dca ql/src/test/results/clientpositive/auto_sortmerge_join_9.q.out 1a7fdf9650f3e5650400ecc24177637856701536 ql/src/test/results/clientpositive/bucket_map_join_1.q.out b194a2be3e39c0294df14c00fe69c6d6f9283702 ql/src/test/results/clientpositive/bucket_map_join_2.q.out 07c887854179e333e4c68d02c247216b1c06dee7 ql/src/test/results/clientpositive/bucketcontext_1.q.out
