Re: Review Request 29625: HIVE-9200

2015-01-14 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/#review68166
---

Ship it!


Ship It!

- John Pullokkaran


On Jan. 14, 2015, 9:44 a.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29625/
 ---
 
 (Updated Jan. 14, 2015, 9:44 a.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9200
 https://issues.apache.org/jira/browse/HIVE-9200
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 CBO (Calcite Return Path): Inline Join, Properties
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
 2e771ec60851113ef9a717c87e142ca70bc53c07 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
 03742d436930526ff2db15d6ed159f4f0d7136f0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 eba35f583fd077f492811b6231dfd59e8b05ea58 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
 264d3f0b0ad80163831179b57aefdd4a4c5cc647 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
 7ab35eec5987c78dee0349431e06ee65a20ee2cd 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
 ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
 9238e0e541b748f5e45fe572e6b4575cc3299b7f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
 828f87c1f043324b0432bcc7c1f461267e19d0a6 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
 5291851b105730490033ff91e583ee44022ed24f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
 ea06503b0377ffb98f2583869e2c51ac1ea4e398 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
  11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
 8a0c47477718141cab85a4d6f71070117372df91 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
 bed95faa9bf072563262292931cc4b7d7cb034b3 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
  c52f7530b10c81a662118d2cb43599c82f7dbb4f 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
  33ef581a97768d6391c67558e768d10e46a366f2 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
  9c26907544ad8ced31d5cf47ed27c8a240f93925 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
  6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
  037983434d2ab5ce6c8f523b89370ca68cd98e27 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
  f62ad6cd109755f60e0e673a679c5107f91c43c0 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
  ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
  d00c48d8df3958a0a274aa30f2b999a98a6256c8 
   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
 cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
 da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
 c144d8c05c73025ba33b300229125e74930e 
   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
 9f8c0918179d9226e36cecc3bd955946d6b5fe98 
 
 Diff: https://reviews.apache.org/r/29625/diff/
 
 
 Testing
 ---
 
 Existing tests.
 
 
 Thanks,
 
 Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-14 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 14, 2015, 9:44 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

New patch addressing John's comments.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
2e771ec60851113ef9a717c87e142ca70bc53c07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
03742d436930526ff2db15d6ed159f4f0d7136f0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
eba35f583fd077f492811b6231dfd59e8b05ea58 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
264d3f0b0ad80163831179b57aefdd4a4c5cc647 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
828f87c1f043324b0432bcc7c1f461267e19d0a6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
bed95faa9bf072563262292931cc4b7d7cb034b3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 037983434d2ab5ce6c8f523b89370ca68cd98e27 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
 f62ad6cd109755f60e0e673a679c5107f91c43c0 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
 ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
 d00c48d8df3958a0a274aa30f2b999a98a6256c8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 13, 2015, 7:07 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
2e771ec60851113ef9a717c87e142ca70bc53c07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
03742d436930526ff2db15d6ed159f4f0d7136f0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
eba35f583fd077f492811b6231dfd59e8b05ea58 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
264d3f0b0ad80163831179b57aefdd4a4c5cc647 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
828f87c1f043324b0432bcc7c1f461267e19d0a6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
bed95faa9bf072563262292931cc4b7d7cb034b3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 037983434d2ab5ce6c8f523b89370ca68cd98e27 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
 f62ad6cd109755f60e0e673a679c5107f91c43c0 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
 ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
 d00c48d8df3958a0a274aa30f2b999a98a6256c8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 13, 2015, 9:05 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

Fix for patch after merging Spark branch.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
2e771ec60851113ef9a717c87e142ca70bc53c07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
03742d436930526ff2db15d6ed159f4f0d7136f0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
eba35f583fd077f492811b6231dfd59e8b05ea58 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
264d3f0b0ad80163831179b57aefdd4a4c5cc647 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
828f87c1f043324b0432bcc7c1f461267e19d0a6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
bed95faa9bf072563262292931cc4b7d7cb034b3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 037983434d2ab5ce6c8f523b89370ca68cd98e27 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
 f62ad6cd109755f60e0e673a679c5107f91c43c0 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
 ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
 d00c48d8df3958a0a274aa30f2b999a98a6256c8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/#review67975
---



ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
https://reviews.apache.org/r/29625/#comment112064

Could you change the variable name to something indicating qbJoinTree; 
otherwise its confusing while reading the code.


- John Pullokkaran


On Jan. 13, 2015, 7:07 p.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29625/
 ---
 
 (Updated Jan. 13, 2015, 7:07 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9200
 https://issues.apache.org/jira/browse/HIVE-9200
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 CBO (Calcite Return Path): Inline Join, Properties
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
 2e771ec60851113ef9a717c87e142ca70bc53c07 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
 03742d436930526ff2db15d6ed159f4f0d7136f0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 eba35f583fd077f492811b6231dfd59e8b05ea58 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
 264d3f0b0ad80163831179b57aefdd4a4c5cc647 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
 7ab35eec5987c78dee0349431e06ee65a20ee2cd 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
 ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
 9238e0e541b748f5e45fe572e6b4575cc3299b7f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
 828f87c1f043324b0432bcc7c1f461267e19d0a6 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
 5291851b105730490033ff91e583ee44022ed24f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
 ea06503b0377ffb98f2583869e2c51ac1ea4e398 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
  11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
 8a0c47477718141cab85a4d6f71070117372df91 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
 bed95faa9bf072563262292931cc4b7d7cb034b3 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
  c52f7530b10c81a662118d2cb43599c82f7dbb4f 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
  33ef581a97768d6391c67558e768d10e46a366f2 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
  9c26907544ad8ced31d5cf47ed27c8a240f93925 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
  6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
  037983434d2ab5ce6c8f523b89370ca68cd98e27 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
  f62ad6cd109755f60e0e673a679c5107f91c43c0 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
  ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
  d00c48d8df3958a0a274aa30f2b999a98a6256c8 
   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
 cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
 da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
 c144d8c05c73025ba33b300229125e74930e 
   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
 9f8c0918179d9226e36cecc3bd955946d6b5fe98 
 
 Diff: https://reviews.apache.org/r/29625/diff/
 
 
 Testing
 ---
 
 Existing tests.
 
 
 Thanks,
 
 Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-13 Thread John Pullokkaran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/#review67980
---



ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java
https://reviews.apache.org/r/29625/#comment112070

Could you change joinSrc to leftInputJoin or something similar? Also the 
get/set method names?
JoinSrc is rather confusing ( I know thats what they had originally).


- John Pullokkaran


On Jan. 13, 2015, 7:07 p.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29625/
 ---
 
 (Updated Jan. 13, 2015, 7:07 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9200
 https://issues.apache.org/jira/browse/HIVE-9200
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 CBO (Calcite Return Path): Inline Join, Properties
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
 2e771ec60851113ef9a717c87e142ca70bc53c07 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
 03742d436930526ff2db15d6ed159f4f0d7136f0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 eba35f583fd077f492811b6231dfd59e8b05ea58 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
 264d3f0b0ad80163831179b57aefdd4a4c5cc647 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
 7ab35eec5987c78dee0349431e06ee65a20ee2cd 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
 ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
 9238e0e541b748f5e45fe572e6b4575cc3299b7f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
 828f87c1f043324b0432bcc7c1f461267e19d0a6 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
 5291851b105730490033ff91e583ee44022ed24f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
 ea06503b0377ffb98f2583869e2c51ac1ea4e398 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
  11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
 8a0c47477718141cab85a4d6f71070117372df91 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
 bed95faa9bf072563262292931cc4b7d7cb034b3 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
  c52f7530b10c81a662118d2cb43599c82f7dbb4f 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
  33ef581a97768d6391c67558e768d10e46a366f2 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
  9c26907544ad8ced31d5cf47ed27c8a240f93925 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
  6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
  037983434d2ab5ce6c8f523b89370ca68cd98e27 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
  f62ad6cd109755f60e0e673a679c5107f91c43c0 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
  ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
  d00c48d8df3958a0a274aa30f2b999a98a6256c8 
   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
 cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
 da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
 c144d8c05c73025ba33b300229125e74930e 
   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
 9f8c0918179d9226e36cecc3bd955946d6b5fe98 
 
 Diff: https://reviews.apache.org/r/29625/diff/
 
 
 Testing
 ---
 
 Existing tests.
 
 
 Thanks,
 
 Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez 


 On Jan. 9, 2015, 5:49 p.m., Brock Noland wrote:
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java,
   line 80
  https://reviews.apache.org/r/29625/diff/2/?file=814267#file814267line80
 
  Please trim the trailing whitespace. It shows up in red.

Thanks Brock. Sorry about that, it is fixed.


- Jesús


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/#review67459
---


On Jan. 12, 2015, 11:32 a.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29625/
 ---
 
 (Updated Jan. 12, 2015, 11:32 a.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9200
 https://issues.apache.org/jira/browse/HIVE-9200
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 CBO (Calcite Return Path): Inline Join, Properties
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
 2e771ec60851113ef9a717c87e142ca70bc53c07 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
 03742d436930526ff2db15d6ed159f4f0d7136f0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 eba35f583fd077f492811b6231dfd59e8b05ea58 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
 264d3f0b0ad80163831179b57aefdd4a4c5cc647 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
 7ab35eec5987c78dee0349431e06ee65a20ee2cd 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
 ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
 9238e0e541b748f5e45fe572e6b4575cc3299b7f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
 828f87c1f043324b0432bcc7c1f461267e19d0a6 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
 5291851b105730490033ff91e583ee44022ed24f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
 ea06503b0377ffb98f2583869e2c51ac1ea4e398 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
  11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
 8a0c47477718141cab85a4d6f71070117372df91 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
  c52f7530b10c81a662118d2cb43599c82f7dbb4f 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
  33ef581a97768d6391c67558e768d10e46a366f2 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
  9c26907544ad8ced31d5cf47ed27c8a240f93925 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
  6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
 cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
 da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
 c144d8c05c73025ba33b300229125e74930e 
   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
 9f8c0918179d9226e36cecc3bd955946d6b5fe98 
 
 Diff: https://reviews.apache.org/r/29625/diff/
 
 
 Testing
 ---
 
 Existing tests.
 
 
 Thanks,
 
 Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 12, 2015, 2:51 p.m.)


Review request for hive and John Pullokkaran.


Changes
---

Rebased patch (optimizer.spark).


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
2e771ec60851113ef9a717c87e142ca70bc53c07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
03742d436930526ff2db15d6ed159f4f0d7136f0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
eba35f583fd077f492811b6231dfd59e8b05ea58 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
264d3f0b0ad80163831179b57aefdd4a4c5cc647 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
828f87c1f043324b0432bcc7c1f461267e19d0a6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SparkMapJoinProcessor.java 
bed95faa9bf072563262292931cc4b7d7cb034b3 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java
 037983434d2ab5ce6c8f523b89370ca68cd98e27 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSMBJoinHintOptimizer.java
 f62ad6cd109755f60e0e673a679c5107f91c43c0 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSkewJoinProcFactory.java
 ffe11a0f0d2ee8f63b124b13275aca8de4704d8b 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkSortMergeJoinOptimizer.java
 d00c48d8df3958a0a274aa30f2b999a98a6256c8 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-12 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 12, 2015, 11:32 a.m.)


Review request for hive and John Pullokkaran.


Changes
---

Rebased patch and fixing style.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
2e771ec60851113ef9a717c87e142ca70bc53c07 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
03742d436930526ff2db15d6ed159f4f0d7136f0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
eba35f583fd077f492811b6231dfd59e8b05ea58 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
264d3f0b0ad80163831179b57aefdd4a4c5cc647 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
ae0addcee51abf08904872ddf8dfb2c12e71a9e0 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
828f87c1f043324b0432bcc7c1f461267e19d0a6 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
cea86dfbf67b85cba24fb0e7ebf270abbe9c31f9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-09 Thread Brock Noland 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/#review67459
---



ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java
https://reviews.apache.org/r/29625/#comment111491

Please trim the trailing whitespace. It shows up in red.


- Brock Noland


On Jan. 9, 2015, 1:42 p.m., Jesús Camacho Rodríguez wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/29625/
 ---
 
 (Updated Jan. 9, 2015, 1:42 p.m.)
 
 
 Review request for hive and John Pullokkaran.
 
 
 Bugs: HIVE-9200
 https://issues.apache.org/jira/browse/HIVE-9200
 
 
 Repository: hive-git
 
 
 Description
 ---
 
 CBO (Calcite Return Path): Inline Join, Properties
 
 
 Diffs
 -
 
   ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
 ed03bb92bc2cc3c08cd7357ad4053dfd6aa739d3 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
 70c23a693bbb4d11808452bc24e67ffbb441b05e 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
 c9e808605da4218605a402fd0099469cdc20a289 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
 1260c831d86ae770cf7f9f0356932f9e0fdf7ba8 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
 7ab35eec5987c78dee0349431e06ee65a20ee2cd 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
 9a74e1e63e8d210f1d41909acf170f5279bd1d14 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
 9238e0e541b748f5e45fe572e6b4575cc3299b7f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
 ccb3ce54797abbb6d1f58d9d260194b67d7ec77f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
 5291851b105730490033ff91e583ee44022ed24f 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
 ea06503b0377ffb98f2583869e2c51ac1ea4e398 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
  11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
   ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
 8a0c47477718141cab85a4d6f71070117372df91 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
  c52f7530b10c81a662118d2cb43599c82f7dbb4f 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
  33ef581a97768d6391c67558e768d10e46a366f2 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
  9c26907544ad8ced31d5cf47ed27c8a240f93925 
   
 ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
  6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
   ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
 8215c26f48f1611d3c64f6df5bcfac02069e3a67 
   ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
 c2d5c8c448f784397e5f08ffb0f386726df3ff41 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
 da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
   ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
 23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
   ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
 c144d8c05c73025ba33b300229125e74930e 
   ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
 9f8c0918179d9226e36cecc3bd955946d6b5fe98 
 
 Diff: https://reviews.apache.org/r/29625/diff/
 
 
 Testing
 ---
 
 Existing tests.
 
 
 Thanks,
 
 Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-09 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 9, 2015, 11:56 a.m.)


Review request for hive.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description (updated)
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs (updated)
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
ed03bb92bc2cc3c08cd7357ad4053dfd6aa739d3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
70c23a693bbb4d11808452bc24e67ffbb441b05e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
c9e808605da4218605a402fd0099469cdc20a289 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
1260c831d86ae770cf7f9f0356932f9e0fdf7ba8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
9a74e1e63e8d210f1d41909acf170f5279bd1d14 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
ccb3ce54797abbb6d1f58d9d260194b67d7ec77f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
c2d5c8c448f784397e5f08ffb0f386726df3ff41 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing (updated)
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez

Re: Review Request 29625: HIVE-9200

2015-01-09 Thread Jesús Camacho Rodríguez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29625/
---

(Updated Jan. 9, 2015, 1:42 p.m.)


Review request for hive and John Pullokkaran.


Bugs: HIVE-9200
https://issues.apache.org/jira/browse/HIVE-9200


Repository: hive-git


Description
---

CBO (Calcite Return Path): Inline Join, Properties


Diffs
-

  ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 
ed03bb92bc2cc3c08cd7357ad4053dfd6aa739d3 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractBucketJoinProc.java 
70c23a693bbb4d11808452bc24e67ffbb441b05e 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/AbstractSMBJoinProc.java 
c9e808605da4218605a402fd0099469cdc20a289 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketMapjoinProc.java 
1260c831d86ae770cf7f9f0356932f9e0fdf7ba8 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java 
7ab35eec5987c78dee0349431e06ee65a20ee2cd 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 
9a74e1e63e8d210f1d41909acf170f5279bd1d14 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/JoinReorder.java 
9238e0e541b748f5e45fe572e6b4575cc3299b7f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java 
ccb3ce54797abbb6d1f58d9d260194b67d7ec77f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/NonBlockingOpDeDupProc.java 
5291851b105730490033ff91e583ee44022ed24f 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SkewJoinOptimizer.java 
ea06503b0377ffb98f2583869e2c51ac1ea4e398 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeBucketMapjoinProc.java
 11ce47eb4ff4b8ae1162eb5f3842b8e32d3a21e1 
  ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedMergeJoinProc.java 
8a0c47477718141cab85a4d6f71070117372df91 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/correlation/CorrelationOptimizer.java
 c52f7530b10c81a662118d2cb43599c82f7dbb4f 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/AbstractJoinTaskDispatcher.java
 33ef581a97768d6391c67558e768d10e46a366f2 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/CommonJoinTaskDispatcher.java
 9c26907544ad8ced31d5cf47ed27c8a240f93925 
  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/SortMergeJoinTaskDispatcher.java
 6f92b13ff7c1cdd4c651f5e1bff42626dee52750 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ParseContext.java 
8215c26f48f1611d3c64f6df5bcfac02069e3a67 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 
c2d5c8c448f784397e5f08ffb0f386726df3ff41 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TableAccessAnalyzer.java 
da14ab4e96bcc9089e10eb3a9d4e5d575b51d5ab 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TaskCompiler.java 
23fbbe11198ac5893a84bdf94f9c843c4ee2ccb4 
  ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java 
c144d8c05c73025ba33b300229125e74930e 
  ql/src/java/org/apache/hadoop/hive/ql/plan/MapWork.java 
9f8c0918179d9226e36cecc3bd955946d6b5fe98 

Diff: https://reviews.apache.org/r/29625/diff/


Testing
---

Existing tests.


Thanks,

Jesús Camacho Rodríguez