Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-30 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/ --- (Updated Sept. 30, 2016, 10:56 p.m.) Review request for hive, Mohit Sabharwal,

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-09 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148335 --- Ship it! LGTM (non binding) - Peter Vary On Sept. 7, 2016,

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
> On Sept. 7, 2016, 2:38 p.m., Peter Vary wrote: > > beeline/src/java/org/apache/hive/beeline/hs2connection/HS2ConnectionFileParser.java, > > line 88 > > > > > > I might prefer not to expose the file location on the

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/ --- (Updated Sept. 7, 2016, 6:22 p.m.) Review request for hive, Mohit Sabharwal,

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148007 --- Hi Vihang, Finally, I had time to read through the code. One

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-07 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review148013 --- Ship it! LGTM - Gabor Szadovszky On Sept. 6, 2016, 11:53

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
> On Sept. 2, 2016, 9:32 p.m., Gabor Szadovszky wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 932 > > > > > > Do we need this one to be public? Seems that is only used inside this > >

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
> On Sept. 2, 2016, 10:06 p.m., Peter Vary wrote: > > beeline/src/java/org/apache/hive/beeline/BeeLine.java, line 953 > > > > > > nit: missing space if ( fixed > On Sept. 2, 2016, 10:06 p.m., Peter Vary wrote: >

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-06 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/ --- (Updated Sept. 6, 2016, 11:53 p.m.) Review request for hive, Mohit Sabharwal,

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-02 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review147700 --- Thanks for the patch! This will be a really a usefull feature! I

Re: Review Request 51593: HIVE-14063 : Add beeline connection configuration file to automatically connect to HS2 using beeline

2016-09-02 Thread Gabor Szadovszky
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51593/#review147678 --- Thanks for the patch. Had some mostly minor findigs. Otherwise