Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-10-19 Thread Ke Jia 


> On Sept. 21, 2016, 9:33 a.m., Marta Kuczora wrote:
> > Thanks a lot for the patch. I had just some minor hints.

Thanks for you comment. I have fixed it.


- Ke


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/#review149801
---


On Oct. 20, 2016, 3:02 a.m., Ke Jia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52111/
> ---
> 
> (Updated Oct. 20, 2016, 3:02 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, when you run insert command on beeline, it returns a message 
> saying "No rows affected .."
> A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 9e5fd37 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
> 41887d7 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 71aea3a 
>   service-rpc/if/TCLIService.thrift a4fa7b0 
>   service/src/java/org/apache/hive/service/cli/CLIService.java 6d07d0c 
>   service/src/java/org/apache/hive/service/cli/OperationStatus.java b0a26e3 
>   service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
> 2938338 
> 
> Diff: https://reviews.apache.org/r/52111/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ke Jia
> 
>

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-10-19 Thread Ke Jia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/
---

(Updated Oct. 20, 2016, 3:02 a.m.)


Review request for hive and cheng xu.


Repository: hive-git


Description
---

Currently, when you run insert command on beeline, it returns a message saying 
"No rows affected .."
A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"


Diffs (updated)
-

  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 9e5fd37 
  ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
41887d7 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 71aea3a 
  service-rpc/if/TCLIService.thrift a4fa7b0 
  service/src/java/org/apache/hive/service/cli/CLIService.java 6d07d0c 
  service/src/java/org/apache/hive/service/cli/OperationStatus.java b0a26e3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
2938338 

Diff: https://reviews.apache.org/r/52111/diff/


Testing
---


Thanks,

Ke Jia

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Ke Jia 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/
---

(Updated Sept. 22, 2016, 1:53 a.m.)


Review request for hive and cheng xu.


Repository: hive-git


Description
---

Currently, when you run insert command on beeline, it returns a message saying 
"No rows affected .."
A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"


Diffs (updated)
-

  jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
  ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42d398d 
  ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
  ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
bb6ed84 
  ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 408c92e 
  service-rpc/if/TCLIService.thrift a4fa7b0 
  service/src/java/org/apache/hive/service/cli/CLIService.java 662e55c 
  service/src/java/org/apache/hive/service/cli/OperationStatus.java b0a26e3 
  service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java 
2938338 

Diff: https://reviews.apache.org/r/52111/diff/


Testing
---


Thanks,

Ke Jia

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Marta Kuczora 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/#review149801
---



Thanks a lot for the patch. I had just some minor hints.

- Marta Kuczora


On Sept. 21, 2016, 7:25 a.m., Ke Jia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52111/
> ---
> 
> (Updated Sept. 21, 2016, 7:25 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, when you run insert command on beeline, it returns a message 
> saying "No rows affected .."
> A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42d398d 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
> bb6ed84 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 408c92e 
>   service-rpc/if/TCLIService.thrift a4fa7b0 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TArrayTypeEntry.java
>  358e322 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBinaryColumn.java
>  a869cee 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolColumn.java
>  9bb6366 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolValue.java
>  87b3070 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteColumn.java
>  68b3d3c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteValue.java
>  a3d5951 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
>  6dba051 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIServiceConstants.java
>  930bed7 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenReq.java
>  a7d4e7d 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenResp.java
>  611e92c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationReq.java
>  4076c57 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationResp.java
>  7bcc765 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationReq.java
>  47a6b83 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationResp.java
>  0860a2b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionReq.java
>  43ee87f 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionResp.java
>  38f82ac 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumn.java
>  3c09c6b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
>  31472c8 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnValue.java
>  be99ce0 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleColumn.java
>  f93c9b4 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleValue.java
>  5700355 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  1f73cec 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java
>  7101fa5 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchOrientation.java
>  159be45 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchResultsReq.java
>  2c93339 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TFetchResultsResp.java
>  8f86cee 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCatalogsReq.java
>  b8a2ca6 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCatalogsResp.java
>  eeeac9a 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetColumnsReq.java
>  ba80279 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetColumnsResp.java
>  c68aac9 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TGetCrossReferenceReq.java
>  9729570 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread Marta Kuczora 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/#review149800
---




ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java (line 35)


The "numrows" variable should be private if there is no particular reason 
against it.



ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java (line 58)


Could you please format these methods to multiple lines?
Something like:

  public long getNumrows() {
return numrows;
  }

  public void setNumrows(long numrows) {
this.numrows = numrows;
  }



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java (line 
422)


Please add a space after "=".



ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java (line 1450)


Could you please format these methods to multiple lines?
Something like:

  public long getNumrows() {
return numrows;
  }

  public void setNumrows(long numrows) {
this.numrows = numrows;
  }



service/src/java/org/apache/hive/service/cli/OperationStatus.java (line 53)


Could you please format these methods to multiple lines?
Something like:

  public long getNumrows() {
return numrows;
  }

  public void setNumrows(long numrows) {
this.numrows = numrows;
  }


- Marta Kuczora


On Sept. 21, 2016, 7:25 a.m., Ke Jia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52111/
> ---
> 
> (Updated Sept. 21, 2016, 7:25 a.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, when you run insert command on beeline, it returns a message 
> saying "No rows affected .."
> A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42d398d 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
> bb6ed84 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 408c92e 
>   service-rpc/if/TCLIService.thrift a4fa7b0 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TArrayTypeEntry.java
>  358e322 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBinaryColumn.java
>  a869cee 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolColumn.java
>  9bb6366 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolValue.java
>  87b3070 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteColumn.java
>  68b3d3c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteValue.java
>  a3d5951 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
>  6dba051 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIServiceConstants.java
>  930bed7 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenReq.java
>  a7d4e7d 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenResp.java
>  611e92c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationReq.java
>  4076c57 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationResp.java
>  7bcc765 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationReq.java
>  47a6b83 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationResp.java
>  0860a2b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionReq.java
>  43ee87f 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionResp.java
>  38f82ac 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumn.java
>  3c09c6b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
>  31472c8 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnValue.java
>  be99ce0 
>   
> service-rpc/src/g

Re: Review Request 52111: HIVE-14388:Add number of rows inserted message after insert command in Beeline

2016-09-21 Thread cheng xu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52111/#review149796
---




ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1863)


Space needed around +



ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java (line 
379)


Remove it if no needed.



service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TArrayTypeEntry.java
 (line 2)


Can you use Thrift 0.9.3 version?



service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java (line 
43)


Please use previous import which doesn't import unneeded package.



service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java (line 
628)


Remove debug info.


For review, please don't include the generated files. :) I will review further 
it.

- cheng xu


On Sept. 21, 2016, 3:25 p.m., Ke Jia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52111/
> ---
> 
> (Updated Sept. 21, 2016, 3:25 p.m.)
> 
> 
> Review request for hive and cheng xu.
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Currently, when you run insert command on beeline, it returns a message 
> saying "No rows affected .."
> A better and more intuitive msg would be "xxx rows inserted (26.068 seconds)"
> 
> 
> Diffs
> -
> 
>   jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java a242501 
>   ql/src/java/org/apache/hadoop/hive/ql/Driver.java 42d398d 
>   ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java 4b60514 
>   ql/src/java/org/apache/hadoop/hive/ql/exec/mr/HadoopJobExecHelper.java 
> bb6ed84 
>   ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 408c92e 
>   service-rpc/if/TCLIService.thrift a4fa7b0 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TArrayTypeEntry.java
>  358e322 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBinaryColumn.java
>  a869cee 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolColumn.java
>  9bb6366 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TBoolValue.java
>  87b3070 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteColumn.java
>  68b3d3c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TByteValue.java
>  a3d5951 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIService.java
>  6dba051 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCLIServiceConstants.java
>  930bed7 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenReq.java
>  a7d4e7d 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelDelegationTokenResp.java
>  611e92c 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationReq.java
>  4076c57 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCancelOperationResp.java
>  7bcc765 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationReq.java
>  47a6b83 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseOperationResp.java
>  0860a2b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionReq.java
>  43ee87f 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TCloseSessionResp.java
>  38f82ac 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumn.java
>  3c09c6b 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnDesc.java
>  31472c8 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TColumnValue.java
>  be99ce0 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleColumn.java
>  f93c9b4 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TDoubleValue.java
>  5700355 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementReq.java
>  1f73cec 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TExecuteStatementResp.java
>  7101fa5 
>   
> service-rpc/src/gen/thrift/gen-javabean/org/apache/hive/service/rpc/thrift/TF