Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review152739 --- Ship it! Ship It! - Mohit Sabharwal On Oct. 14, 2016, 6:32 p

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

> On Oct. 13, 2016, 4:20 p.m., Mohit Sabharwal wrote: > > spark-client/src/main/java/org/apache/hive/spark/client/SparkClientImpl.java, > > line 495 > > > > > > static ? The method uses non-static field conf so can

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Oct. 14, 2016, 6:32 p.m.) Review request for hive, Mohit Sabharwal and

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review152521 --- Fix it, then Ship it! common/src/java/org/apache/hadoop/hive/c

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Oct. 12, 2016, 8:34 p.m.) Review request for hive, Mohit Sabharwal and

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

> On Oct. 6, 2016, 8:56 p.m., Mohit Sabharwal wrote: > > common/src/java/org/apache/hadoop/hive/common/EnvironmentUtils.java, line 25 > > > > > > Is this actually mocked anywhere in the tests ? I see the tests mock >

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Oct. 12, 2016, 5:44 p.m.) Review request for hive, Mohit Sabharwal and

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review151693 --- Thanks for the changes! Couple more questions. For readability, p

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

> On Oct. 5, 2016, 6:47 p.m., Mohit Sabharwal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/ExecDriver.java, line 422 > > > > > > Check if string is empty? I wanted to revert back the original value of th

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Oct. 5, 2016, 9:58 p.m.) Review request for hive, Mohit Sabharwal and

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review151382 --- Took a quick pass. Have some questions and suggestions. Will take

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Sept. 30, 2016, 6:58 p.m.) Review request for hive, Mohit Sabharwal an

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/#review150996 --- LGTM, only nits and a minor question. Thanks for the patch! comm

Re: Review Request 52283: HIVE-14822 : Add support for credential provider for jobs launched from Hiveserver2

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52283/ --- (Updated Sept. 30, 2016, 12:45 a.m.) Review request for hive, Mohit Sabharwal a