Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review170787 --- Ship it! Thanks for the changes. LGTM - Vihang Karajgaonkar

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 31, 2017, 9:16 p.m.) Review request for hive, Carl Steinbach

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-23 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 23, 2017, 4:27 p.m.) Review request for hive, Carl Steinbach

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 23, 2017, 12:45 a.m.) Review request for hive, Carl Steinbach

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review169810 ---

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > > Line 392 (original), 381 (patched) > > > > > > Does code does

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 4:31 p.m., Ratandeep Ratti wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java > > Lines 74 (patched) > > > > > > What all exception types are

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > Thanks for the changes Sunitha. Few comments below. Thanks for reviewing! Appreciate it. > On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 4:34 p.m., Ratandeep Ratti wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java > > Lines 83 (patched) > > > > > > Can some of the logic can be

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review169775 --- Thanks for the changes Sunitha. Few comments below.

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board
> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > > Line 433 (original), 382 (patched) > > > > > > Please consider

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Ratandeep Ratti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review169572 ---

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Ratandeep Ratti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review169570 ---

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 21, 2017, 4:05 p.m.) Review request for hive, Carl Steinbach

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review169533 ---

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 20, 2017, 3:44 p.m.) Review request for hive, Carl Steinbach

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/ --- (Updated March 20, 2017, 3:40 p.m.) Review request for hive, Carl Steinbach