Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Vihang Karajgaonkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review170787
---


Ship it!




Thanks for the changes. LGTM

- Vihang Karajgaonkar


On March 31, 2017, 9:16 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 31, 2017, 9:16 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Fix typo in deprecated conf declaration
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleReportersConf.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/7/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-31 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 31, 2017, 9:16 p.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description (updated)
---

HIVE-16206: Fix typo in deprecated conf declaration


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleReportersConf.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57632/diff/7/

Changes: https://reviews.apache.org/r/57632/diff/6-7/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-23 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 23, 2017, 4:27 p.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description (updated)
---

HIVE-16206: Minor fixes


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleReportersConf.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57632/diff/6/

Changes: https://reviews.apache.org/r/57632/diff/5-6/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 23, 2017, 12:45 a.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description (updated)
---

HIVE-16206: Addressed review comments and added new tests


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleReportersConf.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/57632/diff/5/

Changes: https://reviews.apache.org/r/57632/diff/4-5/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169810
---




common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
Lines 394 (patched)


Nit, please use the Hive coding conventions. We prefer using the curly 
braces. There is IDE formatter available in dev-support/ if you want to use 
that.


- Vihang Karajgaonkar


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar 


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
> > Line 392 (original), 381 (patched)
> > 
> >
> > Does code does not fallback to initMetricsReported() if 
> > initCodahaleMetricsReporterClasses() throws an exception?
> 
> Sunitha Beeram wrote:
> I would like to fall back to the deprecated config only if the new one is 
> not available - in which case the method returns false (not an exception). 
> But if it is present and we encounter issues with it, I would like to not 
> fall back at that time, ie, the intent is only backwards compatibility and 
> not to support multiple confs at the same time. Let me know if you think 
> otherwise.

I think thats fine. Just wanted to make sure if it was intentional.


- Vihang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169775
---


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board 


> On March 21, 2017, 4:31 p.m., Ratandeep Ratti wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
> > Lines 74 (patched)
> > 
> >
> > What all exception types are thrown here? Is it possible to act on some 
> > of these?

This is a comment on the older version of the file - I've broken down exception 
handling in the next revision. Let me know if you still have concerns.


- Sunitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169570
---


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board 


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > Thanks for the changes Sunitha. Few comments below.

Thanks for reviewing! Appreciate it.


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
> > Line 392 (original), 381 (patched)
> > 
> >
> > Does code does not fallback to initMetricsReported() if 
> > initCodahaleMetricsReporterClasses() throws an exception?

I would like to fall back to the deprecated config only if the new one is not 
available - in which case the method returns false (not an exception). But if 
it is present and we encounter issues with it, I would like to not fall back at 
that time, ie, the intent is only backwards compatibility and not to support 
multiple confs at the same time. Let me know if you think otherwise.


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
> > Lines 22 (patched)
> > 
> >
> > I think this can be renamed to something more generic like 
> > MetricsReporter.

Looks like I regressed in my updates, the original signature was 
interface CodahaleReporter extends Reporter, Closeable 

It was extending from a Codahale specific reporter (similar to 
ScheduledReporter) and I intended this to be used for pluggable codahale 
reporters as most things here are specific to Codahale. I plan to bring that 
signature back, unless there is a strong inclination for keeping it generic. (I 
currently don't have much driving the generic use-case).


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 2213 (patched)
> > 
> >
> > If you intent to deprecate this config use @deprecated instead. Also, 
> > instead of "- will be .. " it would be good if it says "This configuration 
> > will be ..."

Good point. Will do.


> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote:
> > common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
> > Line 62 (original), 63 (patched)
> > 
> >
> > Can you add additional testcases to verify that older config gets used 
> > when the newer one is not set?

Surely. I am currently working on adding it - the current test code sets up the 
reporters in the before method and entails some more work to cleanly test for 
backwards compatibility, so wanted to embark on it once the approach was agreed 
on. Will include it in my next update.


- Sunitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169775
---


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board 


> On March 21, 2017, 4:34 p.m., Ratandeep Ratti wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
> > Lines 83 (patched)
> > 
> >
> > Can some of the logic can be moved out of the run method?
> > 
> > 1. jsonMapper.writerWithDefaultPrettyPrettyPrinter can be cached 
> > outside of run.
> > 2. determining tmpPath
> > 3. determing right fs?

Fixed in latest commit.


- Sunitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169572
---


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Vihang Karajgaonkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169775
---



Thanks for the changes Sunitha. Few comments below.


common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
Line 392 (original), 381 (patched)


Does code does not fallback to initMetricsReported() if 
initCodahaleMetricsReporterClasses() throws an exception?



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
Lines 22 (patched)


I think this can be renamed to something more generic like MetricsReporter.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2207 (patched)


Nit, spell check -> separated instead of seperated.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2213 (patched)


If you intent to deprecate this config use @deprecated instead. Also, 
instead of "- will be .. " it would be good if it says "This configuration will 
be ..."



common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
Line 62 (original), 63 (patched)


Can you add additional testcases to verify that older config gets used when 
the newer one is not set?


- Vihang Karajgaonkar


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-22 Thread Sunitha Beeram via Review Board 


> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
> > Line 433 (original), 382 (patched)
> > 
> >
> > Please consider pushing this logic into the initReportingByClasses() 
> > and initReportyByEnum() methods, and changing the names of these methods to 
> > reference the names of the corresponding configuration properties.

Done. Let me know if the updated code comes close to what you had in mind.


> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
> > Line 480 (original), 434 (patched)
> > 
> >
> > If the reporterName is not recognized it would be good to either log an 
> > error/warning or throw an exception. The error message should reference the 
> > name of the configuration property that contains the unrecognized value.

Done - was relying on IllegalArgException to be thrown earlier; updated it to 
explictly handle it by logging the error and rethrowing.


> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
> > Lines 1 (patched)
> > 
> >
> > Missing ASF license header.

Thanks for catching this. Meant to update it in all the files :(


> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote:
> > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
> > Lines 30 (patched)
> > 
> >
> > Is there a reason why you didn't import java.util.Timer?

I moved this code from CodahaleMetrics class and did not focus on the specific 
logic earlier. I have cleaned up the code a bit now - and moved away from using 
a Timer as well -  using executor service instead.


> On March 21, 2017, 6:25 a.m., Carl Steinbach wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Line 2211 (original), 2216 (patched)
> > 
> >
> > Default value is 5s, but TimeValidator is in milliseconds. Mistake?

Good catch! It looks like TimeValidator wasn't actually checking much as no 
min/max values were not specified. In any case its inconsistent and I've 
updated the default value to reflect the right metrics.


- Sunitha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169533
---


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169572
---




common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Lines 83 (patched)


Can some of the logic can be moved out of the run method?

1. jsonMapper.writerWithDefaultPrettyPrettyPrinter can be cached outside of 
run.
2. determining tmpPath
3. determing right fs?


- Ratandeep Ratti


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Ratandeep Ratti 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169570
---




common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Lines 74 (patched)


What all exception types are thrown here? Is it possible to act on some of 
these?


- Ratandeep Ratti


On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 21, 2017, 4:05 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/4/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 21, 2017, 4:05 p.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description
---

HIVE-16206: Address review comments


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 


Diff: https://reviews.apache.org/r/57632/diff/4/

Changes: https://reviews.apache.org/r/57632/diff/3-4/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-21 Thread Carl Steinbach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/#review169533
---




common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
Line 433 (original), 382 (patched)


Please consider pushing this logic into the initReportingByClasses() and 
initReportyByEnum() methods, and changing the names of these methods to 
reference the names of the corresponding configuration properties.



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
Line 450 (original), 401 (patched)


Error message should reference the name of the configuration property that 
contains the bad value.



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
Line 480 (original), 434 (patched)


If the reporterName is not recognized it would be good to either log an 
error/warning or throw an exception. The error message should reference the 
name of the configuration property that contains the unrecognized value.



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Lines 1 (patched)


Missing ASF license header.



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Lines 30 (patched)


Is there a reason why you didn't import java.util.Timer?



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
Lines 74 (patched)


Include the file name in the log message. Also, should this be logged at 
the error level?



common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
Lines 1 (patched)


Missing ASF license header.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Line 2204 (original), 2204 (patched)


The config property descriptions should explain what happens when both 
HIVE_CODAHALE_METRICS_REPORTER_CLASSES and HIVE_METRICS_REPORTER are set.



common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Line 2211 (original), 2216 (patched)


Default value is 5s, but TimeValidator is in milliseconds. Mistake?



common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
Line 62 (original), 63 (patched)


Add a linebreak.


- Carl Steinbach


On March 20, 2017, 3:44 p.m., Sunitha Beeram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57632/
> ---
> 
> (Updated March 20, 2017, 3:44 p.m.)
> 
> 
> Review request for hive, Carl Steinbach and Ratandeep Ratti.
> 
> 
> Bugs: Hive-16206
> https://issues.apache.org/jira/browse/Hive-16206
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-16206: Address review comments
> 
> 
> Diffs
> -
> 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
>  e8abf6cf06afc9fa590af3a447eacc67735a69e6 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
>  PRE-CREATION 
>   
> common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
>  PRE-CREATION 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
> 1fb32533d58af4ec622feb320bf9315da5db6e76 
>   
> common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
>  aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 
> 
> 
> Diff: https://reviews.apache.org/r/57632/diff/3/
> 
> 
> Testing
> ---
> 
> Updated unit tests and all unit tests passed locally.
> 
> 
> Thanks,
> 
> Sunitha Beeram
> 
>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 20, 2017, 3:44 p.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description
---

HIVE-16206: Address review comments


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 


Diff: https://reviews.apache.org/r/57632/diff/3/

Changes: https://reviews.apache.org/r/57632/diff/2-3/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

2017-03-20 Thread Sunitha Beeram via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57632/
---

(Updated March 20, 2017, 3:40 p.m.)


Review request for hive, Carl Steinbach and Ratandeep Ratti.


Summary (updated)
-

HIVE-16206: Provide wrapper classes for current metrics reporters to allow 
uniform instantiation through reflection


Bugs: Hive-16206
https://issues.apache.org/jira/browse/Hive-16206


Repository: hive-git


Description (updated)
---

HIVE-16206: Address review comments


Diffs (updated)
-

  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java
 e8abf6cf06afc9fa590af3a447eacc67735a69e6 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/ConsoleMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JmxMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/JsonFileMetricsReporter.java
 PRE-CREATION 
  
common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/Metrics2Reporter.java
 PRE-CREATION 
  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
1fb32533d58af4ec622feb320bf9315da5db6e76 
  
common/src/test/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java
 aa4e75f9f8160d1b54b14c1a23ea42e156bd45ca 


Diff: https://reviews.apache.org/r/57632/diff/2/

Changes: https://reviews.apache.org/r/57632/diff/1-2/


Testing
---

Updated unit tests and all unit tests passed locally.


Thanks,

Sunitha Beeram