---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172704
---
Ship it!
Ship It!
- Alexander Kolbasov
On April 21, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/
---
(Updated April 21, 2017, 5:55 p.m.)
Review request for hive, Alexander
> On April 21, 2017, 6:19 a.m., Alexander Kolbasov wrote:
> > The name is not very good rollbackIfNotSuccessful since this thing also
> > closes query, but rollbackaIfNotSuccessfulButCloseQueryAnyway isn't much
> > better :-).
> > May be just cleanup()?
I agree with the name not being great.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172590
---
Ship it!
The name is not very good rollbackIfNotSuccessful
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/
---
(Updated April 20, 2017, 10:01 p.m.)
Review request for hive, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172556
---
Ship it!
It looks good.
- Sergio Pena
On April 18, 2017,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58516/#review172268
---
Ship it!
LGTM. It would be nice to add a unit test to one of
