Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59984/ --- (Updated June 27, 2017, 11:12 p.m.) Review request for hive and Ashutosh

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Vineet Garg
> On June 27, 2017, 9:24 p.m., Ashutosh Chauhan wrote: > > ql/src/test/results/clientpositive/llap/subquery_in.q.out > > Lines 5531-5540 (patched) > > > > > > Change in resultset. Either earlier results were

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59984/#review179054 ---

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-27 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59984/#review179052 --- ql/src/test/results/clientpositive/llap/subquery_in.q.out Lines

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-26 Thread Vineet Garg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59984/ --- (Updated June 26, 2017, 8:41 p.m.) Review request for hive and Ashutosh

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Ashutosh Chauhan
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > > > > > Seems like this if branch

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Vineet Garg
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > > > > > Seems like this if branch

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Ashutosh Chauhan
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > > > > > Seems like this if branch

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-21 Thread Vineet Garg
> On June 20, 2017, 12:17 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveAggregate.java > > Lines 137-139 (patched) > > > > > > Seems like this if branch

Re: Review Request 59984: Improve plans for subqueries with non-equi co-related predicates

2017-06-19 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59984/#review178248 ---