Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- (Updated March 6, 2018, 8:44 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review198675 ---

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-05 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- (Updated March 6, 2018, 1:57 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-05 Thread Sergey Shelukhin
> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/stats/BasicStatsTask.java > > Line 157 (original), 162 (patched) > > > > > > I feel that currently the stats system is

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-02 Thread Sergey Shelukhin
> On March 1, 2018, 12:40 a.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > > Lines 1683 (patched) > > > > > > For full acid table, if you have no ParseDelta.isDeleteDelta(),

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-03-02 Thread Sergey Shelukhin
> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 1947 (patched) > > > > > > I think this should be in somewhere in the BasicStat related

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-28 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review198419 --- ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java Line

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-26 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- (Updated Feb. 27, 2018, 3:14 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-23 Thread Sergey Shelukhin
> On Feb. 2, 2018, 10 a.m., Zoltan Haindrich wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreUtils.java > > Lines 650 (patched) > > > > > > I might be missing something

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-23 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- (Updated Feb. 24, 2018, 2:09 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-02-02 Thread Zoltan Haindrich
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196696 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-01-30 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/ --- (Updated Jan. 31, 2018, 2:15 a.m.) Review request for hive and Eugene Koifman.

Re: Review Request 65415: HIVE-18571 stats issues for MM tables

2018-01-29 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65415/#review196500 ---