Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-19 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review199444 --- Ship it! +1, let's get this in. We can open new tickets for

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-09 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/ --- (Updated March 9, 2018, 9 p.m.) Review request for hive, Daniel Dai and Thejas

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-09 Thread Vaibhav Gumashta
> On March 2, 2018, 7:54 a.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CacheUtils.java > > Lines 63 (patched) > > > > > > It would be cleaner and easier

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-01 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198507 --- Changes are pretty big, I didn't go through all of them 0 some

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-01 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198471 --- Ship it! Ship It! - Daniel Dai On March 1, 2018, 11:09

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-03-01 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/ --- (Updated March 1, 2018, 11:09 a.m.) Review request for hive, Daniel Dai and

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-27 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198377 --- Fix it, then Ship it! Ship It!

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-27 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198378 --- Ship it! Ship It! - Daniel Dai On Feb. 26, 2018, 9:47 p.m.,

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-26 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/ --- (Updated Feb. 26, 2018, 9:47 p.m.) Review request for hive, Daniel Dai and

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-23 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198206 --- Ship it! Ship It! - Daniel Dai On Feb. 23, 2018, 8:14 p.m.,

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-23 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/ --- (Updated Feb. 23, 2018, 8:14 p.m.) Review request for hive, Daniel Dai and

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-23 Thread Vaibhav Gumashta
> On Feb. 21, 2018, 10:07 p.m., Daniel Dai wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/cache/CachedStore.java > > Line 311 (original), 215 (patched) > > > > > > This is not

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-22 Thread Thejas Nair
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review198082 ---

Re: Review Request 65634: HIVE-18264: CachedStore: Store cached partitions/col stats within the table cache

2018-02-21 Thread Daniel Dai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65634/#review197794 ---