Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-03-06 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198704 --- Ship it! Ship It! - Peter Vary On Feb. 21, 2018, 11:37

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-03-06 Thread Marta Kuczora via Review Board
> On Feb. 22, 2018, 10:35 a.m., Adam Szita wrote: > > Ship It! Thanks a lot Adam for the review! - Marta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198106

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-03-06 Thread Marta Kuczora via Review Board
> On Feb. 21, 2018, 1:37 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 3370 (patched) > > > > > > How "expensive" is this call? Is this

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review198106 --- Ship it! Ship It! - Adam Szita On Feb. 21, 2018, 11:37

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-22 Thread Adam Szita via Review Board
> On Feb. 21, 2018, 1:37 p.m., Peter Vary wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 3370 (patched) > > > > > > How "expensive" is this call? Is this

Re: Review Request 65731: HIVE-18699: Check for duplicate partitions in HiveMetastore.exchange_partitions

2018-02-21 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65731/#review197848 --- Thanks Marta! Just a quick querstion.