Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/#review198143 --- Ship it! Ship It! - Sahil Takiar On Feb. 22, 2018, 7:02

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

> On Feb. 22, 2018, 4:45 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/MetaStoreClientTest.java > > Lines 60 (patched) > > > > > > can this be `private` > >

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 7:02 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/ --- (Updated Feb. 22, 2018, 6:49 p.m.) Review request for hive, Marta Kuczora,

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

> On Feb. 22, 2018, 4:45 p.m., Sahil Takiar wrote: > > so just to clarify, the creation of metastore instances is moving from the > > individual contructors to a `BeforeClass` method? Thanks for the review! Yes! This is the main change in the patch - run start the metastore instances once per

Re: Review Request 65753: HIVE-18771 Refactor tests, so only 1 MetaStore instance will be started per test class and test configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65753/#review198121 --- so just to clarify, the creation of metastore instances is moving