Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Vihang Karajgaonkar via Review Board
> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/ --- (Updated April 4, 2018, 4:06 p.m.) Review request for hive, Alexander

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-04 Thread Sergio Pena via Review Board
> On April 4, 2018, 12:34 a.m., Vihang Karajgaonkar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 408 (patched) > > > > > > why do we need !success

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-04-03 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review200405 --- Fix it, then Ship it! LGTM. Just one minor comment below.

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/ --- (Updated March 15, 2018, 5:45 p.m.) Review request for hive, Alexander

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
> On March 12, 2018, 4:45 p.m., Na Li wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 372 (patched) > > > > > > why when db name is changed at alter

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-15 Thread Sergio Pena via Review Board
> On March 13, 2018, 3:35 a.m., Alexander Kolbasov wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > > Lines 362 (patched) > > > > > > Would it make sense to move

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-12 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review199063 ---

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

2018-03-12 Thread Na Li via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review199027 ---