Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-24 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 25, 2018, 12:43 a.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-24 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201849 --- Ship it! Ship It! - Gopal V On April 23, 2018, 7:03 p.m.,

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-23 Thread Sergey Shelukhin
> On April 23, 2018, 7:24 p.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 356 (patched) > > > > > > Is that supposed to be a "," or a +? , - Sergey

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-23 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201756 ---

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-23 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 23, 2018, 7:03 p.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-23 Thread Sergey Shelukhin
> On April 23, 2018, 5:04 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 353 (patched) > > > > > > Add a timestamp to the tmp-table and fail-retry if it

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-22 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201717 ---

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-20 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 20, 2018, 11:15 p.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-19 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 20, 2018, 1:42 a.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-19 Thread Sergey Shelukhin
> On April 19, 2018, 10:48 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java > > Lines 1324 (patched) > > > > > > why not use TxnUtils.createValidCompactWriteIdList() and > >

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-19 Thread Eugene Koifman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201574 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java Lines 1324

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 18, 2018, 1:46 a.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201371 ---

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-17 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 18, 2018, 1:37 a.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-17 Thread Sergey Shelukhin
> On April 17, 2018, 4:44 a.m., Gopal V wrote: > > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > > Lines 1119 (patched) > > > > > > add comment about this (As the "file that adds this

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-16 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review201290 ---

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-16 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 16, 2018, 10:35 p.m.) Review request for hive and Eugene

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-06 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/ --- (Updated April 6, 2018, 9:31 p.m.) Review request for hive and Eugene Koifman.

Re: Review Request 66485: HIVE-19124 implement a basic major compactor for MM tables

2018-04-05 Thread Gopal V
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66485/#review200626 ---