Re: Review Request 69078: HIVE-20767

2018-10-19 Thread Jesús Camacho Rodríguez

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/
---

(Updated Oct. 19, 2018, 4:12 p.m.)


Review request for hive, Ashutosh Chauhan and Vineet Garg.


Summary (updated)
-

HIVE-20767


Bugs: HIVE-20767
https://issues.apache.org/jira/browse/HIVE-20767


Repository: hive-git


Description (updated)
---

HIVE-20767


Diffs (updated)
-

  
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java
 e6844326068210e7ab7364ec9f3ec60908b36e88 
  ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
22f3266c87f1d42c254893b424b68e757fb2953b 
  ql/src/test/results/clientpositive/llap/lineage2.q.out 
d32f490a704e1ba6bdc54f4d54dff028c9ca974c 
  ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 
6f00a5c82b2c2784d2576222d6eb4bd9faf71bea 
  ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out 
ae821f600b3e9bf3128e93c0a4097b438f26f35b 
  ql/src/test/results/clientpositive/perf/spark/query54.q.out 
f10250f307cc58486dbb202c95b2c8af7943e528 
  ql/src/test/results/clientpositive/perf/tez/query54.q.out 
1c17d2a53a1be39b28d01412fe6b13878b1680f3 


Diff: https://reviews.apache.org/r/69078/diff/3/

Changes: https://reviews.apache.org/r/69078/diff/2-3/


Testing
---


Thanks,

Jesús Camacho Rodríguez



Re: Review Request 69078: HIVE-20767

2018-10-19 Thread Ashutosh Chauhan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69078/#review209775
---




ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out
Lines 469-470 (original), 470-472 (patched)


This plan looks slower than previous with extra shuffle.



ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
Lines 240-241 (original), 242-244 (patched)


This plan looks slower than previous with extra shuffle.



ql/src/test/results/clientpositive/llap/subquery_scalar.q.out
Line 1005 (original), 1038 (patched)


This plan looks slower than previous with extra shuffle.



ql/src/test/results/clientpositive/llap/subquery_select.q.out
Lines 4905-4907 (original), 4905-4907 (patched)


This plan looks slower than previous with extra shuffle.


- Ashutosh Chauhan


On Oct. 19, 2018, 12:18 a.m., Jesús Camacho Rodríguez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69078/
> ---
> 
> (Updated Oct. 19, 2018, 12:18 a.m.)
> 
> 
> Review request for hive, Ashutosh Chauhan and Vineet Garg.
> 
> 
> Bugs: HIVE-20767
> https://issues.apache.org/jira/browse/HIVE-20767
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> HIVE-20767
> 
> 
> Diffs
> -
> 
>   
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveJoinProjectTransposeRule.java
>  e6844326068210e7ab7364ec9f3ec60908b36e88 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 
> 22f3266c87f1d42c254893b424b68e757fb2953b 
>   ql/src/test/results/clientnegative/subquery_scalar_multi_rows.q.out 
> 0a780db7ef98ddf14fc18a90f2b628a13337bcda 
>   ql/src/test/results/clientpositive/bool_unknown.q.out 
> 8e9b48ccafce2093e91d7035fdf581018bab1979 
>   ql/src/test/results/clientpositive/llap/lineage2.q.out 
> d32f490a704e1ba6bdc54f4d54dff028c9ca974c 
>   ql/src/test/results/clientpositive/llap/mapjoin_hint.q.out 
> ac505a5c1e47211260a795390a3ca7c45ee30c01 
>   ql/src/test/results/clientpositive/llap/materialized_view_rewrite_7.q.out 
> 6f00a5c82b2c2784d2576222d6eb4bd9faf71bea 
>   ql/src/test/results/clientpositive/llap/multiMapJoin1.q.out 
> ae821f600b3e9bf3128e93c0a4097b438f26f35b 
>   ql/src/test/results/clientpositive/llap/subquery_scalar.q.out 
> 166bd60ce25712021c06d3506246ff87d35058c4 
>   ql/src/test/results/clientpositive/llap/subquery_select.q.out 
> 854d215a2382e5b09714c7b8b9916cf048458f66 
>   ql/src/test/results/clientpositive/perf/spark/query54.q.out 
> f10250f307cc58486dbb202c95b2c8af7943e528 
>   ql/src/test/results/clientpositive/perf/tez/query54.q.out 
> 1c17d2a53a1be39b28d01412fe6b13878b1680f3 
>   ql/src/test/results/clientpositive/spark/subquery_scalar.q.out 
> b3252f54158d5401c3d10b0978af69b9dbba1290 
>   ql/src/test/results/clientpositive/spark/subquery_select.q.out 
> ad7c8a3fc795004ea5dbd2bc4355de24b73352be 
> 
> 
> Diff: https://reviews.apache.org/r/69078/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jesús Camacho Rodríguez
> 
>