Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

> On Nov. 7, 2018, 2:09 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/test/queries/clientpositive/constraints_optimization.q > > Lines 355 (patched) > > > > > > Can we add two more tests: > > - One with column

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210391 --- Ship it! Ship It! - Jesús Camacho Rodríguez On Nov. 7,

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/ --- (Updated Nov. 7, 2018, 7:39 p.m.) Review request for hive and Jesús Camacho

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

> On Nov. 7, 2018, 2:09 a.m., Jesús Camacho Rodríguez wrote: > > ql/src/test/queries/clientpositive/constraints_optimization.q > > Lines 355 (patched) > > > > > > Can we add two more tests: > > - One with column

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210362 ---

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/ --- (Updated Nov. 7, 2018, 1:49 a.m.) Review request for hive and Jesús Camacho

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210359 ---

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/ --- (Updated Nov. 7, 2018, midnight) Review request for hive and Jesús Camacho

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

> On Nov. 1, 2018, 8:33 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRelOptUtil.java > > Lines 774 (patched) > > > > > > Cardinality and NDV may change. This

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/ --- (Updated Nov. 5, 2018, 10:57 p.m.) Review request for hive and Jesús Camacho

Re: Review Request 69202: HIVE-20804 Further improvements to group by optimization with constraints

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69202/#review210258 ---