Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-21 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/ --- (Updated Nov. 22, 2018, 4:32 a.m.) Review request for hive, Gopal V and Teddy

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-21 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/ --- (Updated Nov. 21, 2018, 9:41 p.m.) Review request for hive, Gopal V and Teddy

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-21 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/ --- (Updated Nov. 21, 2018, 3:28 p.m.) Review request for hive, Gopal V and Teddy

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-20 Thread Slim Bouguerra
> On Nov. 20, 2018, 7:57 a.m., Nishant Bangarwa wrote: > > checkstyle/checkstyle.xml > > Lines 166 (patched) > > > > > > please break down this into 2 separate patches. > > The main benefits of separating this

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-20 Thread Slim Bouguerra
> On Nov. 20, 2018, 7:54 a.m., Nishant Bangarwa wrote: > > data/files/datasets/druid_table_alltypesorc/load.hive.sql > > Line 36 (original) > > > > > > why not dropping this table ? it is dropped later, this will

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-19 Thread Nishant Bangarwa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/#review210700 --- please break down this into 2 separate patches. The main benefits

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-19 Thread Nishant Bangarwa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/#review210701 --- checkstyle/checkstyle.xml Lines 166 (patched)

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-19 Thread Nishant Bangarwa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/#review210699 --- data/files/datasets/druid_table_alltypesorc/load.hive.sql Line

Re: Review Request 69404: HIVE-20932 adding vectorize wrapper for Druid Storage Handler.

2018-11-19 Thread Slim Bouguerra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69404/ --- (Updated Nov. 20, 2018, 2:08 a.m.) Review request for hive, Gopal V and Teddy