Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-12 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 12, 2018, 3:31 p.m.) Review request for hive, Peter Vary and

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board
> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > > Lines 217 (patched) > > > > > > Do we need to do redact for the Spark config as well? >

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/#review211205 --- Ship it! Ship It! - Vihang Karajgaonkar On Dec. 11, 2018,

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board
> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java > > Lines 217 (patched) > > > > > > Do we need to do redact for the Spark config as well?

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/#review211199 --- common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69550/ --- (Updated Dec. 11, 2018, 12:43 p.m.) Review request for hive, Peter Vary and