Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-12 Thread Denys Kuzmenko via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/
---

(Updated Dec. 12, 2018, 3:31 p.m.)


Review request for hive, Peter Vary and Vihang Karajgaonkar.


Changes
---

added tests


Bugs: HIVE-21030
https://issues.apache.org/jira/browse/HIVE-21030


Repository: hive-git


Description
---

Credstore decryption password should be redacted in JobConf


Diffs (updated)
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
2ad5f9ee39f376d3466994a24cc9f7850be902ae 
  ql/src/test/org/apache/hadoop/hive/ql/exec/TestHiveCredentialProviders.java 
62eb9e4c3c14cfc233f5184d58171e298e25bd9a 


Diff: https://reviews.apache.org/r/69550/diff/2/

Changes: https://reviews.apache.org/r/69550/diff/1-2/


Testing
---


Thanks,

Denys Kuzmenko

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board 


> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
> > Lines 217 (patched)
> > 
> >
> > Do we need to do redact for the Spark config as well?
> 
> Denys Kuzmenko wrote:
> no, it's already handled in Spark:
> 
> https://github.com/apache/spark/commit/66636ef0b046e5d1f340c3b8153d7213fa9d19c7

Okay. Thanks for checking.


- Vihang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/#review211199
---


On Dec. 11, 2018, 12:43 p.m., Denys Kuzmenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69550/
> ---
> 
> (Updated Dec. 11, 2018, 12:43 p.m.)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21030
> https://issues.apache.org/jira/browse/HIVE-21030
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Credstore decryption password should be redacted in JobConf
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
> 2ad5f9ee39f376d3466994a24cc9f7850be902ae 
> 
> 
> Diff: https://reviews.apache.org/r/69550/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denys Kuzmenko
> 
>

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/#review211205
---


Ship it!




Ship It!

- Vihang Karajgaonkar


On Dec. 11, 2018, 12:43 p.m., Denys Kuzmenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69550/
> ---
> 
> (Updated Dec. 11, 2018, 12:43 p.m.)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21030
> https://issues.apache.org/jira/browse/HIVE-21030
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Credstore decryption password should be redacted in JobConf
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
> 2ad5f9ee39f376d3466994a24cc9f7850be902ae 
> 
> 
> Diff: https://reviews.apache.org/r/69550/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denys Kuzmenko
> 
>

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board 


> On Dec. 11, 2018, 4:30 p.m., Vihang Karajgaonkar wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
> > Lines 217 (patched)
> > 
> >
> > Do we need to do redact for the Spark config as well?

no, it's already handled in Spark:
https://github.com/apache/spark/commit/66636ef0b046e5d1f340c3b8153d7213fa9d19c7


- Denys


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/#review211199
---


On Dec. 11, 2018, 12:43 p.m., Denys Kuzmenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69550/
> ---
> 
> (Updated Dec. 11, 2018, 12:43 p.m.)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21030
> https://issues.apache.org/jira/browse/HIVE-21030
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Credstore decryption password should be redacted in JobConf
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
> 2ad5f9ee39f376d3466994a24cc9f7850be902ae 
> 
> 
> Diff: https://reviews.apache.org/r/69550/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denys Kuzmenko
> 
>

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Vihang Karajgaonkar via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/#review211199
---




common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java
Lines 217 (patched)


Do we need to do redact for the Spark config as well?


- Vihang Karajgaonkar


On Dec. 11, 2018, 12:43 p.m., Denys Kuzmenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69550/
> ---
> 
> (Updated Dec. 11, 2018, 12:43 p.m.)
> 
> 
> Review request for hive, Peter Vary and Vihang Karajgaonkar.
> 
> 
> Bugs: HIVE-21030
> https://issues.apache.org/jira/browse/HIVE-21030
> 
> 
> Repository: hive-git
> 
> 
> Description
> ---
> 
> Credstore decryption password should be redacted in JobConf
> 
> 
> Diffs
> -
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
> 2ad5f9ee39f376d3466994a24cc9f7850be902ae 
> 
> 
> Diff: https://reviews.apache.org/r/69550/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Denys Kuzmenko
> 
>

Re: Review Request 69550: Add credential store env properties redaction in JobConf

2018-12-11 Thread Denys Kuzmenko via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69550/
---

(Updated Dec. 11, 2018, 12:43 p.m.)


Review request for hive, Peter Vary and Vihang Karajgaonkar.


Bugs: HIVE-21030
https://issues.apache.org/jira/browse/HIVE-21030


Repository: hive-git


Description
---

Credstore decryption password should be redacted in JobConf


Diffs
-

  common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 
2ad5f9ee39f376d3466994a24cc9f7850be902ae 


Diff: https://reviews.apache.org/r/69550/diff/1/


Testing
---


Thanks,

Denys Kuzmenko