Re: Review Request 61497: HIVE-17267: Make HMS Notification Listeners typesafe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61497/ --- (Updated Aug. 8, 2017, 3:47 p.m.) Review request for hive and Peter Vary. Changes --- Addressed comments. Thank you for the review Peter! Bugs: HIVE-17267 https://issues.apache.org/jira/browse/HIVE-17267 Repository: hive-git Description --- HIVE-17267: Make HMS Notification Listeners typesafe Diffs (updated) - hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 351546c3bc9edb69a435f04795b5ea6c3421f5b0 metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ea90a8e4a2d8a79f4356818b11cdbf9eb870256d metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java e2a7d7df3fc072ca7eb7addb1fff4378d592df77 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java 37327f8bd2ebf3f883fb3bd408d63f776b26406e metastore/src/java/org/apache/hadoop/hive/metastore/TransactionalMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/61497/diff/2/ Changes: https://reviews.apache.org/r/61497/diff/1-2/ Testing --- Thanks, Barna Zsombor Klara
Re: Review Request 61497: HIVE-17267: Make HMS Notification Listeners typesafe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61497/#review182394 --- Thanks for the patch Zsombor! It would be nice, if a listener is not transactional and the notification event throws an exception then we only log it and do not bubble this up... Thanks, Peter - Peter Vary On Aug. 8, 2017, 11:35 a.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61497/ > --- > > (Updated Aug. 8, 2017, 11:35 a.m.) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-17267 > https://issues.apache.org/jira/browse/HIVE-17267 > > > Repository: hive-git > > > Description > --- > > HIVE-17267: Make HMS Notification Listeners typesafe > > > Diffs > - > > > hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java > 351546c3bc9edb69a435f04795b5ea6c3421f5b0 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java > ea90a8e4a2d8a79f4356818b11cdbf9eb870256d > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 6a6fd439d72fd5e24c881554c86480b0b3e19574 > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java > 37327f8bd2ebf3f883fb3bd408d63f776b26406e > > metastore/src/java/org/apache/hadoop/hive/metastore/TransactionalMetaStoreEventListener.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61497/diff/1/ > > > Testing > --- > > > Thanks, > > Barna Zsombor Klara > >
Review Request 61497: HIVE-17267: Make HMS Notification Listeners typesafe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61497/ --- Review request for hive and Peter Vary. Bugs: HIVE-17267 https://issues.apache.org/jira/browse/HIVE-17267 Repository: hive-git Description --- HIVE-17267: Make HMS Notification Listeners typesafe Diffs - hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java 351546c3bc9edb69a435f04795b5ea6c3421f5b0 metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java ea90a8e4a2d8a79f4356818b11cdbf9eb870256d metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 6a6fd439d72fd5e24c881554c86480b0b3e19574 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java 37327f8bd2ebf3f883fb3bd408d63f776b26406e metastore/src/java/org/apache/hadoop/hive/metastore/TransactionalMetaStoreEventListener.java PRE-CREATION Diff: https://reviews.apache.org/r/61497/diff/1/ Testing --- Thanks, Barna Zsombor Klara
