Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-03-01 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/#review198477 --- ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-03-01 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/ --- (Updated March 1, 2018, 10:35 p.m.) Review request for hive, Prasanth_J and

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-28 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/ --- (Updated Feb. 28, 2018, 8:19 p.m.) Review request for hive, Prasanth_J and

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-28 Thread Sergey Shelukhin
> On Feb. 28, 2018, 1:29 p.m., Teddy Choi wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/ColumnVectorBatch.java > > Lines 64 (patched) > > > > > > Why is Math.min(3, size) called? See above,

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-28 Thread Teddy Choi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/#review198386 ---

Re: Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/#review198160 ---

Review Request 65766: HIVE-18738 LLAP IO ACID - includes handling is broken

2018-02-22 Thread Sergey Shelukhin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/ --- Review request for hive, Prasanth_J and Teddy Choi. Repository: hive-git