Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/#review199572 --- Ship it! Ship It! - Sahil Takiar On March 8, 2018, 9:40

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

> On March 7, 2018, 5:06 p.m., Sahil Takiar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 996 (patched) > > > > > > Why do this validation in

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/ --- (Updated March 8, 2018, 9:40 a.m.) Review request for hive, Peter Vary and

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

> On March 7, 2018, 5:06 p.m., Sahil Takiar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 1006 (patched) > > > > > > Do the other parameters need

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/ --- (Updated March 8, 2018, 9:35 a.m.) Review request for hive, Peter Vary and

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

> On March 8, 2018, 2:15 a.m., Alexander Kolbasov wrote: > > Afrew with Sahil - the checks should be on the server side. Thanks a lot Sasha for the review! I absolutely agree that it would be better to have the checks on the server side, however these checks have to be done in the client,

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

> On March 7, 2018, 5:06 p.m., Sahil Takiar wrote: > > Thanks a lot Sahil for the review. > On March 7, 2018, 5:06 p.m., Sahil Takiar wrote: > > standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 996 (patched) > >

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/#review198847 --- Afrew with Sahil - the checks should be on the server side. -

Re: Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/#review198796 ---

Review Request 65952: HIVE-18898: Fix NPEs in HiveMetastore.dropPartition method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65952/ --- Review request for hive, Peter Vary and Adam Szita. Bugs: HIVE-18898