Re: Review Request 67887: HIVE-20090

2018-07-13 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/ --- (Updated July 13, 2018, 4:04 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 67887: HIVE-20090

2018-07-12 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/ --- (Updated July 12, 2018, 11:14 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 67887: HIVE-20090

2018-07-12 Thread Jesús Camacho Rodríguez
> On July 12, 2018, 5:18 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java > > Lines 296 (patched) > > > > > > Can we always look past Gby? Shall we restrict it

Re: Review Request 67887: HIVE-20090

2018-07-12 Thread Ashutosh Chauhan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/#review206015 ---

Re: Review Request 67887: HIVE-20090

2018-07-12 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/ --- (Updated July 12, 2018, 3:55 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 67887: HIVE-20090

2018-07-12 Thread Jesús Camacho Rodríguez
> On July 12, 2018, 2:01 a.m., Deepak Jaiswal wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java > > Lines 419 (patched) > > > > > > Each of these functions check if semijoin reduction is

Re: Review Request 67887: HIVE-20090

2018-07-11 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/#review205976 --- LGTM. I have some minor comments.

Review Request 67887: HIVE-20090

2018-07-11 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67887/ --- Review request for hive, Ashutosh Chauhan, Deepak Jaiswal, and Gopal V. Bugs: