Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

> On April 22, 2020, 3:22 p.m., Peter Vary wrote: > > ql/src/java/org/apache/hadoop/hive/ql/ValidTxnManager.java > > Line 113 (original), 112 (patched) > > > > > > Isn't reference level check is risky here? good

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 22, 2020, 3:27 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220426 --- Ship it!

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 22, 2020, 2:29 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 21, 2020, 12:14 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2732 (patched) > > > > > > Maybe rephrase? > > Manages concurrency levels for ACID

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

> On April 20, 2020, 4:55 p.m., Peter Vary wrote: > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > > Lines 2727-2730 (original), 2727-2730 (patched) > > > > > > Is this config still needed in this

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- (Updated April 20, 2020, 8:50 p.m.) Review request for hive, Marton Bod and

Re: Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/#review220374 --- Some nits, did not checked all the unit tests changes. Anything I

Review Request 72387: Locks: Add new lock implementations for always zero-wait readers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72387/ --- Review request for hive, Marton Bod and Peter Vary. Bugs: HIVE-19369