Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-19 Thread Stefan Sperling
On Wed, Dec 19, 2018 at 02:58:28PM +0100, Yann Ylavic wrote: > On Wed, Dec 19, 2018 at 9:53 AM Stefan Sperling wrote: > > > > On Tue, Dec 18, 2018 at 12:29:18AM +0100, Yann Ylavic wrote: > > > But yes, upcast is better, while at it I'd go for uint64_t... > > > > Like this? > > I think

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-19 Thread Stefan Sperling
On Tue, Dec 18, 2018 at 12:29:18AM +0100, Yann Ylavic wrote: > But yes, upcast is better, while at it I'd go for uint64_t... Like this? I've noticed that the same problem seems to exist in some other modules. I'll send separate patches for those once this patch has settled. Index:

Re: [PATCH] mod_deflate: hardcoded "%ld" -> APR_OFF_T_FMT

2018-12-19 Thread Yann Ylavic
On Wed, Dec 19, 2018 at 9:53 AM Stefan Sperling wrote: > > On Tue, Dec 18, 2018 at 12:29:18AM +0100, Yann Ylavic wrote: > > But yes, upcast is better, while at it I'd go for uint64_t... > > Like this? I think APR_UINT64_T_FMT/apr_uint64_t would be more portable ;) Thanks for taking care of this

Re: svn commit: r1849177 - /httpd/httpd/trunk/CHANGES

2018-12-19 Thread William A Rowe Jr
On Wed, Dec 19, 2018 at 12:19 AM Christophe JAILLET < christophe.jail...@wanadoo.fr> wrote: > > I thought that now that 2.5.0 has been tagged, the history of 2.5.0+ > should not be axed when backported (i.e. this change would be in 2.5.1, > but is not in 2.5.0, which is tagged, so "does exist") >

Re: Patches related to HTML output by Apache httpd itself

2018-12-19 Thread Andras Farkas
Ping. https://bz.apache.org/bugzilla/show_bug.cgi?id=62989 It's on the bugzilla too now.