ALPN/NPN support in 2.4

2015-01-09 Thread Stefan Eissing
Hi, I hope this is the right place for it: for an upcoming customer project I need ALPN/NPN support in apache 2.4.x. There is a (reopened) ticket with patch for this (https://issues.apache.org/bugzilla/show_bug.cgi?id=52210) that was started on 2.2.x The patch is applied with slight variation

Re: buckets across threads - question

2015-03-20 Thread Stefan Eissing
pool/memory reuse, e.g. it is faster. Cheers, Stefan Am 17.03.2015 um 23:52 schrieb Graham Leggett minf...@sharp.fm: On 17 Mar 2015, at 15:59, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Hi, I have a question regarding my http2 module implementation, where I seem to fail

Re: buckets across threads - question

2015-03-20 Thread Stefan Eissing
Yann, the positive effect of the recycling of subpools by the allocator is measureable in performance by me. Without a mutex'ed allocator however, the destruction of subpools did crash on me (but it might also be another bug in my code, of course). First, I resolved to using root pools for

buckets across threads - question

2015-03-17 Thread Stefan Eissing
Hi, I have a question regarding my http2 module implementation, where I seem to fail to wrap my head around the limitations of pools and bucket brigades in a multi-threaded environment. As I understand it, httpd has - so far - the underlying assumption: 1 connection - 1 request - 1 thread

Re: buckets across threads - question

2015-03-31 Thread Stefan Eissing
Jim, I am very happy to hear that and would like to compile some feedback/ideas in the next days. I also want to get some better performance comparison numbers for TLS+http/1 vs. TLS+http/2 in the infamous http2 gopher tiles example, not focussing on page load times but requests/sec. The

Re: buckets across threads - question

2015-03-31 Thread Stefan Eissing
31, 2015, at 1:13 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: I think the old NPN patch is in trunk. The ALPN not AFAIK. I undertstand there is a trunk first policy, but it'd be good to get it at least going there... thanks. Stefan Am 31.03.2015 um 18:22 schrieb Jim

Re: buckets across threads - question

2015-03-31 Thread Stefan Eissing
I think the old NPN patch is in trunk. The ALPN not AFAIK. I undertstand there is a trunk first policy, but it'd be good to get it at least going there... thanks. Stefan Am 31.03.2015 um 18:22 schrieb Jim Jagielski j...@jagunet.com: PS. As a small quid-pro-quo and because you were

Re: svn commit: r1670397 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c mod_ssl.h ssl_engine_config.c ssl_engine_io.c ssl_private.h

2015-04-01 Thread Stefan Eissing
Jim, today I converted your commit to a path on 2.4.12 and tested it with mod_h2. All fine! Then I got a trouble report that alpn negotiation always selected http/1.1 unless SSLAlpnPreference configured something else. This is due to the deterministic ordering and http/1.1. h2. So, I made a

ALPN support

2015-03-23 Thread Stefan Eissing
As some people expressed interest in mod_h2, I would like to kindly ask the committers on this list if someone could take a look at ALPN support for mod_ssl (https://bz.apache.org/bugzilla/show_bug.cgi?id=52210). It is basically a patch that adds ALPN to the NPN patch from mod_spdy (which has

Re: svn commit: r1670397 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c mod_ssl.h ssl_engine_config.c ssl_engine_io.c ssl_private.h

2015-04-02 Thread Stefan Eissing
of #if defined(HAVE_TLS_NPN) || defined(HAVE_TLS_ALPN) so that ripping out NPN would be easier. The question is which to use for 2.4... On Apr 1, 2015, at 1:59 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Well, I took the trunk version, diffed to 2.4.12 and made a patch

Re: Version check idea

2015-04-21 Thread Stefan Eissing
Some weeks ago, I asked the openssl team something related to this. I wanted a URL which redirects to the latest 1.0.2 release tar. I use this in my mod_h2 sandbox setup and got rid of updating version numbers for that package. If there would be a url, such as

Re: ALPN patch comments

2015-04-22 Thread Stefan Eissing
Am 22.04.2015 um 17:49 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 22.04.2015 10:52, Stefan Eissing wrote: I made two small patches based on the feedback from Kaspar. One for the code and one for the documentation. Thanks. In the patch for ssl_private.h, the complete NPN block

Re: ALPN patch comments

2015-04-23 Thread Stefan Eissing
I don't know if I have any points to give here, but if NPN does not make it to 2.4, it's fine with me to remove it from trunk also. Only mod_spdy is affected afaik. //Stefan Am 23.04.2015 um 06:56 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 22.04.2015 21:30, Rainer Jung wrote: Am

ALPN patch comments

2015-04-22 Thread Stefan Eissing
I made two small patches based on the feedback from Kaspar. One for the code and one for the documentation. Since I build against releases, I did not test the doc patch building. This code patch I tested against my already patched 2.4.12 with openssl 1.0.2 and 1.0.1 in mod_h2 sandbox. Re

Re: OpenSSL 1.02, PCRE 2.10

2015-04-28 Thread Stefan Eissing
Browder tom.brow...@gmail.com: On Tue, Apr 28, 2015 at 7:05 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Have openssl 1.0.2 running with 2.4.12 in a local installation on Ubuntu 14.04. No special wrestling other than —with-openssl=… in configure. How about apr and apr-util

Re: OpenSSL 1.02, PCRE 2.10

2015-04-28 Thread Stefan Eissing
Have openssl 1.0.2 running with 2.4.12 in a local installation on Ubuntu 14.04. No special wrestling other than —with-openssl=… in configure. //Stefan Am 28.04.2015 um 13:45 schrieb Eric Covener cove...@gmail.com: On Tue, Apr 28, 2015 at 7:36 AM, Tom Browder tom.brow...@gmail.com wrote: I

Re: ALPN patch comments

2015-04-27 Thread Stefan Eissing
Am 25.04.2015 um 11:47 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 22.04.2015 18:54, Jim Jagielski wrote: For me the time seems right to rip NPN out of trunk and only backport the ALPN code to 2.4. I'd be +1 for that. So, to get one step further, and since there were no

Re: svn commit: r1670397 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c mod_ssl.h ssl_engine_config.c ssl_engine_io.c ssl_private.h

2015-04-01 Thread Stefan Eissing
that in trunk we shouldn't think of NPN and ALPN as distinct. On Apr 1, 2015, at 12:47 PM, Rainer Jung rainer.j...@kippdata.de wrote: Hi Stefan, Am 01.04.2015 um 18:22 schrieb Stefan Eissing: Jim, today I converted your commit to a path on 2.4.12 and tested it with mod_h2. All fine

Re: ALPN patch comments

2015-06-03 Thread Stefan Eissing
That is why mod_h2 allowe H2Engine on|off on base server and vhosts. If I understand you correctly, this does what you ask for. //Stefan Am 03.06.2015 um 19:45 schrieb William A Rowe Jr wr...@rowe-clan.net: On Wed, Jun 3, 2015 at 8:43 AM, Stefan Eissing stefan.eiss...@greenbytes.de

Re: ALPN patch comments

2015-06-05 Thread Stefan Eissing
Am 05.06.2015 um 01:37 schrieb Yann Ylavic ylavic@gmail.com: On Fri, Jun 5, 2015 at 1:03 AM, Roy T. Fielding field...@gbiv.com wrote: Hence, we might need a configurable way to ignore a client's ALPN, though I doubt that SSLalpn off is the right way to express that. Likewise,

Re: RFC 7540 (HTTP/2) wrt reusable connections and SNI

2015-06-09 Thread Stefan Eissing
Btw. I have the first report from a user that gets 400 answers in browsers when mod_h2 is active because the browser reused the connection for another host. Also from RFC 7540, 9.2.1 A deployment of HTTP/2 over TLS 1.2 MUST disable renegotiation.“ (Once the h2 session is established,

Re: RFC 7540 (HTTP/2) wrt reusable connections and SNI

2015-06-09 Thread Stefan Eissing
Ylavic ylavic@gmail.com: On Tue, Jun 9, 2015 at 11:21 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Also from RFC 7540, 9.2.1 A deployment of HTTP/2 over TLS 1.2 MUST disable renegotiation.“ (Once the h2 session is established, renegotiation may appear before

Re: ALPN patch comments

2015-06-03 Thread Stefan Eissing
-alpn-v4.patch On Mon, Apr 27, 2015 at 11:06 AM Stefan Eissing stefan.eiss...@greenbytes.de wrote: Am 25.04.2015 um 11:47 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 22.04.2015 18:54, Jim Jagielski wrote: For me the time seems right to rip NPN out of trunk and only backport

Re: ALPN patch comments

2015-06-03 Thread Stefan Eissing
://people.apache.org/~ylavic/httpd-2.4.x-alpn-v4.patch On Mon, Apr 27, 2015 at 11:06 AM Stefan Eissing stefan.eiss...@greenbytes.de wrote: Am 25.04.2015 um 11:47 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 22.04.2015 18:54, Jim Jagielski wrote: For me the time seems right to rip

Re: ALPN patch comments

2015-06-03 Thread Stefan Eissing
I additionally tested today on Ubuntu 14.04 LTS. Works for me. Am 03.06.2015 um 12:56 schrieb Stefan Eissing stefan.eiss...@greenbytes.de: I tested the lined patch on a 2.4.x checkout with mod_h2 on OS X 10.10 and openssl 1.0.2. All my tests ran fine. //Stefan Am 02.06.2015 um 16:56

Re: ALPN patch comments

2015-06-03 Thread Stefan Eissing
Hmm, I cannot test this today since I am travelling. If Jim wants to tag 2.5.13 this week, then either the current v4 patch makes it in, or we need to postpone this. A changed patch on which my module (and possibly others) chokes on, will not serve anyone I assume. As with the don't send NPN

Re: thread/mpm advice

2015-06-09 Thread Stefan Eissing
. //Stefan Am 09.06.2015 um 17:04 schrieb Graham Leggett minf...@sharp.fm: On 09 Jun 2015, at 3:37 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: My understanding is that one uses mpm_prefork when threads are to be avoided. This is not what mod_h2 is about and so I consider disabling

SNI Host: header mismatch

2015-06-10 Thread Stefan Eissing
Today I had the second user which got 400 Bad Request when using mod_h2 with a wildcard certificate. So, I was thinking how to possibly fix the code in mod_ssl. The mostly harmless approach is the addition of a configuration directive that admins may use to explicitly allow multiple host

Re: ALPN patch comments

2015-06-04 Thread Stefan Eissing
I think we need to clarify some things: 1. ALPN is initiated by the client. When a client does not send ALPN as part of client helo, the SSL alpn callbacks are not invoked and the server does not send any ALPN information back. This is different from NPN. 2. SSLAlpnPreference is intended as

thread/mpm advice

2015-06-09 Thread Stefan Eissing
Hi Knowledgeable List! someone reported issues with mod_h2 in relation to some mod_proxy/mod_rewrite setup of his. I added several test cases and all seems fine. Then I found out that he is running on a mpm_prefork configuration... My understanding is that one uses mpm_prefork when threads are

Re: buckets across threads - question

2015-06-22 Thread Stefan Eissing
in the h2 thread after you've had a chance to manipulate stuff. On Tue, Mar 31, 2015 at 2:57 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Thanks, Jim! Am 31.03.2015 um 19:29 schrieb Jim Jagielski j...@jagunet.com: What I did is used the alpn patch as a guide and updated trunk

Re: module configs across (pseudo) connections

2015-06-24 Thread Stefan Eissing
Am 24.06.2015 um 15:26 schrieb Graham Leggett minf...@sharp.fm: I would argue that the copying option above is most dangerous, as this has side effects that may not be catered for by pool cleanups. Totally agree. That is why it is not implemented like that. With the side effect that

Re: module configs across (pseudo) connections

2015-06-24 Thread Stefan Eissing
Am 24.06.2015 um 15:50 schrieb Jim Jagielski j...@jagunet.com: On Jun 24, 2015, at 9:39 AM, Eric Covener cove...@gmail.com wrote: On Wed, Jun 24, 2015 at 9:26 AM, Graham Leggett minf...@sharp.fm wrote: I believe we should be treating the “pseudo” connections as real connections, and

Re: module configs across (pseudo) connections

2015-06-24 Thread Stefan Eissing
Am 24.06.2015 um 16:14 schrieb Eric Covener cove...@gmail.com: On Wed, Jun 24, 2015 at 10:07 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Hmm, yes, well. It's the thought that counts... ;-) I think this will not be enough, though, if I understood the failures of my various

module configs across (pseudo) connections

2015-06-22 Thread Stefan Eissing
...@gmail.com: On Mon, Jun 22, 2015 at 7:38 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Thanks, now I see what you mean. What I do not understand: - why is this EOR processed too early? Usually it is at the end of a brigade and doesn't get cleaned up until all of the data is written

Re: mod_ssl static linking, the eternal topic...

2015-06-23 Thread Stefan Eissing
Sorry for missing that: it is still dynamically linked. Am 23.06.2015 um 13:39 schrieb Rainer Jung rainer.j...@kippdata.de: Am 23.06.2015 um 11:34 schrieb Stefan Eissing: Sorry to bother the list, but I am banging my head against the wall trying to build mod_ssl linked statically

mod_ssl static linking, the eternal topic...

2015-06-23 Thread Stefan Eissing
Sorry to bother the list, but I am banging my head against the wall trying to build mod_ssl linked statically with openssl on Ubuntu. Is there something obvious that I miss in my configure --enable-ssl=shared --with-ssl=$(BLD_PREFIX) --enable-ssl-staticlib-deps ? It works under OS X, but

Re: SNI Host: header mismatch

2015-06-11 Thread Stefan Eissing
@gmail.com wrote: On Wed, Jun 10, 2015 at 4:41 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Today I had the second user which got 400 Bad Request when using mod_h2 with a wildcard certificate. So, I was thinking how to possibly fix the code in mod_ssl. The mostly harmless approach

Re: SNI Host: header mismatch

2015-06-11 Thread Stefan Eissing
Yes, it will work with the cert checks, not without. Sorry, if that was confusing. Am 11.06.2015 um 17:56 schrieb Yann Ylavic ylavic@gmail.com: On Thu, Jun 11, 2015 at 4:33 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Two things: 1. the minimal thing to fix

Re: sni+alpn, vhost+certs

2015-06-18 Thread Stefan Eissing
17, 2015 at 8:21 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: 1. connection, setup for base server and defaults 2. client hello arrives 3. ALPN callback is invoked by openssl 4. ALPN protocol is chosen, this triggers the server answer 5. SNI callback is invoked by openssl and sets

sni+alpn, vhost+certs

2015-06-17 Thread Stefan Eissing
Seems like a good idea to not place the ALPN patches into 2.4 - yet. During my tests, I discovered that the order of my vhost definitions affected the certificate chosen - when ALPN was in play. After some analysis, the following seems to occur. This is to make the mod_ssl people here aware and

Re: ALPN patch comments

2015-06-01 Thread Stefan Eissing
It sounds like it could be a vhost thing. SSL_CTX is most likely not global, but maybe unique for a vhost? I am not certain myself, maybe someone else with more knowledge of mod_ssl could pitch in? //Stefan Am 01.06.2015 um 13:04 schrieb Rainer Jung rainer.j...@kippdata.de: Am 29.04.2015

Re: 2.2 and 2.4 and 2.6/3.0

2015-05-27 Thread Stefan Eissing
Not wanting to boast, but maybe mod_h2 for httpd 2.4 can play a role in motivating people to migrate away from 2.2. I have not looked into having it work on 2.2 and no interest in doing so. If we get the ALPN support into 2.4.13, mod_h2 can be just dropped in to such a server. And distros

mod_h2 internals

2015-05-28 Thread Stefan Eissing
For anyone interested in mod_h2 internals, its parasitic life inside httpd and the apache mutations (=hacks) it is doing, there is now a web page for that: https://icing.github.io/mod_h2/internals.html. For people knowledgable in httpd core APIs (and where else would one find them but here), I

Re: 2.2 and 2.4 and 2.6/3.0

2015-05-28 Thread Stefan Eissing
version of mod_h2 as well as a more significant merging of mod_h2/trunk/2.6/3.0. On May 28, 2015, at 10:36 AM, Nick Kew n...@apache.org wrote: On Wed, 2015-05-27 at 22:42 +0200, Stefan Eissing wrote: Not wanting to boast, but maybe mod_h2 for httpd 2.4 can play a role in motivating people

Re: svn commit: r1688474 [1/21] - in /httpd/httpd/trunk/modules/http2: ./ m4/ mod-h2.xcodeproj/ mod-h2.xcodeproj/project.xcworkspace/ mod-h2.xcodeproj/project.xcworkspace/xcshareddata/ mod-h2.xcodepro

2015-07-03 Thread Stefan Eissing
Am 02.07.2015 um 19:13 schrieb William A Rowe Jr wr...@rowe-clan.net: Just to clarify, On Tue, Jun 30, 2015 at 10:26 AM, j...@apache.org wrote: Author: jim Date: Tue Jun 30 15:26:16 2015 New Revision: 1688474 URL: http://svn.apache.org/r1688474 Log: Fold in git archive master of

Re: mod_ssl static linking, the eternal topic...

2015-06-28 Thread Stefan Eissing
Ah, thanks Kaspar. That explains it. Am 28.06.2015 um 17:20 schrieb Kaspar Brand httpd-dev.2...@velox.ch: On 23.06.2015 13:40, Stefan Eissing wrote: Sorry for missing that: it is still dynamically linked. Am 23.06.2015 um 13:39 schrieb Rainer Jung rainer.j...@kippdata.de: Am

2.4 release backport list

2015-05-26 Thread Stefan Eissing
Sorry, if this question has an obvious answer which I was unable to find: where would I find a list of the changes that will be backported to the 2.4.13 release in order to see if a change has received enough votes? Thanks. //Stefan green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone:

Re: 2.4 release backport list

2015-05-26 Thread Stefan Eissing
ylavic@gmail.com wrote: Hi Stefan, On Tue, May 26, 2015 at 10:37 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Sorry, if this question has an obvious answer which I was unable to find: where would I find a list of the changes that will be backported to the 2.4.13 release

Re: 2.4 release backport list

2015-05-26 Thread Stefan Eissing
Flattery! (I experience I am not immune to this…) Thanks for all the replies! I am currently making a patch that contains all the ALPN changes from trunk and works in 2.4. Hope that someone then can include this as proposal in the 2.4.13 STATUS. May it find votes! Back soonish... Am

Re: svn commit: r1676004 - in /httpd/httpd/trunk: docs/manual/mod/ modules/ssl/

2015-05-26 Thread Stefan Eissing
Good catch. Was done in r1676004 and reverted in r1681746. The latter slipped through my NPN/ALPN sieve. So, basically the html changes should be removed from the patch. //Stefan Am 26.05.2015 um 14:03 schrieb Yann Ylavic ylavic@gmail.com: On Sat, Apr 25, 2015 at 11:46 AM,

Re: 2.4 release backport list

2015-05-26 Thread Stefan Eissing
Thanks Yann! Am 26.05.2015 um 14:26 schrieb Yann Ylavic ylavic@gmail.com: On Tue, May 26, 2015 at 12:30 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Thanks for the many answers! Now, can I win someone over to propose backporting the mod_ssl ALPN changes? Proposed

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-08-17 Thread Stefan Eissing
Done in r1696266. Am 24.07.2015 um 15:54 schrieb Ruediger Pluem rpl...@apache.org: + +/* make sure httpd closes the connection after this */ +c-keepalive = AP_CONN_CLOSE; +ap_lingering_close(c); + +

Re: svn commit: r1692486 [2/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-08-17 Thread Stefan Eissing
Am 24.07.2015 um 15:51 schrieb Ruediger Pluem rpl...@apache.org: +/* Something like this must be in APR, only I do not find it... */ +static int array_index(apr_array_header_t *array, const char *s) +{ +int i; +for (i = 0; i array-nelts; i++) { +const char *p =

Re: C89-ify a recent change to h2_io_set.c

2015-08-19 Thread Stefan Eissing
Thanks Jean-Frederic. Is there a way to ./configure - other than CFLAGS - so that all developers can compile with similar subsets of features and warnings? I would like to write code so that it does not generate warnings for the rest of you... //Stefan Am 19.08.2015 um 14:00 schrieb

Re: C89-ify a recent change to h2_io_set.c

2015-08-19 Thread Stefan Eissing
Am 19.08.2015 um 15:33 schrieb Jim Jagielski j...@jagunet.com: That's the intent for --enable-maintainer-mode Excellent. Thx! green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster: HRB5782

Re: svn commit: r1696592 - in /httpd/httpd/trunk/modules/http2: h2_alt_svc.c h2_conn.c h2_from_h1.c h2_request.c h2_switch.c

2015-08-19 Thread Stefan Eissing
Am 19.08.2015 um 16:37 schrieb William A Rowe Jr wr...@rowe-clan.net: h2_alt_svc *h2_alt_svc_parse(const char *s, apr_pool_t *pool) { -const char *sep = strchr(s, '='); +const char *sep = strchr((char *)s, '='); We solve these issues with ap_strchr_c, ap_strrchr_c, ap_strstr_c

maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
Just a tiny question how the senior guys here do to: If I build httpd in maintainer-mode (which I want), the test framework will no longer build since it inherits the compiler flags from apxs, I assume. Is there an easy way around this? //Stefan green/bytes GmbH Hafenweg 16, 48155 Münster,

Re: maintainer mode and test framework

2015-08-24 Thread Stefan Eissing
cove...@gmail.com: On Mon, Aug 24, 2015 at 9:23 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Just a tiny question how the senior guys here do to: If I build httpd in maintainer-mode (which I want), the test framework will no longer build since it inherits the compiler flags from

regression tests

2015-08-24 Thread Stefan Eissing
I seem to get Test Summary Report --- t/filter/case.t (Wstat: 0 Tests: 4 Failed: 1) Failed test: 2 in regression tests since my vacation. Anything rings a bell? green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster:

protocols and mod_h2 consolidation

2015-08-24 Thread Stefan Eissing
As you might have noticed, I am doing some cleanup work on mod_h2 and want to create THE PATCH for backporting soon. The new core directives Protocols and ProtocolsHonorOrder are implemented, such as on a server or virtual host one may write Protocols h2c http/1.1 # enable h2c and

Re: httpd-trunk\modules\http2\h2_session.c Mystery

2015-08-20 Thread Stefan Eissing
Ah, yes. I think that once changed in an older nghttp2 release and went unnoticed. Thanks for the fix! Am 20.08.2015 um 12:39 schrieb Yann Ylavic ylavic@gmail.com: Hi, On Thu, Aug 20, 2015 at 11:56 AM, NormW no...@gknw.net wrote: #File: h2_session.c # - #

Re: modules\http2 - H2Engine directive?

2015-08-24 Thread Stefan Eissing
Ni Norm, yes, I removed it last week and though I removed it from the doc xml as well. Seems I forgot the Readme. Will fix soon. Sorry for any confusion. //Stefan Am 24.08.2015 um 05:53 schrieb NormW no...@gknw.net: Hi, The 'H2Engine on' directive is identified in the Readme.h2 as the

directive elimination

2015-08-14 Thread Stefan Eissing
Hi, I am currently eliminating some mod_h2 directives which are no longer needed or wanted. If your want to regression test the trunk, please also update the test framework. Thanks. //Stefan green/bytes GmbH Hafenweg 16, 48155 Münster, Germany Phone: +49 251 2807760. Amtsgericht Münster:

Re: httpd Protocols proposal

2015-07-22 Thread Stefan Eissing
So, a RUN_ALL that collects willing protocols pre_select, a ALL for post_select and a FIRST for switch? Am 22.07.2015 um 18:02 schrieb Eric Covener cove...@gmail.com: On Wed, Jul 22, 2015 at 11:58 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Hmm, that would mean first come

Re: httpd Protocols proposal

2015-07-22 Thread Stefan Eissing
Hmm, that would mean first come, first negotiated? Am 22.07.2015 um 17:13 schrieb Yann Ylavic ylavic@gmail.com: On Mon, Jul 20, 2015 at 4:07 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Key points: - Integrates TLS+ALPN and HTTP/1 Upgrade: header - Allows upgrades on clean

Re: httpd Protocols proposal

2015-07-22 Thread Stefan Eissing
Am 22.07.2015 um 19:00 schrieb Yann Ylavic ylavic@gmail.com: On Wed, Jul 22, 2015 at 6:42 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: So, a RUN_ALL that collects willing protocols pre_select, a ALL for post_select post_select is to announce the selected one, right

Re: buildbot failure in ASF Buildbot on httpd-site-staging

2015-07-21 Thread Stefan Eissing
Argh. What did I do? How can I check the site build before commit? Am 21.07.2015 um 17:14 schrieb build...@apache.org: The Buildbot has detected a new failure on builder httpd-site-staging while building ASF Buildbot. Full details are available at:

Re: buildbot failure in ASF Buildbot on httpd-site-staging

2015-07-21 Thread Stefan Eissing
Ok, read the README. Always read the README... Am 21.07.2015 um 17:38 schrieb Stefan Eissing ste...@eissing.org: Argh. What did I do? How can I check the site build before commit? Am 21.07.2015 um 17:14 schrieb build...@apache.org: The Buildbot has detected a new failure on builder

Re: Recommended version of Perl for test framework

2015-07-22 Thread Stefan Eissing
My OS X setup, may it help find the cause of problems: - httpd/trunk built with prefix/opt/apachte-trunk with --*really*-build-and-load-all-modules and then all but one mpm commented out - test/framework/trunk build with /opt/apache-trunk/bin/apxs all extra modules installed/updated with

Re: httpd Protocols proposal

2015-07-21 Thread Stefan Eissing
Have to check and try. Think you register at the CTX as well. Don't know how many are opened by mod_ssl. Am 21.07.2015 um 19:16 schrieb Eric Covener cove...@gmail.com: On Mon, Jul 20, 2015 at 10:37 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Looks reasonable here, maybe need

Re: Recommended version of Perl for test framework

2015-07-21 Thread Stefan Eissing
:( It seemed the best suitable module for the h2 tests. I am not stuck in it, if we do those differently. Am 21.07.2015 um 20:30 schrieb Jim Jagielski j...@jagunet.com: Hmmm... this is weird. The errors and hangs only seem to occur if Protocol::HTTP2 and AnyEvent are added... On Jul

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-07-24 Thread Stefan Eissing
Am 24.07.2015 um 15:54 schrieb Ruediger Pluem rpl...@apache.org: The c-keepalive = AP_CONN_CLOSE looks fine to me, but why should we do the other stuff in a handler. IMHO that should be done by the existing code. Not sure I understand. You mean the interim response or the whole handler?

Re: httpd Protocols proposal

2015-07-23 Thread Stefan Eissing
Am 22.07.2015 um 22:38 schrieb Yann Ylavic ylavic@gmail.com: On Wed, Jul 22, 2015 at 9:37 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: Am 22.07.2015 um 19:00 schrieb Yann Ylavic ylavic@gmail.com: On Wed, Jul 22, 2015 at 6:42 PM, Stefan Eissing stefan.eiss

Re: Jim afk thru Aug 10

2015-07-23 Thread Stefan Eissing
Have a nice holiday! I will also be away more or less offline next week and the one after. //Stefan Am 23.07.2015 um 14:51 schrieb Jim Jagielski j...@jagunet.com: I am on a 2 week holiday and will be mostly offline and unavailable. For emergencies, please try my mobile. green/bytes GmbH

Re: svn commit: r1692486 [1/2] - in /httpd/httpd/trunk: docs/log-message-tags/ include/ modules/http2/ modules/ssl/ server/

2015-07-24 Thread Stefan Eissing
Am 24.07.2015 um 15:40 schrieb Ruediger Pluem rpl...@apache.org: On 07/24/2015 02:09 PM, ic...@apache.org wrote: Author: icing Date: Fri Jul 24 12:09:44 2015 New Revision: 1692486 + static const char *set_http_protocol(cmd_parms *cmd, void *dummy,

Protocols directive, NEW

2015-07-24 Thread Stefan Eissing
In best programmers' tradition, I just made a large commit just before my vacation...In good Apache tradition, however, I ran all regression tests with it. So, hopefully this works for you as well, otherwise, please just revert the commit and curse my name. CAVEAT: this commit changes mod_ssl

Re: trunk/modules/http2 built and tested

2015-07-13 Thread Stefan Eissing
://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/http2/sandbox https://svn.apache.org/repos/asf/httpd/test/mod_h2/trunk to shift that all over to the test tree, perhaps integrate into test/framework/ a bit later on if it's possible. On Fri, Jul 10, 2015 at 10:50 AM, Stefan Eissing

Re: test base line

2015-07-13 Thread Stefan Eissing
09.07.2015 um 13:46 schrieb Stefan Eissing: I need some help with establishing a test baseline. I checked out the test framework from https://svn.apache.org/repos/asf/httpd/test/framework/trunk, followed the README and ran the tests against a freshly installed 2.4.x in /opt/httpd/2.4-plain

Re: test base line

2015-07-14 Thread Stefan Eissing
13.07.2015 um 22:17 schrieb Rainer Jung rainer.j...@kippdata.de: Am 13.07.2015 um 17:34 schrieb Stefan Eissing: Ok, narrowing it down, but not done yet. Problem is as follows: 1 with 'localhost' as servername, tests were failing with waiting for server to warm up, although server

Re: finally...

2015-07-16 Thread Stefan Eissing
Thanks, Jim! Am 16.07.2015 um 17:22 schrieb Jim Jagielski j...@jagunet.com: Testing as we speak... will commit if all OK :) On Jul 15, 2015, at 12:26 PM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: ...got the test framework to PASS on my OS X against httpd/trunk built. I

Re: httpd Protocols proposal

2015-07-20 Thread Stefan Eissing
Am 20.07.2015 um 16:35 schrieb Eric Covener cove...@gmail.com: On Mon, Jul 20, 2015 at 10:07 AM, Stefan Eissing stefan.eiss...@greenbytes.de wrote: I made a proposal for the Protocols extensions that allows various modules participate in protocol negotiation without specific knowledge

httpd Protocols proposal

2015-07-20 Thread Stefan Eissing
I made a proposal for the Protocols extensions that allows various modules participate in protocol negotiation without specific knowledge of the exact mechanism involved. Since this is unreadable as mail and the Apache wiki login was no cooperating, I made a page here:

Re: test base line

2015-07-13 Thread Stefan Eissing
13.07.2015 um 16:02 schrieb Jim Jagielski j...@jagunet.com: If you are using something like a hostname of foo.localdomain (or whatever), make sure that /etc/hosts has that resolving to 127.0.0.1 On Jul 13, 2015, at 9:50 AM, Stefan Eissing ste...@eissing.org wrote: Rainer, many thanks

Re: [VOTE] Release Apache httpd 2.4.16 as GA

2015-07-13 Thread Stefan Eissing
event and worker * Ubuntu 14.04 LTS, 64 bit Am 13.07.2015 um 17:37 schrieb Yann Ylavic ylavic@gmail.com: On Fri, Jul 10, 2015 at 10:33 PM, Jim Jagielski j...@jagunet.com wrote: I'm calling a VOTE on releasing these as Apache httpd 2.4.16 GA. [X] +1: Good to go Event and worker,

some test failures...

2015-07-15 Thread Stefan Eissing
...are amusing when looked at closely: # testing : GET /modules/include/file.shtml # expected: 'Donnerstag, Juli 9, 2015 Donnerstag, Juli 9, 2015 1436433857 1436433857' # received: 'Thursday, July 9, 2015 Thursday, July 9, 2015 1436433857 1436433857' not ok 59 ;-) green/bytes GmbH Hafenweg

finally...

2015-07-15 Thread Stefan Eissing
...got the test framework to PASS on my OS X against httpd/trunk built. I added more description of what I found in the README and checked that in. I have the attached patch to the test code itself, which I will not just dump on you. I think the changes are ok, but will wait for some feedback.

Re: segfault analysis

2015-10-23 Thread Stefan Eissing
Yes, you are correct. The mutex holds. I had my head in java synchronized waits for a second *shudder*... > Am 23.10.2015 um 12:05 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Fri, Oct 23, 2015 at 11:59 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de> w

Re: segfault analysis

2015-10-23 Thread Stefan Eissing
;-) The problem with the unlock in release is that the h2_mplx might have been destroyed by then, as the signal might give the lock to someone waiting. I could move that mutex into h2_session ownership, just lending it to h2_mplx... //Stefan > Am 23.10.2015 um 11:22 schrieb Yann Ylavic

Re: segfault analysis

2015-10-23 Thread Stefan Eissing
Nice analysis, btw. I think you found the problem. I'll replace the timed wait by a simple wait... > Am 23.10.2015 um 11:22 schrieb Yann Ylavic : > > On Fri, Oct 23, 2015 at 11:18 AM, Yann Ylavic wrote: >> >> Index: modules/http2/h2_mplx.c >>

Re: segfault analysis

2015-10-23 Thread Stefan Eissing
is not good as workers appear/disappear during load changes and the parent pool will just continue to grow. //Stefan > Am 23.10.2015 um 12:13 schrieb Yann Ylavic <ylavic@gmail.com>: > > On Fri, Oct 23, 2015 at 10:42 AM, Stefan Eissing > <stefan.eiss...@greenbytes.de>

Re: svn commit: r1711044 - in /httpd/httpd/trunk/modules/http2: h2_io.h h2_mplx.c h2_mplx.h h2_session.c h2_session.h h2_stream.c h2_stream.h h2_task.c h2_task.h h2_task_queue.c h2_task_queue.h h2_ver

2015-10-29 Thread Stefan Eissing
> Am 28.10.2015 um 21:03 schrieb Ruediger Pluem : > On 10/28/2015 04:53 PM, ic...@apache.org wrote: >> [Modified: httpd/httpd/trunk/modules/http2/h2_mplx.c >> URL: >> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http2/h2_mplx.c?rev=1711044=1711043=1711044=diff >>

Re: Thx and merit

2015-10-26 Thread Stefan Eissing
t; I would appreciate if you can check with Jim and let us know the exact URL > where the Apache 2.1.4 H2C module can be accessed from. > > Many thanks > Istvan > > -----Original Message- > From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] > Sent: 14 October 20

segfault analysis

2015-10-23 Thread Stefan Eissing
A question to the more experienced httpd debuggers: In regard to https://bz.apache.org/bugzilla/show_bug.cgi?id=58524 Can I recover any files/lines from these === Backtrace: = /lib64/libc.so.6[0x32a507174f] /lib64/libc.so.6(cfree+0x4b)[0x32a5075a4b]

Re: buckets and connections (long post)

2015-10-22 Thread Stefan Eissing
(I split these up, since answers touch on different topics): > Am 21.10.2015 um 16:48 schrieb Graham Leggett <minf...@sharp.fm>: > > On 21 Oct 2015, at 4:18 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > >> How good does this mechanism work fo

buckets and connections (long post)

2015-10-21 Thread Stefan Eissing
(Sorry for the long post. It was helpful for myself to write it. If this does not hold your interest long enough, just ignore it please.) As I understand it - and that is incomplete - we have a usual request processing like this: A) worker: conn <--- cfilter <--- rfilter

Re: buckets and connections (long post)

2015-10-22 Thread Stefan Eissing
> Am 21.10.2015 um 16:48 schrieb Graham Leggett <minf...@sharp.fm>: > > On 21 Oct 2015, at 4:18 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > [...] >> 3. The amount of buffered bytes should be more flexible per stream and >> redistribu

Re: buckets and connections (long post)

2015-10-22 Thread Stefan Eissing
> Am 21.10.2015 um 16:48 schrieb Graham Leggett <minf...@sharp.fm>: > > On 21 Oct 2015, at 4:18 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: > >> 7. The buckets passed down on the master connection are using another buffer >> - when on htt

Re: buckets and connections (long post)

2015-10-22 Thread Stefan Eissing
> Am 21.10.2015 um 16:48 schrieb Graham Leggett <minf...@sharp.fm>: > > On 21 Oct 2015, at 4:18 PM, Stefan Eissing <stefan.eiss...@greenbytes.de> > wrote: >> 6. pool buckets are very tricky to optimize, as pool creation/destroy is not >> thread-safe

Re: svn commit: r1714602 - in /httpd/httpd/trunk/modules/http2: h2_bucket_eoc.c h2_conn.c h2_io.c h2_io.h h2_mplx.c h2_session.c h2_session.h h2_task.c h2_task.h

2015-11-16 Thread Stefan Eissing
Yann, I changed the access after free, thanks again(!) for reviewing this. The spare pool I left like this for now. I think, *if* there is only one spare, it may be beneficial to keep the newest one, as a) that might be hot and b) it destroys pools more frequently and may recycle memory

  1   2   3   4   5   6   7   8   9   10   >