Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c

2001-09-04 Thread Greg Marr
At 06:19 PM 09/03/2001, Graham Leggett wrote: Greg Marr wrote: How exactly do you use Cache-Control directives so that the content that is cached is before includes are processed, and that when it is retrieved from the cache, the includes are processed? It just doesn't work that

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread Ryan Bloom
On Monday 03 September 2001 23:57, [EMAIL PROTECTED] wrote: jerenkrantz01/09/03 23:57:58 Modified:server util_filter.c Log: **NO CODE CHANGES** This is a reformat commit *ONLY* Please drive on through. (One spelling tpyo fixed...) Didn't we decide a LONG time ago

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread Jeff Trawick
[EMAIL PROTECTED] writes: jerenkrantz01/09/03 23:50:52 Modified:server util_filter.c Log: The ap_add_input_filter/ap_add_output_filter functions do an O(n) scan through the list of registered filters. This patch replaces the linear list with a hash table for better

Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c

2001-09-04 Thread Graham Leggett
Greg Marr wrote: mod_cache and mod_include should have no knowledge of each other. Exactly. They shouldn't care in which order they are run, that should be up to the admin. You're saying the opposite, that mod_cache should only be able to run after mod_include. No - I am saying

Re: cvs commit: httpd-2.0/server util_script.c

2001-09-04 Thread Cliff Woolley
On Mon, 3 Sep 2001, Ryan Bloom wrote: !--#include virtual=/cgi-bin/redir.cgi-- ASSERT FAILED (see below) I would be willing to bet that this is a bug in mod_include, not the change that I made earlier today. Oh, I'm right with you on that one... I seriously doubt the two are related.

Re: [PATCH] RE: make distclean doesn't

2001-09-04 Thread Ryan Bloom
On Sunday 02 September 2001 01:22, Greg Stein wrote: On Fri, Aug 31, 2001 at 09:16:15PM -0700, Ryan Bloom wrote: On Friday 31 August 2001 19:31, William A. Rowe, Jr. wrote: From: Greg Stein [EMAIL PROTECTED] Sent: Friday, August 31, 2001 9:30 PM On Fri, Aug 31, 2001 at 03:02:32PM

Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c

2001-09-04 Thread William A. Rowe, Jr.
From: Bill Stoddard [EMAIL PROTECTED] Sent: Tuesday, September 04, 2001 10:02 AM I agree with this. Our current AP_FTYPE_* classifications is not granular enough to support this but that is easily fixed. Patch on the way... Err or not. Jeff convinced me that it was premature to add

Re: cvs commit: httpd-2.0/support Makefile.in

2001-09-04 Thread Ian Holsman
[EMAIL PROTECTED] wrote: rbb 01/09/02 20:27:48 Modified:buildrules.mk.in support Makefile.in Log: Make Apache 2.0 install all files in the same location as Apache 1.3 did. PR: 7626 Revision ChangesPath 1.4 +2 -2

Re: cvs commit: httpd-2.0/support Makefile.in

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 08:52, Ian Holsman wrote: Index: rules.mk.in === RCS file: /home/cvs/httpd-2.0/build/rules.mk.in,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 ---

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread Justin Erenkrantz
On Tue, Sep 04, 2001 at 06:40:03AM -0700, Ryan Bloom wrote: Didn't we decide a LONG time ago not to do this unless it was absolutely necessary? Format changes just add cruft to the CVS logs. I have noticed a lot of changes to the format in this patch that were more opinion than code style.

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread G√ľnter Knauf
Hi Kevin, Guenter Knauf wrote... Hi, I was glad as Ian contributed his mod_gz; I tested it on Linux and Win32 and it works for me. What did you test? that it compiles, loads into server and compresses. How 'heavily loaded' was the Server? you're right, I did only a quick test with some

Re: per-dir config

2001-09-04 Thread William A. Rowe, Jr.
From: Rasmus Lerdorf [EMAIL PROTECTED] Sent: Tuesday, September 04, 2001 11:05 AM Ok, so the Apache 1.3 walks/hooks flow looks like this: I'll rework this for you just a bit... ::post read-request hook:: location_walk - checks r-uri and sets server-wide config XXuri-filename

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread Justin Erenkrantz
On Tue, Sep 04, 2001 at 04:28:45PM -, [EMAIL PROTECTED] wrote: jerenkrantz01/09/04 09:28:45 Modified:server util_filter.c Log: Jeff pointed out that the character array must be constant. Well, it's not, so make it allocated from the correct pool rather than the

Re: per-dir config

2001-09-04 Thread Rasmus Lerdorf
It shouldn't. You potentially need to protect yourself from NULL r-filename (we haven't decided what to do yet with *this*is*not*a*file* requests.) Since PHP generally serves -files-, this won't be a huge change for you. For serving from an SQL database, or proxied requests, or internal

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 09:16, Justin Erenkrantz wrote: On Tue, Sep 04, 2001 at 06:40:03AM -0700, Ryan Bloom wrote: Didn't we decide a LONG time ago not to do this unless it was absolutely necessary? Format changes just add cruft to the CVS logs. I have noticed a lot of changes to

Re: cvs commit: httpd-2.0/modules/experimental mod_cache.c

2001-09-04 Thread Bill Stoddard
just to add my 2c to the picture. I dont see why the cache-filter could not live anywhere in the filter chain it could sit just after the handler (where it could cache a report generator) which would then feed into php/include it could sit after php/include and possibly after the gzip/byte

[PATCH] Make filter names lowercase

2001-09-04 Thread Justin Erenkrantz
Both Cliff and OtherBill sent me emails complaining about the change to strcasecmp in some places to support Brian Pane's new hash code in util_filter.c. (Never mind that a lot of the code already did strcasecmp...) This patch makes the filter name lowercase for the searches and lets us use

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread TOKILEY
In a message dated 01-09-04 09:35:50 EDT, Jim wrote... That's right and one of them is... Will Apache accept ZLIB into the Apache source tree in either source or binary library format for all platforms. Check one box only... [__] Yes [__] No Actually, it's not a

Re: cvs commit: httpd-2.0/server util_filter.c

2001-09-04 Thread dean gaudet
On Tue, 4 Sep 2001, Ryan Bloom wrote: On Tuesday 04 September 2001 09:16, Justin Erenkrantz wrote: Ryan, you may veto this commit. However, if you wish to repeal or modify our style guide, I suggest you call a vote. -- justin That is complete BS. We have a long standing tradition of

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread TOKILEY
In a message dated 01-09-04 12:39:44 EDT, Guenter writes... Guenter Knauf wrote... Hi, I was glad as Ian contributed his mod_gz; I tested it on Linux and Win32 and it works for me. What did you test? that it compiles, loads into server and compresses. How 'heavily loaded'

RE: [PATCH] hash table for registered filter list

2001-09-04 Thread Charles Randall
What type of performance improvements did you see with this (under what workload)? Charels -Original Message- From: Brian Pane [mailto:[EMAIL PROTECTED]] Sent: Monday, September 03, 2001 11:50 PM To: [EMAIL PROTECTED] Subject: [PATCH] hash table for registered filter list The

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Brian Pane
Justin Erenkrantz wrote: Both Cliff and OtherBill sent me emails complaining about the change to strcasecmp in some places to support Brian Pane's new hash code in util_filter.c. (Never mind that a lot of the code already did strcasecmp...) This patch makes the filter name lowercase for the

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread Ian Holsman
On Tue, 2001-09-04 at 12:29, [EMAIL PROTECTED] wrote: ASIDE: You really only need the 'compression' part of it. You are a Server, not a client. we also can be a client. think mod-proxy ..The Weekend Warrior Yours... Kevin Kiley -- Ian Holsman [EMAIL PROTECTED] Performance

mod_include performance update

2001-09-04 Thread Brian Pane
The good news: With some of the recent performance patches (thanks to Justin for all the commits), the throughput of 2.0 on SSI requests has improved quite a bit. IanH ran the old and new code through his benchmark setup in which clients request a .shtml file with two included files (threaded

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 12:08, Justin Erenkrantz wrote: Wouldn't this be a much cleaner patch if we went to upper case instead of lower-case? I realize that is a detail, but currently, most of the filters are registered as upper case, so we would have fewer places to modify. Ryan Both

Re: [PATCH] hash table for registered filter list

2001-09-04 Thread Greg Stein
On Mon, Sep 03, 2001 at 11:53:59PM -0700, Justin Erenkrantz wrote: On Mon, Sep 03, 2001 at 10:50:01PM -0700, Brian Pane wrote: The ap_add_input_filter/ap_add_output_filter functions do an O(n) scan through the list of registered filters. This patch replaces the linear list with a hash

Re: [PATCH] RE: make distclean doesn't

2001-09-04 Thread Greg Stein
On Tue, Sep 04, 2001 at 08:15:08AM -0700, Ryan Bloom wrote: On Sunday 02 September 2001 01:22, Greg Stein wrote: ... I use distclean on my computer all the time. Along with extraclean. Neither of those targets should toss config.nice. *That* is what I mean. To be clear: nothing in our

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread Greg Stein
On Mon, Sep 03, 2001 at 05:47:02PM -0700, Ryan Bloom wrote: ... I have a big problem with this. We had a hard enough time contributing patches back to MM. The only reason we keep expat and pcre up to date, is that we NEVER make any changes to them. I would be very much against adding zlib

Re: [PATCH] pre-merge of per-dir configs to speed up directory_walk

2001-09-04 Thread William A. Rowe, Jr.
From: Brian Pane [EMAIL PROTECTED] Sent: Tuesday, September 04, 2001 6:20 PM William A. Rowe, Jr. wrote: We are on the same page :) FWIW, I've made a few comments around your patch, and am reviewing it in more detail. I'll have my comments by the end of the week (I'm all over creation

Re: [PATCH] pre-merge of per-dir configs to speed up directory_walk

2001-09-04 Thread Brian Pane
William A. Rowe, Jr. wrote: From: Brian Pane [EMAIL PROTECTED] Sent: Tuesday, September 04, 2001 6:20 PM William A. Rowe, Jr. wrote: We are on the same page :) FWIW, I've made a few comments around your patch, and am reviewing it in more detail. I'll have my comments by the end of the week

zlib inclusion and mod_gz(ip) recap (was: [PATCH] Add mod_gz to httpd-2.0)

2001-09-04 Thread Greg Stein
On Tue, Sep 04, 2001 at 03:29:04PM -0400, [EMAIL PROTECTED] wrote: ... Will the Apache group accept the ZLIB source code into the distribution tree at this time?... [__] Yes [__] No No. The zlib library is popular enough (read: typically installed) that we will link against it, rather than

Re: [PATCH] Make filter names lowercase

2001-09-04 Thread Cliff Woolley
On Tue, 4 Sep 2001, Justin Erenkrantz wrote: All uppercase. 6 of one, half-dozen of the other. -- justin I'll take the 6. I like this a whole lot better. Thanks, Justin. :) --Cliff -- Cliff Woolley [EMAIL PROTECTED]

the rollup issue (was: Re: [PATCH] Add mod_gz to httpd-2.0)

2001-09-04 Thread Greg Stein
On Sat, Sep 01, 2001 at 06:19:32PM -0700, Ryan Bloom wrote: ... 3) I don't believe that we should be adding every possible module to the core distribution. I personally think we should leave the core as minimal as possible, and only add more modules if they implement a part of the HTTP

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread Ian Holsman
[EMAIL PROTECTED] wrote: In a message dated 01-09-04 19:17:25 EDT, Ian writes... ASIDE: You really only need the 'compression' part of it. You are a Server, not a client. we also can be a client. think mod-proxy What current ( or future ) operation would require mod_proxy to

remaining CPU bottlenecks in 2.0

2001-09-04 Thread Brian Pane
I'm currently studying profiling data from an httpd built from a CVS snapshot earlier today. In general, the performance of 2.0 is starting to look good. Here are the top 30 functions, ranked according to their CPU utilization. (This summary is derived from a Quantify profile of a threaded-MPM

Re: remaining CPU bottlenecks in 2.0

2001-09-04 Thread Justin Erenkrantz
On Tue, Sep 04, 2001 at 08:00:35PM -0700, Brian Pane wrote: I'm currently studying profiling data from an httpd built from a CVS snapshot earlier today. In general, the performance of 2.0 is starting to look good. Cool. This probably means the code is starting to look good, too. * The

Re: Fw: Regarding lower-case HTML tags

2001-09-04 Thread Justin Erenkrantz
On Tue, Sep 04, 2001 at 10:12:32PM -0500, William A. Rowe, Jr. wrote: Josh just came up with what I believe is the best explanation of if and when to reformat - I think this applies equally well to sources and docs. I'd added only one caviat - changes to the format should always -preceed-

Re: remaining CPU bottlenecks in 2.0

2001-09-04 Thread William A. Rowe, Jr.
From: Justin Erenkrantz [EMAIL PROTECTED] Sent: Tuesday, September 04, 2001 11:46 PM Based on the patches you submitted (and my quasi-errant formatting patch), I had to read most of the code in mod_include, so I'm more familiar with mod_include now. I do think there are some obvious ways

Re: [PATCH] Add mod_gz to httpd-2.0

2001-09-04 Thread Ryan Bloom
On Tuesday 04 September 2001 18:23, Greg Stein wrote: On Mon, Sep 03, 2001 at 05:47:02PM -0700, Ryan Bloom wrote: ... I have a big problem with this. We had a hard enough time contributing patches back to MM. The only reason we keep expat and pcre up to date, is that we NEVER make any