non thread safe functions used in apache httpd project

2011-01-12 Thread Kevin J Walters
Hi, Whilst looking at a thread safety issue in mod_fastcgi, i noticed there's some suspicious looking code in apache httpd project. server/mpm_common.c (2.2.17) has two functions ap_uname2id and ap_gname2id which call getpwnam and getgrnam, two non-reentrant functions. Comparing with typical

Re: Inserting protocol filters into chains with no resource filters

2011-01-12 Thread pfee
- Original Message From: Stefan Fritsch s...@sfritsch.de To: dev@httpd.apache.org Cc: p...@talk21.com p...@talk21.com Sent: Tuesday, 11 January, 2011 22:33:33 Subject: Re: Inserting protocol filters into chains with no resource filters On Tuesday 11 January 2011, p...@talk21.com

Re: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c

2011-01-12 Thread Joe Orton
On Tue, Dec 21, 2010 at 11:43:42AM -, rpl...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1051468view=rev Log: * Do not drop contents of incomplete lines, but safe them for the next round of reading. PR: 50481 ... --- httpd/httpd/trunk/modules/ssl/ssl_engine_io.c

RE: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c

2011-01-12 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Joe Orton Sent: Mittwoch, 12. Januar 2011 14:27 To: dev@httpd.apache.org Subject: Re: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c On Tue, Dec 21, 2010 at 11:43:42AM -, rpl...@apache.org wrote: URL:

Re: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c

2011-01-12 Thread Joe Orton
On Wed, Jan 12, 2011 at 03:29:45PM +0100, Plüm, Rüdiger, VF-Group wrote: In that case the correct behaviour of the input filter is to return a partial read with APR_SUCCESS (per AP_MODE_GETLINE semantics described in util_filter.h). So the data must *not* also be buffered in that

RE: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c

2011-01-12 Thread Plüm, Rüdiger, VF-Group
-Original Message- From: Joe Orton Sent: Mittwoch, 12. Januar 2011 15:51 To: dev@httpd.apache.org Subject: Re: svn commit: r1051468 - in /httpd/httpd/trunk: CHANGES modules/ssl/ssl_engine_io.c On Wed, Jan 12, 2011 at 03:29:45PM +0100, Plüm, Rüdiger, VF-Group wrote: In

Prepare for large proxy commit...

2011-01-12 Thread Jim Jagielski
My current migration of mod_proxy away from the scoreboard and to slotmem is done. All that remains is some final testing. This will serve as the basis for adding in members during runtime. Currently, the idea is that we only change the number of workers, but nothing really prevents us from also

Re: Hook end of connection

2011-01-12 Thread Victor Ronin
Nick, Thanks. Any cleanup registered on the child pool will run when the child quits, if that's any use to you. This won't work for me (child usually serves many connection). Register a cleanup on the connection pool. Got it. This will work. Connection uses context pool and I thought

Re:Prepare for large proxy commit...

2011-01-12 Thread 邢付贵
At 2011-01-13,Jim Jagielski j...@jagunet.com wrote: My current migration of mod_proxy away from the scoreboard and to slotmem is done. All that remains is some final testing. This will serve as the basis for adding in members during runtime. Currently, the idea is that we only change the

Re: module configuration kill

2011-01-12 Thread Peter Janovsky
is it possible to hook into an event fired when the workers are shutdown, if so how? basically i am interested in the cleanup process modules enter when their associated worker threads either crash or are stopped/restarted. From: Nick Kew n...@apache.org To:

Hook end of connection

2011-01-12 Thread Victor Ronin
Hi, I need to write a module, which does something at the beginning and at the end of each connection. I found a hook to handle beginning of connection - ap_run_pre_connection. It's executed quite early, which works for me. And I need to execute some actions prior or just after connection

Re: Hook end of connection

2011-01-12 Thread Nick Kew
On Wed, 12 Jan 2011 14:49:53 -0500 Victor Ronin victor.ro...@gmail.com wrote: Hi, I need to write a module, which does something at the beginning and at the end of each connection. Register a cleanup on the connection pool. -- Nick Kew Available for work, contract or permanent.

Re: Hook end of connection

2011-01-12 Thread Victor Ronin
On 1/12/11 4:13 PM, Andrew Godziuk wrote: I think the logging hook would do the trick too. Do you mean ap_hook_log_transaction? I believe it's executed at the end of request vs. end of connection. Regards, Victor