Re: [VOTE] Release Apache httpd 2.2.26 as GA

2013-11-15 Thread Sascha Kühndel
Tested on Solaris 10 / Sparc with APR 1.4.8/APU 1.5.2 32-Bit build Looks good [X] +1: Good to go ursprüngliche Nachricht- Von: Jim Jagielski j...@jagunet.com An: dev@httpd.apache.org dev@httpd.apache.org Kopie: test...@httpd.apache.org Datum: Wed, 13 Nov 2013

Re: windows binaries thread from users@

2013-11-15 Thread Mario Brandt
I think in pub/httpd/binaries/win32/README could be a link to http://httpd.apache.org/docs/current/platform/windows.html cause there are the links for Windows binaries. Cheers On 14 November 2013 15:37, Jeff Trawick traw...@gmail.com wrote: On Thu, Nov 14, 2013 at 9:26 AM, Eric Covener

apr_pstrdup(r-connection-pool, http); // returning 0?

2013-11-15 Thread Ralph Ritoch
Hi, Does anyone know why apr_pstrdup(r-connection-pool, http); would be returning 0x0? It is causing a segfault in the module I'm developing @ https://github.com/rritoch/PikeVM/blob/master/root/boot/system-1.1/apache/src/mod_pikevm.c#L585 Here is the relevant gdb output 581

Re: apr_pstrdup(r-connection-pool, http); // returning 0?

2013-11-15 Thread Ralph Ritoch
This issue has been resolved. The problem was revealed by the compiler warnings... ./mod_pikevm.c:117: warning: implicit declaration of function ‘apr_pstrdup’ The solution was to add #include apr_strings.h to mod_pikevm.c Best Regards, Ralph Ritoch On Fri, Nov 15, 2013 at 7:04 PM, Ralph

Request for eyes and votes

2013-11-15 Thread Jim Jagielski
With a TR of 2.4.7 sometime next week, there are a few backports that would be *most* beneficial to be in this release, and most of them are lacking a single +1 vote.

Re: [users@httpd] mod_proxy doesn't persist connections to php-fpm

2013-11-15 Thread Jeff Trawick
On Thu, Nov 14, 2013 at 5:02 PM, Jim Jagielski j...@jagunet.com wrote: stop setting it all the time in that particular case? Would a -notes work? I'm thinking along these lines: FastCGI connections should continue to default to closing connections even with the default disablereuse=off since

Re: [users@httpd] mod_proxy doesn't persist connections to php-fpm

2013-11-15 Thread Jim Jagielski
Or just 'reuse=On | reuse=Off' maybe? On Nov 15, 2013, at 11:51 AM, Jeff Trawick traw...@gmail.com wrote: On Thu, Nov 14, 2013 at 5:02 PM, Jim Jagielski j...@jagunet.com wrote: stop setting it all the time in that particular case? Would a -notes work? I'm thinking along these lines:

Re: [users@httpd] mod_proxy doesn't persist connections to php-fpm

2013-11-15 Thread Jeff Trawick
On Fri, Nov 15, 2013 at 12:02 PM, Jim Jagielski j...@jagunet.com wrote: Or just 'reuse=On | reuse=Off' maybe? we already have disablereuse on ProxyPass On Nov 15, 2013, at 11:51 AM, Jeff Trawick traw...@gmail.com wrote: On Thu, Nov 14, 2013 at 5:02 PM, Jim Jagielski j...@jagunet.com

Re: [users@httpd] mod_proxy doesn't persist connections to php-fpm

2013-11-15 Thread Jim Jagielski
Yeah, I was just wondering if having it a setting rather than adding another flag made sense... That is having 'disablereuse' be replaced by 'reuse=off' and deprecating it. On Nov 15, 2013, at 12:06 PM, Jeff Trawick traw...@gmail.com wrote: On Fri, Nov 15, 2013 at 12:02 PM, Jim Jagielski

Re: False positive errno test after call to strtol()

2013-11-15 Thread Jeff Trawick
On Thu, Nov 14, 2013 at 4:11 PM, Mike Rumph mike.ru...@oracle.com wrote: The man page for strtol() indicate that the function can set errno to ERANGE (EINVAL is also possible for some environments). But for the errno check to be valid errno should be set to 0 before the function call. -

Re: False positive errno test after call to strtol()

2013-11-15 Thread Mike Rumph
Thanks Jeff, Here is an example with no validation: modules/aaa/mod_auth_digest.c (lines 980 - 982): if (resp-opaque) { resp-opaque_num = (unsigned long) strtol(resp-opaque, NULL, 16); } Here is an example with limited validation:

Re: svn commit: r1542413 - /httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c

2013-11-15 Thread Jim Jagielski
When I looked at apr_file_write_full() it appeared that it could return APR_SUCCESS but not send all the data... I may be mistaken though. As long as APR_SUCCESS means that all data was sent, this is perfect. On Nov 15, 2013, at 4:52 PM, traw...@apache.org wrote: Author: trawick Date: Fri Nov

Re: svn commit: r1542413 - /httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c

2013-11-15 Thread Jeff Trawick
On Nov 15, 2013 7:00 PM, Jim Jagielski j...@jagunet.com wrote: When I looked at apr_file_write_full() it appeared that it could return APR_SUCCESS but not send all the data... I may be mistaken though. As long as APR_SUCCESS means that all data was sent, this is perfect. I don't have it

Re: [VOTE] Release Apache httpd 2.2.26 as GA

2013-11-15 Thread Chris Darroch
Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.2.26 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.2.26 GA. +1: CentOS 5.5 (x86_64), APR 1.4.8, APR-util 1.5.2, OpenSSL 1.0.1e Chris.

2.4.x with uds patch; FastCGI broken?

2013-11-15 Thread Kyle Johnson
I've been attempting to test the uds support on 2.4.x with the uds patch ( http://people.apache.org/~jim/patches/uds-2.4.patch). I'm assuming HTTP works (it would appear based on the mailing list that the author has been tested it with HTTP). However, when I try using fcgi the socket appears to

Re: [VOTE] Release Apache httpd 2.2.26 as GA

2013-11-15 Thread Eric Covener
On Wed, Nov 13, 2013 at 12:03 PM, Jim Jagielski j...@jagunet.com wrote: The pre-release test tarballs for Apache httpd 2.2.26 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.2.26 GA. [X] +1: Good to go +1