Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On Wed, Feb 8, 2017 at 10:45 AM, Jim Jagielski wrote: > Which ones? You mean the special case one? > > Would it be better if we did that *before* calling > the fix_cgivars(). What is there makes the following > config pair work as-is: > > AddType application/x-php7-fpm .php >

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

Which ones? You mean the special case one? Would it be better if we did that *before* calling the fix_cgivars(). What is there makes the following config pair work as-is: AddType application/x-php7-fpm .php Action application/x-php7-fpm /fpm virtual SetHandler

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

Just to be clear, I simply *tested* against that config... the patch is not designed to do anything with it. It was basically to ensure that it introduced no regressions.

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

> On Feb 8, 2017, at 10:52 AM, Eric Covener wrote: > > On Wed, Feb 8, 2017 at 10:45 AM, Jim Jagielski wrote: >> Which ones? You mean the special case one? >> >> Would it be better if we did that *before* calling >> the fix_cgivars(). What is there makes

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On 02/08/2017 07:52 AM, Eric Covener wrote: My concern is that nobody ever reported this config as broken and there's no telling what any on-by-default change here can break. +1. Maybe a different way to put it: what does this approach solve that a revert-to-previous-behavior + FCGI-SetEnv

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

> On Feb 8, 2017, at 1:08 PM, Jacob Champion wrote: > > On 02/08/2017 07:52 AM, Eric Covener wrote: >> My concern is that nobody ever reported this config as broken and >> there's no telling what any on-by-default change here can break. > > +1. > > Maybe a different way

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

Have you even TRIED it? I have. With PHP-FPM as well as that Perl script FPM. All works as expected. > On Feb 8, 2017, at 3:27 PM, Jacob Champion wrote: > > On 02/08/2017 12:10 PM, Jim Jagielski wrote: >> Doesn't the below make it work without changes. >> >> #define

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

> On Feb 8, 2017, at 2:49 PM, Jacob Champion wrote: > > On 02/08/2017 11:32 AM, Jim Jagielski wrote: >> It does it automatically requiring no config-file changes >> to the end user. > > Anyone picking up the SCRIPT_FILENAME change (which was my change that > started this

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On 02/08/2017 11:32 AM, Jim Jagielski wrote: It does it automatically requiring no config-file changes to the end user. Anyone picking up the SCRIPT_FILENAME change (which was my change that started this whole mess) still has to change their backend type manually, so I'm not convinced. But

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On 02/08/2017 12:10 PM, Jim Jagielski wrote: Doesn't the below make it work without changes. #define FCGI_MAY_BE_FPM(dconf) \ (dconf && \ ((dconf->backend_type == BACKEND_DEFAULT_UNKNOWN) || \

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On 02/08/2017 01:32 PM, Jim Jagielski wrote: I am confused then... what else are you proposing? Eric's envar fix allows for people to basically adjust at their whim. What else is needed?? In my view, nothing else is needed. We revert my changes (and the followup query string modification) in

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On 02/08/2017 12:31 PM, Jim Jagielski wrote: Have you even TRIED it? Yes, with the latest trunk, a config of SetHandler "proxy:fcgi://localhost:10102/" leads to a SCRIPT_FILENAME of 'proxy:fcgi://localhost:10102//tmp/apache-svn-trunk/htdocs/hello.php'. I have. With

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

2017-02-08 22:37 GMT+01:00 Jacob Champion : > On 02/08/2017 01:32 PM, Jim Jagielski wrote: > >> I am confused then... what else are you proposing? Eric's envar fix allows >> for people to basically adjust at their whim. What else is needed?? >> > > In my view, nothing else

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

> On Feb 8, 2017, at 4:09 PM, Jacob Champion wrote: > > On 02/08/2017 12:31 PM, Jim Jagielski wrote: >> Have you even TRIED it? > > Yes, with the latest trunk, a config of > > >SetHandler "proxy:fcgi://localhost:10102/" > > > leads to a SCRIPT_FILENAME

Re: svn commit: r1782209 - /httpd/httpd/branches/2.4.x/STATUS

On Wed, Feb 8, 2017 at 3:31 PM, Jim Jagielski wrote: > I have. With PHP-FPM as well as that Perl script FPM. All works > as expected. In my env, the change doesn't result in any change to SCRIPT_NAME. I only test w/ the perl script and use *.phx vs *.php to see both paths.

Session support for mod_auth_basic [PATCH 60708]

Hello I posted this patch that brings mod_session support for mod_auth_basic in trunk and 2.4.x https://bz.apache.org/bugzilla/show_bug.cgi?id=60708 Any comment on it? The motivation was to reduce the latency of Webdav operation from Windows: using just HTTP basic authentication, each request is

Re: mood_remoteip ProxyProtocol addition

On 02/08/2017 01:00 AM, Reindl Harald wrote: > > > Am 08.02.2017 um 00:44 schrieb Yann Ylavic: >> On Wed, Feb 8, 2017 at 12:25 AM, Yann Ylavic >> wrote: >>> On Wed, Feb 8, 2017 at 12:01 AM, Reindl Harald >>> wrote: how can you trust as a

Re: proxy test failures between 2.4 and trunk

I am back w/ cycles so ping me if I can help. > On Feb 8, 2017, at 8:47 AM, Eric Covener wrote: > > I owe a backport in this one, jorton added the test to demonstrate an > issue reported. Will move it along today. > > On Wed, Feb 8, 2017 at 8:43 AM, Jim Jagielski

FINAL REMINDER: CFP for ApacheCon closes February 11th

Dear Apache Enthusiast, This is your FINAL reminder that the Call for Papers (CFP) for ApacheCon Miami is closing this weekend - February 11th. This is your final opportunity to submit a talk for consideration at this event. This year, we are running several mini conferences in conjunction with

Re: proxy test failures between 2.4 and trunk

I owe a backport in this one, jorton added the test to demonstrate an issue reported. Will move it along today. On Wed, Feb 8, 2017 at 8:43 AM, Jim Jagielski wrote: > Just a FYI that there is a test failure in t/modules/proxy.t > in 2.4-HEAD which is not present in trunk... >

proxy test failures between 2.4 and trunk

Just a FYI that there is a test failure in t/modules/proxy.t in 2.4-HEAD which is not present in trunk... # testing : reverse Location-proxy to index.html # expected: 200 # received: '404' not ok 3 # testing : reverse Location-proxied body # expected: qr/^welcome to / # received: ' # # 404 Not