Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
It's not a question of majority - a majority now provide a cmake option. It is a question of dependency, PCRE must be built, PCRE must be configured with cmake, cmake is a mandatory tool for configuring httpd on windows, irrespective of how many times it must be invoked. brotli is a new

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
On Fri, Apr 28, 2017 at 11:35 AM, Jan Ehrhardt wrote: > William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr 2017 10:30:03 > -0500): >>You might have missed my thought here... suggesting that the CMake >>not-so-experimental build become recommended for users who want to

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jan Ehrhardt
William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr 2017 10:30:03 -0500): >You might have missed my thought here... suggesting that the CMake >not-so-experimental build become recommended for users who want to >build all the modules in one go including the new mod_brotli. People like

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Steffen
cvtdsp.pl is not a hassle, just a easy step. Quote: you should not need cvtdsp.pl -2005 with VC14. They fixed this in the conversion. You mentioned majority. Nope: a majority now provide a cmake option. Bottom line is that I and quite some fellows are sticking with the GUI/dsw/dsp/mak. Oh

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Steffen
Accurate: I only/must use cmake with pcre and brotli, rest/most is make. No cmake *majority*. > Op 28 apr. 2017 om 18:45 heeft William A Rowe Jr het > volgende geschreven: > >> On Fri, Apr 28, 2017 at 11:35 AM, Jan Ehrhardt wrote: >> William A

Re: The drive for 2.4.26

2017-04-28 Thread Steffen
When with apr & apr-until 1.6 fine even more cooler. Otherwise OpenSSL 1.1 not supported. For OpenSSL 1.1 we need apr & apr-util 1.6 to build (e.g apr_crypto_openssl for mod_session crypto) > Op 28 apr. 2017 om 14:14 heeft Jim Jagielski het volgende > geschreven: > >

Re: The drive for 2.4.26

2017-04-28 Thread William A Rowe Jr
Now that these are independent of one another, I think we can release before 1.6.x are released. We should just call out "New: OpenSSL 1.1.0 support! (Upcoming APR 1.6.x is required for this support.) On Apr 28, 2017 2:56 PM, "Steffen" wrote: > When with apr & apr-until

Re: The drive for 2.4.26

2017-04-28 Thread Steffen
I doubt now. It was based on a note in cvtdsp.pl. Maybe it is only a .dsp and xml change, which I can apply to 1.5. Maybe Gregg can shed some light on this ? > Op 28 apr. 2017 om 22:16 heeft William A Rowe Jr het > volgende geschreven: > > Now that these are

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
On Apr 28, 2017 2:40 PM, "Steffen" wrote: cvtdsp.pl is not a hassle, just a easy step. Quote: you should not need cvtdsp.pl -2005 with VC14. They fixed this in the conversion. Terrific, this is verified?!? Otherwise there is no requirement for a Windows build to have

Re: svn commit: r1707087 - /httpd/httpd/trunk/modules/debugging/mod_bucketeer.c

2017-04-28 Thread Jacob Champion
On 04/27/2017 02:46 AM, Yann Ylavic wrote: Jacob, does it work better? Unfortunately not; now we have crashes in mod_case_filter. If you're having trouble reproducing a crash, try using an APR with pool debugging enabled. The poisoned-on-free memory is showing up really nicely. I ask

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jan Ehrhardt
Jim Jagielski in gmane.comp.apache.devel (Fri, 28 Apr 2017 09:29:01 -0400): >Are these issues with *building* the brotli library during >the configure/make of httpd? No, building the brotli library itself is a CMake thing. Something like CMake -G "Visual Studio 14 2015 Win64"

Re: The drive for 2.4.26

2017-04-28 Thread Jim Jagielski
It would be cool to have 2.4.26 released by ApacheCon, or even by OSCON. There are, last I checked, 2 showstoppers on list for 2.4.26... Anyway we could address them and shoot for a T maybe next Weds?

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jan Ehrhardt
Hi Gregg, Gregg Smith in gmane.comp.apache.devel (Tue, 25 Apr 2017 18:23:50 -0700): >Actually, I'll test here in a while and commit tomorrow. Quote from modules/filters/mod_brotli.dsp > +# ADD LINK32 kernel32.lib brotlicommon.lib brotlienc.lib /nologo > /subsystem:windows /dll /incremental:no

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jim Jagielski
This just clicked for me... Are these issues with *building* the brotli library during the configure/make of httpd? Why, exactly, are we doing this if this is, in fact, what we are doing? Just curious why we are taking this dependency on directly. > On Apr 28, 2017, at 9:19 AM, Jan Ehrhardt

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Steffen
This is a trigger again for the old repeating discussion. Cmake is a way to go. IDE building is the preferred way to go, all the vs goodies then available. And easy to maintain dsw and dsp etc. > Op 28 apr. 2017 om 16:55 heeft William A Rowe Jr het > volgende

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
Jan, That is correct. The .dsp is wired to interrelated projects via the .dsw file. Exporting the projects into .mak files causes all the 'depends upon' libs to be added. See any other such as mod_status. If we were building brotli in-tree you would add the libbrotli .dsp and it would resolve

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
Hmmm... Building brotli libs requires CMake. Perhaps only support building mod_brotli through the CMake build, and not the legacy build?

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jim Jagielski
OK, thx for clearing that up. Cheers! > On Apr 28, 2017, at 9:50 AM, Jan Ehrhardt wrote: > > Jim Jagielski in gmane.comp.apache.devel (Fri, 28 Apr 2017 09:29:01 > -0400): >> Are these issues with *building* the brotli library during >> the configure/make of httpd? > > No,

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jan Ehrhardt
William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr 2017 09:57:53 -0500): >Hmmm... > >Building brotli libs requires CMake. > >Perhaps only support building mod_brotli through the CMake build, and not >the legacy build? That would be not very convenient if you want to build Apache with all

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Steffen
Agree. Thanks to Gregg, dsp/dsw/makefile mod_brotli is already there in branches 2.4.x. Cmake only needed to build the brotli libs. > Op 28 apr. 2017 om 17:05 heeft Jan Ehrhardt het volgende > geschreven: > > William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread William A Rowe Jr
On Fri, Apr 28, 2017 at 10:05 AM, Jan Ehrhardt wrote: > William A Rowe Jr in gmane.comp.apache.devel (Fri, 28 Apr 2017 09:57:53 > -0500): >>Hmmm... >> >>Building brotli libs requires CMake. >> >>Perhaps only support building mod_brotli through the CMake build, and not >>the

Re: svn commit: r1792912 - in /httpd/httpd/branches/2.4.x/modules/filters: mod_brotli.dsp mod_brotli.mak

2017-04-28 Thread William A Rowe Jr
Wouldn't there be a corresponding change to LIBPATH? On Thu, Apr 27, 2017 at 10:17 AM, wrote: > Author: gsmith > Date: Thu Apr 27 15:17:57 2017 > New Revision: 1792912 > > URL: http://svn.apache.org/viewvc?rev=1792912=rev > Log: > Per brotli-master include will move in

Re: mod_brotli in 2.4.x is missing a few Makefile changes

2017-04-28 Thread Jacob Champion
On 04/28/2017 08:08 AM, Steffen wrote: Cmake is a way to go. IDE building is the preferred way to go, all the vs goodies then available. And easy to maintain dsw and dsp etc. Does CMake not provide the nice IDE goodies on your machine? I'm quite happy with it for mod_websocket, and not at