signals for workers

2018-01-17 Thread Stefan Eissing
Hej Yann, could you briefly scan https://bz.apache.org/bugzilla/show_bug.cgi?id=62009 and let me know if the proposed workaround sounds reasonable? It sounds correct that h2 workers should mask these signals so that mpm threads can handle them properly. Thanks, Stefan

Re: signals for workers

2018-01-17 Thread Eric Covener
On Wed, Jan 17, 2018 at 10:52 AM, Stefan Eissing wrote: > Hej Yann, > > could you briefly scan https://bz.apache.org/bugzilla/show_bug.cgi?id=62009 > and let me > know if the proposed workaround sounds reasonable? It sounds correct that h2 > workers > should mask

Re: signals for workers

2018-01-17 Thread Yann Ylavic
On Wed, Jan 17, 2018 at 5:17 PM, Eric Covener wrote: > On Wed, Jan 17, 2018 at 10:52 AM, Stefan Eissing > wrote: >> Hej Yann, >> >> could you briefly scan https://bz.apache.org/bugzilla/show_bug.cgi?id=62009 >> and let me >> know if the proposed

Re: signals for workers

2018-01-17 Thread Yann Ylavic
On Wed, Jan 17, 2018 at 6:19 PM, Yann Ylavic wrote: > > we are less protected against child_init() > threads that would steal "our" MPM signals though, their bug IMO. Scratch that, child_init() threads can do this after or before apr_setup_signal_thread(), the difference is

Re: can we haz backports?

2018-01-17 Thread William A Rowe Jr
On Wed, Jan 17, 2018 at 4:18 AM, Stefan Eissing wrote: > >> Am 17.01.2018 um 10:45 schrieb Yann Ylavic : >> >> On Wed, Jan 17, 2018 at 10:30 AM, Stefan Eissing >> wrote: >>> Am 16.01.2018 um 21:26 schrieb

Re: signals for workers

2018-01-17 Thread Eric Covener
>> Maybe h2 could just call this on each new thread, but not the >> primordial one child_init runs directly on? > > Or the MPM block signal before child_init(), it is usefull to create > threads from there w/o boring with masks... I was being paranoid about breaking someone, but that doesn't

Re: signals for workers

2018-01-17 Thread Yann Ylavic
On Wed, Jan 17, 2018 at 6:14 PM, Eric Covener wrote: >>> Maybe h2 could just call this on each new thread, but not the >>> primordial one child_init runs directly on? >> >> Or the MPM block signal before child_init(), it is usefull to create >> threads from there w/o boring

Re: can we haz backports?

2018-01-17 Thread Stefan Eissing
> Am 17.01.2018 um 10:45 schrieb Yann Ylavic : > > On Wed, Jan 17, 2018 at 10:30 AM, Stefan Eissing > wrote: >> >>> Am 16.01.2018 um 21:26 schrieb William A Rowe Jr : >>> >>> Color me very confused, but I can't

Re: can we haz backports?

2018-01-17 Thread Stefan Eissing
> Am 16.01.2018 um 21:26 schrieb William A Rowe Jr : > > Color me very confused, but I can't distinguish a difference between vhost > based > Host: header selection in the "http-01" case, and SNI identification > in the case of > "tls-sni-01". Am I missing something?

Re: can we haz backports?

2018-01-17 Thread Yann Ylavic
On Wed, Jan 17, 2018 at 10:30 AM, Stefan Eissing wrote: > >> Am 16.01.2018 um 21:26 schrieb William A Rowe Jr : >> >> Color me very confused, but I can't distinguish a difference between vhost >> based >> Host: header selection in the "http-01"