Re: h2 broken in 2.4.36 with OpenSSL 1.1.1? Related to SSL_MODE_AUTO_RETRY?

2018-10-16 Thread Rainer Jung
Hi Stefan, Joe and all, Am 16.10.2018 um 11:15 schrieb Joe Orton: On Mon, Oct 15, 2018 at 12:55:45PM +0200, Rainer Jung wrote: I'm currently testing the following patch which looks OK wrt. test suite results. Need to run more combinations (OpenSSL version client versus server) though. Server

Re: h2 broken in 2.4.36 with OpenSSL 1.1.1? Related to SSL_MODE_AUTO_RETRY?

2018-10-16 Thread Joe Orton
On Mon, Oct 15, 2018 at 12:55:45PM +0200, Rainer Jung wrote: > I'm currently testing the following patch which looks OK wrt. test suite > results. Need to run more combinations (OpenSSL version client versus > server) though. Server with 1.1.1 and with 1.0.2p both look OK (including > the h2

Re: t/modules/buffer.t failing in 2.4.36, LWP bug [Was: [VOTE] Release httpd-2.4.36]

2018-10-16 Thread Ruediger Pluem
On 10/14/2018 04:20 PM, Mark Blackman wrote: > > >> On 14 Oct 2018, at 12:33, Rainer Jung > > wrote: >> >> Am 13.10.2018 um 11:46 schrieb Rainer Jung: >>> Am 11.10.2018 um 20:55 schrieb Ruediger Pluem: On 10/11/2018 08:10 PM, Christophe JAILLET

Re: svn commit: r1844001 - in /httpd/httpd/trunk/modules/ssl: mod_ssl.c ssl_engine_kernel.c ssl_private.h

2018-10-16 Thread Ruediger Pluem
On 10/16/2018 02:53 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Tue Oct 16 12:53:18 2018 > New Revision: 1844001 > > URL: http://svn.apache.org/viewvc?rev=1844001=rev > Log: > And a way to custom modules to guess and extract ssl variable. > See https://github.com/jfclere/JBCSP-17

Re: h2 broken in 2.4.36 with OpenSSL 1.1.1? Related to SSL_MODE_AUTO_RETRY?

2018-10-16 Thread Stefan Eissing
> Am 15.10.2018 um 23:16 schrieb Rainer Jung : > > Adjusted SSL_read() rc value 0 handling applied in r1843954 to trunk. I'll > let it sit there until tomorrow for comments and then suggest for backport. Thanks, Rainer! The h2 test suite runs as smoothly as it did before on my machine with

Re: svn commit: r1841225 - /httpd/httpd/trunk/modules/dav/main/props.c

2018-10-16 Thread Ruediger Pluem
Gentle ping :-). Did you find some time to have a look? Regards Rüdiger On 09/25/2018 06:37 PM, Greg Stein wrote: > We learned a lot about pool handling while writing Subversion, after I wrote > that mod_dav code. There are definite some > improvements to be made. I'm not surprised that a

Recommendation for adding APLOGNO() before string format which is passed to ap_log_cerror()

2018-10-16 Thread 牛旭
Our team works on enhance logging practices by learning from historical log revisions in evolution. By mining historical patches, we find two patches that both add APLOGNO(*) before the format string which is then passed to ap_log_cerror(). However, when apply this rule to httpd-2.4.27, we

Re: svn commit: r1843478 - /httpd/test/framework/trunk/t/ssl/ocsp.t

2018-10-16 Thread William A Rowe Jr
To button this issue up, it's clear to me that Jim had transposed the meaning of result values from posix commands, and that was the origin of irrationality in this discussion. Beyond the misunderstanding, the actual behavior of openssl in 1.0.x and prior was inane, and led to Jim's confusion,