ssl memory leak, PR 63687

2020-04-15 Thread Stefan Eissing
In regard to https://bz.apache.org/bugzilla/show_bug.cgi?id=63687 there are now 2 patches, varying in style but fixing the very same missing free. My attempt uses gotos to have a single point of exit where to free things, while Giovanni Bechis provided a changed version that frees on all

Re: ssl memory leak, PR 63687

2020-04-15 Thread Yann Ylavic
On Wed, Apr 15, 2020 at 10:11 AM Stefan Eissing wrote: > > Obviously, I nowadays prefer the goto/single exit style myself, but the rest > of the module is different. +1, cleanup in each early return is easier to get wrong IMHO. In your patch I'd rename the "leave" label to "cleanup" though, to

Re: ssl memory leak, PR 63687

2020-04-15 Thread Stefan Eissing
+1. I like it. > Am 15.04.2020 um 13:36 schrieb Yann Ylavic : > >

Re: ssl memory leak, PR 63687

2020-04-15 Thread Yann Ylavic
On Wed, Apr 15, 2020 at 1:18 PM Yann Ylavic wrote: > > In this particular patch, setting "rv" and using a single label may be > an option too. Something like this for each goto: >rv = 0|1; >goto cleanup; > ? Would look like the attached, FWIW.. Index: modules/ssl/ssl_util_stapling.c

Re: ssl memory leak, PR 63687

2020-04-15 Thread Ruediger Pluem
Me too. +1. Regards Rüdiger On 4/15/20 1:38 PM, Stefan Eissing wrote: > +1. I like it. > >> Am 15.04.2020 um 13:36 schrieb Yann Ylavic : >> >> > >

Re: ssl memory leak, PR 63687

2020-04-15 Thread Giovanni Bechis
Il 15 aprile 2020 13:36:05 CEST, Yann Ylavic ha scritto: >On Wed, Apr 15, 2020 at 1:18 PM Yann Ylavic >wrote: >> >> In this particular patch, setting "rv" and using a single label may >be >> an option too. Something like this for each goto: >>rv = 0|1; >>goto cleanup; >> ? > >Would look

Re: ssl memory leak, PR 63687

2020-04-15 Thread Yann Ylavic
On Wed, Apr 15, 2020 at 1:08 PM Yann Ylavic wrote: > > On Wed, Apr 15, 2020 at 10:11 AM Stefan Eissing > wrote: > > > > Obviously, I nowadays prefer the goto/single exit style myself, but the > > rest of the module is different. > > +1, cleanup in each early return is easier to get wrong IMHO.

Re: SSLStrictSNIVHostCheck not being enforced by mod_ssl

2020-04-15 Thread Frank
You defined the vhost incorrectly to begin with. Do not use a hostname in the definition. Use *:443 or IP:443 if you must. Then, re-run apachectl -S to see your defined vhosts. On 15/04/20 06:41 PM, Alex Hautequest wrote: > This is the very first VirtualHost entry on the HTTPD configuration >

Re: mod_http2 crashes libhttpd.dll in 2.4.43

2020-04-15 Thread mdrmdr
Added some more information to: https://www.apachelounge.com/viewtopic.php?p=39047#39047 And offered to run httpd again with GDB once someone points me to .43 symbol files... -- Sent from: http://apache-http-server.18135.x6.nabble.com/Apache-HTTP-Server-Dev-f4771363.html

Re: svn commit: r1876511 - /httpd/httpd/trunk/modules/core/mod_watchdog.c

2020-04-15 Thread Jim Jagielski
very, very elegant. > On Apr 14, 2020, at 8:37 AM, jor...@apache.org wrote: > > Author: jorton > Date: Tue Apr 14 12:37:17 2020 > New Revision: 1876511 > > URL: http://svn.apache.org/viewvc?rev=1876511=rev > Log: > * modules/core/mod_watchdog.c: Switch to simpler logic to avoid the > thread

Re: Building from svn on MacOS

2020-04-15 Thread Jim Jagielski
I always have svn co of apr and apr-util in srclib when I build from SVN

Re: ssl memory leak, PR 63687

2020-04-15 Thread Yann Ylavic
On Wed, Apr 15, 2020 at 2:06 PM Giovanni Bechis wrote: > > Il 15 aprile 2020 13:36:05 CEST, Yann Ylavic ha > scritto: > >On Wed, Apr 15, 2020 at 1:18 PM Yann Ylavic > >wrote: > >> > >> In this particular patch, setting "rv" and using a single label may > >be > >> an option too. Something like