RE: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Hi Bill, Thanks for your comments and explanation on the procedure. If you have time, please take some time to review this patch and let me know if you see any issues. Thanks, Yingqi -Original Message- From: William A. Rowe Jr. [mailto:[email protected]] Sent: Monday, January 26, 2015 10:56 AM To: Lu, Yingqi Cc: [email protected] Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) On Thu, 22 Jan 2015 18:08:20 + "Lu, Yingqi" wrote: > Hi Jim, > > Thanks for the update! > > A quick question on the review and testing procedure. Right now, Yann > Ylavic already made available a 2.4 version of the patch. The link is > included at http://svn.apache.org/r1651967 . Is this good enough or is > there anything additional needed at this point? If there is no bug > reported, when 2.4.13 time is approaching, the patch will > automatically be on the commit list or is there anything else we need > to make sure? > > Thanks, > Yingqi > > -Original Message- > From: Jim Jagielski [mailto:[email protected]] > Sent: Thursday, January 22, 2015 9:37 AM > To: [email protected] > Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) > > Since that was a very new patch, there was a risk in adding it to > 2.4.11/12 since it would not have had enough time for adequate > testing. It will be proposed for 2.4.13. Yingqi, a patch of this scale is generally added to the branch early, once three committers have had a chance to review it. By living on the 2.4 branch for some time (long before 2.4.13 is considered for release) we have the best chance of catching a problem between now and the release of 2.4.13. It would be just as unlikely to be added just before 2.4.13 is tagged because that doesn't give enough of the community time to review it. Yours, Bill
Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
On Thu, 22 Jan 2015 18:08:20 + "Lu, Yingqi" wrote: > Hi Jim, > > Thanks for the update! > > A quick question on the review and testing procedure. Right now, Yann > Ylavic already made available a 2.4 version of the patch. The link is > included at http://svn.apache.org/r1651967 . Is this good enough or > is there anything additional needed at this point? If there is no bug > reported, when 2.4.13 time is approaching, the patch will > automatically be on the commit list or is there anything else we need > to make sure? > > Thanks, > Yingqi > > -Original Message- > From: Jim Jagielski [mailto:[email protected]] > Sent: Thursday, January 22, 2015 9:37 AM > To: [email protected] > Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) > > Since that was a very new patch, there was a risk in adding it to > 2.4.11/12 since it would not have had enough time for adequate > testing. It will be proposed for 2.4.13. Yingqi, a patch of this scale is generally added to the branch early, once three committers have had a chance to review it. By living on the 2.4 branch for some time (long before 2.4.13 is considered for release) we have the best chance of catching a problem between now and the release of 2.4.13. It would be just as unlikely to be added just before 2.4.13 is tagged because that doesn't give enough of the community time to review it. Yours, Bill
RE: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Hi Yann, Thanks for your explanation. Now, I understand it much better :-) Everyone, please take some time to review our SO_REUSEPORT patch and let us know your feedback. Thanks, Yingqi -Original Message- From: Yann Ylavic [mailto:[email protected]] Sent: Friday, January 23, 2015 4:04 AM To: httpd Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) Hi Yingqi, On Thu, Jan 22, 2015 at 7:08 PM, Lu, Yingqi wrote: > > A quick question on the review and testing procedure. Right now, Yann Ylavic > already made available a 2.4 version of the patch. The link is included at > http://svn.apache.org/r1651967 . Is this good enough or is there anything > additional needed at this point? If there is no bug reported, when 2.4.13 > time is approaching, the patch will automatically be on the commit list or is > there anything else we need to make sure? The 2.4.x backport proposal needs 3 committers positive reviews (votes) to be accepted and included in 2.4.x. I already added my +1 for it, we just now have to wait for 2 more ones (without any -1)... Regards, Yann.
Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Hi Yingqi, On Thu, Jan 22, 2015 at 7:08 PM, Lu, Yingqi wrote: > > A quick question on the review and testing procedure. Right now, Yann Ylavic > already made available a 2.4 version of the patch. The link is included at > http://svn.apache.org/r1651967 . Is this good enough or is there anything > additional needed at this point? If there is no bug reported, when 2.4.13 > time is approaching, the patch will automatically be on the commit list or is > there anything else we need to make sure? The 2.4.x backport proposal needs 3 committers positive reviews (votes) to be accepted and included in 2.4.x. I already added my +1 for it, we just now have to wait for 2 more ones (without any -1)... Regards, Yann.
RE: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Hi Jim, Thanks for the update! A quick question on the review and testing procedure. Right now, Yann Ylavic already made available a 2.4 version of the patch. The link is included at http://svn.apache.org/r1651967 . Is this good enough or is there anything additional needed at this point? If there is no bug reported, when 2.4.13 time is approaching, the patch will automatically be on the commit list or is there anything else we need to make sure? Thanks, Yingqi -Original Message- From: Jim Jagielski [mailto:[email protected]] Sent: Thursday, January 22, 2015 9:37 AM To: [email protected] Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) Since that was a very new patch, there was a risk in adding it to 2.4.11/12 since it would not have had enough time for adequate testing. It will be proposed for 2.4.13. > On Jan 22, 2015, at 12:14 PM, Lu, Yingqi wrote: > > Hi Jim, > > Is the SO_REUSPORT patch committed in this build? > > Thanks, > Lucy > > -Original Message- > From: Jim Jagielski [mailto:[email protected]] > Sent: Thursday, January 22, 2015 3:43 AM > To: [email protected] > Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) > > I expect to T&R around 1pm eastern... all code and patches expected to be in > 2.4.12 are currently committed. No further changes expected.
Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Since that was a very new patch, there was a risk in adding it to 2.4.11/12 since it would not have had enough time for adequate testing. It will be proposed for 2.4.13. > On Jan 22, 2015, at 12:14 PM, Lu, Yingqi wrote: > > Hi Jim, > > Is the SO_REUSPORT patch committed in this build? > > Thanks, > Lucy > > -Original Message- > From: Jim Jagielski [mailto:[email protected]] > Sent: Thursday, January 22, 2015 3:43 AM > To: [email protected] > Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) > > I expect to T&R around 1pm eastern... all code and patches expected to be in > 2.4.12 are currently committed. No further changes expected.
RE: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Hi Jim, Is the SO_REUSPORT patch committed in this build? Thanks, Lucy -Original Message- From: Jim Jagielski [mailto:[email protected]] Sent: Thursday, January 22, 2015 3:43 AM To: [email protected] Subject: Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22) I expect to T&R around 1pm eastern... all code and patches expected to be in 2.4.12 are currently committed. No further changes expected.
Re: [NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
I expect to T&R around 1pm eastern... all code and patches expected to be in 2.4.12 are currently committed. No further changes expected.
[NOTICE] Intend to T&R 2.4.12 tomorrow (Thurs, Jan 22)
Just a heads-up.
