Re: [PATCH] mod_cache fixes: #6

2004-08-03 Thread Ian Holsman
Justin Erenkrantz wrote: --On Monday, August 2, 2004 11:44 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: These are debug messages so not sure why they are a problem. +0 The logging code is expensive to call for every request like that as many times as it does. IMHO, there's no benefit to

Re: [PATCH] mod_cache fixes: #6

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_cache.c: Reduce logging in mainline case. These

Re: [PATCH] mod_cache fixes: #6

2004-08-02 Thread Graham Leggett
Bill Stoddard wrote: * modules/experimental/mod_cache.c: Reduce logging in mainline case. These are debug messages so not sure why they are a problem. While mod_cache is experimental, it may help to have more logging rather than less. Are the logging functions that much of a performance problem

Re: [PATCH] mod_cache fixes: #6

2004-08-02 Thread Jeff Trawick
On Mon, 02 Aug 2004 18:13:09 +0200, Graham Leggett [EMAIL PROTECTED] wrote: Bill Stoddard wrote: * modules/experimental/mod_cache.c: Reduce logging in mainline case. These are debug messages so not sure why they are a problem. While mod_cache is experimental, it may help to have more

Re: [PATCH] mod_cache fixes: #6

2004-08-02 Thread Justin Erenkrantz
--On Monday, August 2, 2004 11:44 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: These are debug messages so not sure why they are a problem. +0 The logging code is expensive to call for every request like that as many times as it does. IMHO, there's no benefit to such a verbose log. More

[PATCH] mod_cache fixes: #6

2004-08-01 Thread Justin Erenkrantz
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_cache.c: Reduce logging in mainline case. Index: