Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-07-12 Thread Yann Ylavic
On Tue, Jul 12, 2022 at 12:46 PM Ivan Zhakov wrote: > > On Wed, 29 Jun 2022 at 01:28, Yann Ylavic wrote: > > > > On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > > > > > > I meant a memory leak for native threads. For example, with an MPM > > > that uses native Windows threadpool for

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-07-12 Thread Ivan Zhakov via dev
On Wed, 29 Jun 2022 at 01:28, Yann Ylavic wrote: > > On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > > > On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > > > > > Hi Ivan, > > > > > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > > > > > For the longer version, let me

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-28 Thread Yann Ylavic
On Tue, Jun 28, 2022 at 6:08 PM Ivan Zhakov wrote: > > On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > > > Hi Ivan, > > > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > > > For the longer version, let me first outline a few problems with the > > > current

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-28 Thread Ivan Zhakov
On Tue, 28 Jun 2022 at 00:24, Yann Ylavic wrote: > > Hi Ivan, > > On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > > > For the longer version, let me first outline a few problems with the > > current apr_thread_current() API: > > > > 1) apr_thread_current_create() leaks the memory

Re: Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-27 Thread Yann Ylavic
Hi Ivan, On Mon, Jun 27, 2022 at 8:19 PM Ivan Zhakov wrote: > > For the longer version, let me first outline a few problems with the current > apr_thread_current() API: > > 1) apr_thread_current_create() leaks the memory allocated in alloc_thread() > after the thread exits. Hm, alloc_thread()

Issues with shipping apr_thread_current() in APR 1.8.0 and an alternative approach for PCRE2 allocations in HTTPD

2022-06-27 Thread Ivan Zhakov
Hi, I have some concerns about the apr_thread_current() functionality that is a part of the APR 1.8.x branch, but is not yet released. The short version is: I think that the apr_thread_current() API has multiple problems and that shipping it in 1.8.0 in its current state would be a mistake. As