Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Rainer Jung]

Thanks to you for the help and patience anfd for maintaing Travis!

Regards,

Rainer

Am 25.03.2020 um 16:15 schrieb Joe Orton:

On Wed, Mar 25, 2020 at 11:20:32AM +0100, Rainer Jung wrote:

And now I notice that's of course not appropriate (everone needing to change
the call to the Makefile. So I will add local defaults in the spirit of your
below suggestion into Makefile.PL.


Thanks a lot, looks good now with r1875640!

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Joe Orton]

On Wed, Mar 25, 2020 at 11:20:32AM +0100, Rainer Jung wrote:
> And now I notice that's of course not appropriate (everone needing to change
> the call to the Makefile. So I will add local defaults in the spirit of your
> below suggestion into Makefile.PL.

Thanks a lot, looks good now with r1875640!

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Rainer Jung]

Am 25.03.2020 um 11:06 schrieb Joe Orton:

On Tue, Mar 24, 2020 at 11:35:38PM +0100, Rainer Jung wrote:

Excellent. That gave me the right idea where to look at.

I found a way to pass additionals args inside Makefile.PL into
Apache::TestMM::Argv which get automatically added to $vars in
Apache::TestConfig. It seems to work well. Committed in r1875598.


Doesn't seem to work for me or in Travis -

https://travis-ci.org/github/apache/httpd/jobs/06723#L2462

I don't up with with any Argv defined for limitrequestline if either
passing -apxs to Makefile.PL or not passing any argv.


Sorry, I forgot: we have to run the Makefile with

perl ./Makefile.PL -apxs foo -limitrequestline 128 -limitrequestlinex2 256

And now I notice that's of course not appropriate (everone needing to 
change the call to the Makefile. So I will add local defaults in the 
spirit of your below suggestion into Makefile.PL.


Regards,

Rainer


starting w/below patch applied:

sh-5.0$ perl ./Makefile.PL -apxs foo &> /dev/null
sh-5.0$ grep Argv t/TEST
$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
$Apache::TestConfig::Argv{'apxs'} = q|foo|;
$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
sh-5.0$ svn revert Makefile.PL
Reverted 'Makefile.PL'
sh-5.0$ perl ./Makefile.PL -apxs foo &> /dev/null
sh-5.0$ grep Argv t/TEST
$Apache::TestConfig::Argv{'apxs'} = q|foo|;


Index: Makefile.PL
===
--- Makefile.PL (revision 1875618)
+++ Makefile.PL (working copy)
@@ -28,13 +28,12 @@
  # supported in an Apache::Test release.
  # Code borrowed from Apache::TestMM::filter_args().
  my %local_args = (
-limitrequestline => 'Value for LimitRequestLine',
-limitrequestlinex2 => 'Twice the value for LimitRequestLine',
+limitrequestline => '128',
+limitrequestlinex2 => '256',
  );
-my($argv, $vars) = Apache::TestConfig::filter_args(\@ARGV, \%local_args);
-@ARGV = @$argv;
-push(@Apache::TestMM::Argv, %$vars);
  
+push(@Apache::TestMM::Argv, %local_args);

+
  for my $script (@scripts) {
  Apache::TestMM::generate_script($script);
  }





Thanks and regards,

Rainer

Am 24.03.2020 um 18:35 schrieb Joe Ortqon:

On Tue, Mar 24, 2020 at 05:55:20PM +0100, Rainer Jung wrote:

I've got the following problem: I want to use a new config var in
Apache::Test as a patern to replace in extra.conf.in. I added the bvar to
Apache::Test::Config, but it seems Travis uses only a released version of
Apache::Test. Is there a way of influencing Apache::Test early from our own
scripts, so that I can set a default value for the new var?


This is the downside of relying on a released Apache::Test :(

If we can patch t/TEST I think we can set the defaults.  Not sure
if there is a clean way to do it but Makefile.PL is generating the file
so it's possible in theory.

If I apply this then ./t/TEST runs again with external Apache::Test

--- t/TEST~ 2020-03-12 11:46:26.823610447 +
+++ t/TEST  2020-03-24 17:31:43.225348563 +
@@ -9,6 +9,8 @@
   BEGIN { eval { require blib && blib->import; } }
   $Apache::TestConfig::Argv{'apxs'} = 
q|/home/jorton/src/asf/httpd-git/check/bin/apxs|;
+$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
+$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
   use strict;
   use warnings FATAL => 'all';
@@ -19,4 +21,4 @@
   );
-use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);
\ No newline at end of file
+use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);







Error message:

[  error] configure() has failed:

invalid token: @limitrequestline@ in file
/home/travis/build/apache/httpd/test/perl-framework/t/conf/extra.conf.in

I introduces the new variable in extra.conf.in in r1875569 and the needed
code in Apache::TestConfig in r1875568.

Any help welcome. Otherwise I will revert and run with local modifications.

Thanks and regards,

Rainer

Am 24.03.2020 um 14:30 schrieb Travis CI:

apache

/

httpd




branch icon2.4.x 

build has failed
Build #515 was broken 

arrow to build time
clock icon9 mins and 52 secs

Jim Jagielski avatarJim Jagielski

e936ddc CHANGESET →


2.4.42 was DOA


git-svn-id:
https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875576
13f79535-47bb-0310-9956-ffa450edef68

Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you!

SIGN UP HERE 

book icon

Documentation  about Travis CI

Have any questions? We're here to help. 
Unsubscribe 

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Joe Orton]

On Tue, Mar 24, 2020 at 11:35:38PM +0100, Rainer Jung wrote:
> Excellent. That gave me the right idea where to look at.
> 
> I found a way to pass additionals args inside Makefile.PL into
> Apache::TestMM::Argv which get automatically added to $vars in
> Apache::TestConfig. It seems to work well. Committed in r1875598.

Doesn't seem to work for me or in Travis -

https://travis-ci.org/github/apache/httpd/jobs/06723#L2462

I don't up with with any Argv defined for limitrequestline if either 
passing -apxs to Makefile.PL or not passing any argv.

starting w/below patch applied:

sh-5.0$ perl ./Makefile.PL -apxs foo &> /dev/null 
sh-5.0$ grep Argv t/TEST 
$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
$Apache::TestConfig::Argv{'apxs'} = q|foo|;
$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
sh-5.0$ svn revert Makefile.PL 
Reverted 'Makefile.PL'
sh-5.0$ perl ./Makefile.PL -apxs foo &> /dev/null 
sh-5.0$ grep Argv t/TEST 
$Apache::TestConfig::Argv{'apxs'} = q|foo|;


Index: Makefile.PL
===
--- Makefile.PL (revision 1875618)
+++ Makefile.PL (working copy)
@@ -28,13 +28,12 @@
 # supported in an Apache::Test release.
 # Code borrowed from Apache::TestMM::filter_args().
 my %local_args = (
-limitrequestline => 'Value for LimitRequestLine',
-limitrequestlinex2 => 'Twice the value for LimitRequestLine',
+limitrequestline => '128',
+limitrequestlinex2 => '256',
 );
-my($argv, $vars) = Apache::TestConfig::filter_args(\@ARGV, \%local_args);
-@ARGV = @$argv;
-push(@Apache::TestMM::Argv, %$vars);
 
+push(@Apache::TestMM::Argv, %local_args);
+
 for my $script (@scripts) {
 Apache::TestMM::generate_script($script);
 }



> 
> Thanks and regards,
> 
> Rainer
> 
> Am 24.03.2020 um 18:35 schrieb Joe Ortqon:
> > On Tue, Mar 24, 2020 at 05:55:20PM +0100, Rainer Jung wrote:
> > > I've got the following problem: I want to use a new config var in
> > > Apache::Test as a patern to replace in extra.conf.in. I added the bvar to
> > > Apache::Test::Config, but it seems Travis uses only a released version of
> > > Apache::Test. Is there a way of influencing Apache::Test early from our 
> > > own
> > > scripts, so that I can set a default value for the new var?
> > 
> > This is the downside of relying on a released Apache::Test :(
> > 
> > If we can patch t/TEST I think we can set the defaults.  Not sure
> > if there is a clean way to do it but Makefile.PL is generating the file
> > so it's possible in theory.
> > 
> > If I apply this then ./t/TEST runs again with external Apache::Test
> > 
> > --- t/TEST~ 2020-03-12 11:46:26.823610447 +
> > +++ t/TEST  2020-03-24 17:31:43.225348563 +
> > @@ -9,6 +9,8 @@
> >   BEGIN { eval { require blib && blib->import; } }
> >   $Apache::TestConfig::Argv{'apxs'} = 
> > q|/home/jorton/src/asf/httpd-git/check/bin/apxs|;
> > +$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
> > +$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
> >   use strict;
> >   use warnings FATAL => 'all';
> > @@ -19,4 +21,4 @@
> >   );
> > -use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);
> > \ No newline at end of file
> > +use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);
> > 
> > 
> > 
> > 
> > 
> > > 
> > > Error message:
> > > 
> > > [  error] configure() has failed:
> > > 
> > > invalid token: @limitrequestline@ in file
> > > /home/travis/build/apache/httpd/test/perl-framework/t/conf/extra.conf.in
> > > 
> > > I introduces the new variable in extra.conf.in in r1875569 and the needed
> > > code in Apache::TestConfig in r1875568.
> > > 
> > > Any help welcome. Otherwise I will revert and run with local 
> > > modifications.
> > > 
> > > Thanks and regards,
> > > 
> > > Rainer
> > > 
> > > Am 24.03.2020 um 14:30 schrieb Travis CI:
> > > > apache
> > > > 
> > > > /
> > > > 
> > > > httpd
> > > > 
> > > > 
> > > > 
> > > > 
> > > > branch icon2.4.x 
> > > > 
> > > > build has failed
> > > > Build #515 was broken 
> > > > 
> > > > arrow to build time
> > > > clock icon9 mins and 52 secs
> > > > 
> > > > Jim Jagielski avatarJim Jagielski
> > > > 
> > > > e936ddc CHANGESET →
> > > > 
> > > > 
> > > > 2.4.42 was DOA
> > > > 
> > > > 
> > > > git-svn-id:
> > > > https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875576
> > > > 13f79535-47bb-0310-9956-ffa450edef68
> > > > 
> > > > Want to know about upcoming build environment updates?
> > > > 
> > > > Would you like to stay up-to-date with the upcoming Travis CI build
> > > > environment updates? We set up a mailing list for you!
> > > > 
> > > > SIGN UP HERE 
> > > > 
> > > > book icon
> > > > 
> > > > Documentation 

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Rainer Jung]

Excellent. That gave me the right idea where to look at.

I found a way to pass additionals args inside Makefile.PL into 
Apache::TestMM::Argv which get automatically added to $vars in 
Apache::TestConfig. It seems to work well. Committed in r1875598.


Thanks and regards,

Rainer

Am 24.03.2020 um 18:35 schrieb Joe Ortqon:

On Tue, Mar 24, 2020 at 05:55:20PM +0100, Rainer Jung wrote:

I've got the following problem: I want to use a new config var in
Apache::Test as a patern to replace in extra.conf.in. I added the bvar to
Apache::Test::Config, but it seems Travis uses only a released version of
Apache::Test. Is there a way of influencing Apache::Test early from our own
scripts, so that I can set a default value for the new var?


This is the downside of relying on a released Apache::Test :(

If we can patch t/TEST I think we can set the defaults.  Not sure
if there is a clean way to do it but Makefile.PL is generating the file
so it's possible in theory.

If I apply this then ./t/TEST runs again with external Apache::Test

--- t/TEST~ 2020-03-12 11:46:26.823610447 +
+++ t/TEST  2020-03-24 17:31:43.225348563 +
@@ -9,6 +9,8 @@
  BEGIN { eval { require blib && blib->import; } }
  
  $Apache::TestConfig::Argv{'apxs'} = q|/home/jorton/src/asf/httpd-git/check/bin/apxs|;

+$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
+$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
  
  use strict;

  use warnings FATAL => 'all';
@@ -19,4 +21,4 @@
  );
  
  
-use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);

\ No newline at end of file
+use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);







Error message:

[  error] configure() has failed:

invalid token: @limitrequestline@ in file
/home/travis/build/apache/httpd/test/perl-framework/t/conf/extra.conf.in

I introduces the new variable in extra.conf.in in r1875569 and the needed
code in Apache::TestConfig in r1875568.

Any help welcome. Otherwise I will revert and run with local modifications.

Thanks and regards,

Rainer

Am 24.03.2020 um 14:30 schrieb Travis CI:

apache

/

httpd




branch icon2.4.x 

build has failed
Build #515 was broken 

arrow to build time
clock icon9 mins and 52 secs

Jim Jagielski avatarJim Jagielski

e936ddc CHANGESET →


2.4.42 was DOA


git-svn-id:
https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875576
13f79535-47bb-0310-9956-ffa450edef68

Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build
environment updates? We set up a mailing list for you!

SIGN UP HERE 

book icon

Documentation  about Travis CI

Have any questions? We're here to help. 
Unsubscribe 

from build emails from the apache/httpd repository.
To unsubscribe from *all* build emails, please update your settings 
.

black and white travis ci logo 

Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy
Jacops | Contact: cont...@travis-ci.com  |
Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß
§27 a Umsatzsteuergesetz: DE282002648

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Joe Ortqon]

On Tue, Mar 24, 2020 at 05:55:20PM +0100, Rainer Jung wrote:
> I've got the following problem: I want to use a new config var in
> Apache::Test as a patern to replace in extra.conf.in. I added the bvar to
> Apache::Test::Config, but it seems Travis uses only a released version of
> Apache::Test. Is there a way of influencing Apache::Test early from our own
> scripts, so that I can set a default value for the new var?

This is the downside of relying on a released Apache::Test :(

If we can patch t/TEST I think we can set the defaults.  Not sure 
if there is a clean way to do it but Makefile.PL is generating the file 
so it's possible in theory.

If I apply this then ./t/TEST runs again with external Apache::Test

--- t/TEST~ 2020-03-12 11:46:26.823610447 +
+++ t/TEST  2020-03-24 17:31:43.225348563 +
@@ -9,6 +9,8 @@
 BEGIN { eval { require blib && blib->import; } }
 
 $Apache::TestConfig::Argv{'apxs'} = 
q|/home/jorton/src/asf/httpd-git/check/bin/apxs|;
+$Apache::TestConfig::Argv{'limitrequestline'} = q|128|;
+$Apache::TestConfig::Argv{'limitrequestlinex2'} = q|256|;
 
 use strict;
 use warnings FATAL => 'all';
@@ -19,4 +21,4 @@
 );
 
 
-use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);
\ No newline at end of file
+use Apache::TestRun ();Apache::TestRun->new->run(@ARGV);





> 
> Error message:
> 
> [  error] configure() has failed:
> 
> invalid token: @limitrequestline@ in file
> /home/travis/build/apache/httpd/test/perl-framework/t/conf/extra.conf.in
> 
> I introduces the new variable in extra.conf.in in r1875569 and the needed
> code in Apache::TestConfig in r1875568.
> 
> Any help welcome. Otherwise I will revert and run with local modifications.
> 
> Thanks and regards,
> 
> Rainer
> 
> Am 24.03.2020 um 14:30 schrieb Travis CI:
> > apache
> > 
> > /
> > 
> > httpd
> > 
> > 
> > 
> > 
> > branch icon2.4.x 
> > 
> > build has failed
> > Build #515 was broken 
> > 
> > arrow to build time
> > clock icon9 mins and 52 secs
> > 
> > Jim Jagielski avatarJim Jagielski
> > 
> > e936ddc CHANGESET →
> > 
> > 
> > 2.4.42 was DOA
> > 
> > 
> > git-svn-id:
> > https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875576
> > 13f79535-47bb-0310-9956-ffa450edef68
> > 
> > Want to know about upcoming build environment updates?
> > 
> > Would you like to stay up-to-date with the upcoming Travis CI build
> > environment updates? We set up a mailing list for you!
> > 
> > SIGN UP HERE 
> > 
> > book icon
> > 
> > Documentation  about Travis CI
> > 
> > Have any questions? We're here to help. 
> > Unsubscribe 
> > 
> > from build emails from the apache/httpd repository.
> > To unsubscribe from *all* build emails, please update your settings 
> > .
> > 
> > black and white travis ci logo 
> > 
> > Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy
> > Jacops | Contact: cont...@travis-ci.com  |
> > Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß
> > §27 a Umsatzsteuergesetz: DE282002648
> 

Re: Broken: apache/httpd#515 (2.4.x - e936ddc)

[Rainer Jung]

I've got the following problem: I want to use a new config var in 
Apache::Test as a patern to replace in extra.conf.in. I added the bvar 
to Apache::Test::Config, but it seems Travis uses only a released 
version of Apache::Test. Is there a way of influencing Apache::Test 
early from our own scripts, so that I can set a default value for the 
new var?


Error message:

[  error] configure() has failed:

invalid token: @limitrequestline@ in file 
/home/travis/build/apache/httpd/test/perl-framework/t/conf/extra.conf.in


I introduces the new variable in extra.conf.in in r1875569 and the 
needed code in Apache::TestConfig in r1875568.


Any help welcome. Otherwise I will revert and run with local modifications.

Thanks and regards,

Rainer

Am 24.03.2020 um 14:30 schrieb Travis CI:

apache

/

httpd

 



branch icon2.4.x 

build has failed
Build #515 was broken 


arrow to build time
clock icon9 mins and 52 secs

Jim Jagielski avatarJim Jagielski

e936ddc CHANGESET → 



2.4.42 was DOA


git-svn-id: 
https://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x@1875576 
13f79535-47bb-0310-9956-ffa450edef68


Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build 
environment updates? We set up a mailing list for you!


SIGN UP HERE 

book icon

Documentation  about Travis CI

Have any questions? We're here to help. 
Unsubscribe 
 
from build emails from the apache/httpd repository.
To unsubscribe from *all* build emails, please update your settings 
. 


black and white travis ci logo 

Travis CI GmbH, Rigaer Str. 8, 10427 Berlin, Germany | GF/CEO: Randy 
Jacops | Contact: cont...@travis-ci.com  | 
Amtsgericht Charlottenburg, Berlin, HRB 140133 B | Umsatzsteuer-ID gemäß 
§27 a Umsatzsteuergesetz: DE282002648