Re: Memory usage, core output filter, and apr_brigade_destroy

2009-10-04 Thread Stefan Fritsch
Thanks for your comments. On Wednesday 23 September 2009, Ruediger Pluem wrote: --- modules/http/chunk_filter.c (Revision 818232) +++ modules/http/chunk_filter.c (Arbeitskopie) @@ -49,11 +49,11 @@ #define ASCII_CRLF \015\012 #define ASCII_ZERO \060 conn_rec *c = f-r-connection; -

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-10-04 Thread Ruediger Pluem
On 10/04/2009 09:37 AM, Stefan Fritsch wrote: Thanks for your comments. On Wednesday 23 September 2009, Ruediger Pluem wrote: What is the point here? tmp is always NULL when passed to apr_brigade_split_ex so apr_brigade_split_ex == apr_brigade_split You missed the tmp = b at the

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-23 Thread Ruediger Pluem
On 09/22/2009 09:19 PM, Stefan Fritsch wrote: On Sunday 13 September 2009, Stefan Fritsch wrote: On Sunday 13 September 2009, Ruediger Pluem wrote: On 09/13/2009 01:11 PM, Stefan Fritsch wrote: http://httpd.apache.org/docs/trunk/developer/output-filters.htm l recommends to reuse bucket

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-22 Thread Stefan Fritsch
On Sunday 13 September 2009, Stefan Fritsch wrote: On Sunday 13 September 2009, Ruediger Pluem wrote: On 09/13/2009 01:11 PM, Stefan Fritsch wrote: http://httpd.apache.org/docs/trunk/developer/output-filters.htm l recommends to reuse bucket brigades and to not use apr_brigade_destroy.

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-14 Thread Stefan Fritsch
On Sun, 13 Sep 2009, Ruediger Pluem wrote: But your patch is causing core dumps during the proxy tests when running the test suite :-(. I currently don't understand why. Hmmm... either ctx-tmp_flush_bb is NULL or, since it was added in the middle of the struct, you didn't do a make distclean

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-14 Thread Ruediger Pluem
On 09/14/2009 07:32 PM, Stefan Fritsch wrote: On Sun, 13 Sep 2009, Ruediger Pluem wrote: But your patch is causing core dumps during the proxy tests when running the test suite :-(. I currently don't understand why. Hmmm... either ctx-tmp_flush_bb is NULL or, since it was added in the

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-14 Thread Paul Querna
On Mon, Sep 14, 2009 at 12:48 PM, Ruediger Pluem rpl...@apache.org wrote: On 09/14/2009 07:32 PM, Stefan Fritsch wrote: On Sun, 13 Sep 2009, Ruediger Pluem wrote: But your patch is causing core dumps during the proxy tests when running the test suite :-(. I currently don't understand why.

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-14 Thread Ruediger Pluem
On 09/14/2009 10:29 PM, Paul Querna wrote: On Mon, Sep 14, 2009 at 12:48 PM, Ruediger Pluem rpl...@apache.org wrote: On 09/14/2009 07:32 PM, Stefan Fritsch wrote: On Sun, 13 Sep 2009, Ruediger Pluem wrote: But your patch is causing core dumps during the proxy tests when running the test

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-13 Thread Ruediger Pluem
On 09/13/2009 01:11 PM, Stefan Fritsch wrote: Hi, http://httpd.apache.org/docs/trunk/developer/output-filters.html recommends to reuse bucket brigades and to not use apr_brigade_destroy. However, both in 2.2 and in trunk, the core output filter sometimes calls apr_brigade_destroy on

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-13 Thread Jim Jagielski
On Sep 13, 2009, at 8:48 AM, Ruediger Pluem wrote: On 09/13/2009 01:11 PM, Stefan Fritsch wrote: Hi, http://httpd.apache.org/docs/trunk/developer/output-filters.html recommends to reuse bucket brigades and to not use apr_brigade_destroy. However, both in 2.2 and in trunk, the core

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-13 Thread Ruediger Pluem
On 09/13/2009 05:12 PM, Jim Jagielski wrote: On Sep 13, 2009, at 8:48 AM, Ruediger Pluem wrote: On 09/13/2009 01:11 PM, Stefan Fritsch wrote: Hi, http://httpd.apache.org/docs/trunk/developer/output-filters.html recommends to reuse bucket brigades and to not use apr_brigade_destroy.

Re: Memory usage, core output filter, and apr_brigade_destroy

2009-09-13 Thread Stefan Fritsch
Hi RĂ¼diger, thanks for the response. On Sunday 13 September 2009, Ruediger Pluem wrote: On 09/13/2009 01:11 PM, Stefan Fritsch wrote: http://httpd.apache.org/docs/trunk/developer/output-filters.html recommends to reuse bucket brigades and to not use apr_brigade_destroy. However, both in