Re: Mistaken attributions?
On Dec 19, 2017 11:08, "William A Rowe Jr" wrote: On Fri, Dec 15, 2017 at 11:34 AM, Jim Jagielski wrote: > > - ./server/util_pcre.c > > (likely more) [] Others are lifted under license from other parties; these must retain both the copyright attribution and original license (e.g. MIT, BSD etc); an example is util_expr_parse.c which is licensed under a special exception to the GPL as clearly documented in that file; http://www.apache.org/legal/src-headers.html#3party I am reviewing these two specific cases, util_pcre.c was pcreposix.c derived from Hazel's code, copyright Cambridge with advertising clauses, and I'm fixing that, will present the proposed fix to the list so we have agreement and record of how we licensed that original source. I will review the util_expr_parse.c exception to determine what we should change in NOTICE, LICENSE or README. It would help users to summarize our use of GPL exception clause code even without advertising clauses to honor.
Re: Mistaken attributions?
On Fri, Dec 15, 2017 at 11:34 AM, Jim Jagielski wrote: > >> On Dec 15, 2017, at 11:26 AM, William A Rowe Jr wrote: >> >> Actually remoteip isn't a showstopper... I find it demotivating and against >> the spirit of httpd development, but am NOT vetoing it, and was showing an >> example of proper form when attribution is desired. >> >> mod_h2 is a showstopper. It is missing an ASF copyright statement altogether. > > As does (from a quick little scan): > > - ./modules/filters/mod_proxy_html.c > - ./modules/filters/mod_sed.c > - ./modules/filters/mod_xml2enc.c > - ./modules/filters/regexp.c > - ./modules/filters/sed0.c > - ./modules/filters/sed1.c > - ./server/util_expr_parse.c > - ./server/util_pcre.c > > (likely more) So let's look at what the ASF has to say about this? The project has undergone over 20 years of source file evolution, so there are lots of statements that aren't applicable anymore, and perhaps some examples of borrowed code where a copyright statement must remain - util_pcre.c is an example of one or the other. We have two broad categories; ASF works ... e.g. the direct contributions by copyright holders, such as mod_proxy_html, mod_xml2enc and mod_http2, and others such as mod_sed donated. This applies; http://www.apache.org/legal/src-headers.html#headers If Stefen, Nick and yourself could review and correct sources files you respectively donated, that would be helpful. Others are lifted under license from other parties; these must retain both the copyright attribution and original license (e.g. MIT, BSD etc); an example is util_expr_parse.c which is licensed under a special exception to the GPL as clearly documented in that file; http://www.apache.org/legal/src-headers.html#3party > Plus many in APR land as well... > > Will you be fixing them or simply complaining? Yes, I'm happy to take on the process of aligning the APR project with the ASF license/copyright policy.
Re: Mistaken attributions?
> On Dec 15, 2017, at 11:26 AM, William A Rowe Jr wrote: > > Actually remoteip isn't a showstopper... I find it demotivating and against > the spirit of httpd development, but am NOT vetoing it, and was showing an > example of proper form when attribution is desired. > > mod_h2 is a showstopper. It is missing an ASF copyright statement altogether. > As does (from a quick little scan): - ./modules/filters/mod_proxy_html.c - ./modules/filters/mod_sed.c - ./modules/filters/mod_xml2enc.c - ./modules/filters/regexp.c - ./modules/filters/sed0.c - ./modules/filters/sed1.c - ./server/util_expr_parse.c - ./server/util_pcre.c (likely more) Plus many in APR land as well... Will you be fixing them or simply complaining?
Re: Mistaken attributions?
Actually remoteip isn't a showstopper... I find it demotivating and against the spirit of httpd development, but am NOT vetoing it, and was showing an example of proper form when attribution is desired. mod_h2 is a showstopper. It is missing an ASF copyright statement altogether. On Dec 15, 2017 04:04, "Graham Leggett" wrote: On 14 Dec 2017, at 8:43 PM, William A Rowe Jr wrote: > So without diving into why one or another form is more correct, > the ASF's global license header guidance is absolute. > > mod_remoteip is an example of getting it 'right' by many > definitions of 'right' across the ASF; > > /* Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > * > * Portions of the input filter code for PROXY protocol support is > * Copyright 2014 Cloudzilla Inc. > */ > > The mod_h2.h and other files in that tree are incorrect by every > ASF definition; > > /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) > * > * Licensed under the Apache License, Version 2.0 (the "License"); > * you may not use this file except in compliance with the License. > * You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > > This is not to take anything away from Stefan's and his > employers' contributions to this project. > > Please, fix. Thanks, So to cut a long story short, are you saying that these specific lines must be removed? /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) Regards, Graham —
Re: Mistaken attributions?
>From what I understand, it should be something like: /* Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. * * CUSTOM COPYRIGHT STUFF GOES HERE */ It should be explicit that it's licensed TO the ASF and that it uses the ASF license. Then you can add custom copyright on parts below that. On Fri, Dec 15, 2017 at 11:04 AM, Graham Leggett wrote: > On 14 Dec 2017, at 8:43 PM, William A Rowe Jr wrote: > > > So without diving into why one or another form is more correct, > > the ASF's global license header guidance is absolute. > > > > mod_remoteip is an example of getting it 'right' by many > > definitions of 'right' across the ASF; > > > > /* Licensed to the Apache Software Foundation (ASF) under one or more > > * contributor license agreements. See the NOTICE file distributed with > > * this work for additional information regarding copyright ownership. > > * The ASF licenses this file to You under the Apache License, Version 2.0 > > * (the "License"); you may not use this file except in compliance with > > * the License. You may obtain a copy of the License at > > * > > * http://www.apache.org/licenses/LICENSE-2.0 > > * > > * Unless required by applicable law or agreed to in writing, software > > * distributed under the License is distributed on an "AS IS" BASIS, > > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > > * See the License for the specific language governing permissions and > > * limitations under the License. > > * > > * Portions of the input filter code for PROXY protocol support is > > * Copyright 2014 Cloudzilla Inc. > > */ > > > > The mod_h2.h and other files in that tree are incorrect by every > > ASF definition; > > > > /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) > > * > > * Licensed under the Apache License, Version 2.0 (the "License"); > > * you may not use this file except in compliance with the License. > > * You may obtain a copy of the License at > > * > > * http://www.apache.org/licenses/LICENSE-2.0 > > > > * Unless required by applicable law or agreed to in writing, software > > * distributed under the License is distributed on an "AS IS" BASIS, > > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > > * See the License for the specific language governing permissions and > > * limitations under the License. > > */ > > > > This is not to take anything away from Stefan's and his > > employers' contributions to this project. > > > > Please, fix. Thanks, > > So to cut a long story short, are you saying that these specific lines > must be removed? > > /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) > > Regards, > Graham > — > >
Re: Mistaken attributions?
On 14 Dec 2017, at 8:43 PM, William A Rowe Jr wrote: > So without diving into why one or another form is more correct, > the ASF's global license header guidance is absolute. > > mod_remoteip is an example of getting it 'right' by many > definitions of 'right' across the ASF; > > /* Licensed to the Apache Software Foundation (ASF) under one or more > * contributor license agreements. See the NOTICE file distributed with > * this work for additional information regarding copyright ownership. > * The ASF licenses this file to You under the Apache License, Version 2.0 > * (the "License"); you may not use this file except in compliance with > * the License. You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > * > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > * > * Portions of the input filter code for PROXY protocol support is > * Copyright 2014 Cloudzilla Inc. > */ > > The mod_h2.h and other files in that tree are incorrect by every > ASF definition; > > /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) > * > * Licensed under the Apache License, Version 2.0 (the "License"); > * you may not use this file except in compliance with the License. > * You may obtain a copy of the License at > * > * http://www.apache.org/licenses/LICENSE-2.0 > > * Unless required by applicable law or agreed to in writing, software > * distributed under the License is distributed on an "AS IS" BASIS, > * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. > * See the License for the specific language governing permissions and > * limitations under the License. > */ > > This is not to take anything away from Stefan's and his > employers' contributions to this project. > > Please, fix. Thanks, So to cut a long story short, are you saying that these specific lines must be removed? /* Copyright 2015 greenbytes GmbH (https://www.greenbytes.de) Regards, Graham — smime.p7s Description: S/MIME cryptographic signature
