Re: Rev 1: [PATCH] 1.3 TraceEnable [on|off|extended]

2005-06-28 Thread William A. Rowe, Jr.
At 01:40 PM 6/27/2005, William A. Rowe, Jr. wrote:
At 01:16 PM 6/27/2005, JimJag wrote:
Shouldn't set_allow_header be static?

My bad, make_header was static, and set_allow_header in my
tree is static as well.

If there are no objections, I would move ahead and commit.

The only thing holding up the 2.x flavor is restoring the
chunked-pass logic.  I've decided on a metadata bucket type
and just have to figure out the implementation details.

Bill




Re: Rev 1: [PATCH] 1.3 TraceEnable [on|off|extended]

2005-06-28 Thread Jim Jagielski
William A. Rowe, Jr. wrote:
 
 At 01:40 PM 6/27/2005, William A. Rowe, Jr. wrote:
 At 01:16 PM 6/27/2005, JimJag wrote:
 Shouldn't set_allow_header be static?
 
 My bad, make_header was static, and set_allow_header in my
 tree is static as well.
 
 If there are no objections, I would move ahead and commit.
 

+1

-- 
===
   Jim Jagielski   [|]   [EMAIL PROTECTED]   [|]   http://www.jaguNET.com/
 Sith happens  -  Yoda


Re: Rev 1: [PATCH] 1.3 TraceEnable [on|off|extended]

2005-06-27 Thread Jim Jagielski

Shouldn't set_allow_header be static?



Re: Rev 1: [PATCH] 1.3 TraceEnable [on|off|extended]

2005-06-27 Thread William A. Rowe, Jr.
At 01:16 PM 6/27/2005, JimJag wrote:
Shouldn't set_allow_header be static?

ewww.  so should have make_allow ...

Wasn't defined in any header, so I don't suppose it's really
breaking ABI to get it right :)

Bill