Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
The change works nicely in my tests. I have some where I trigger timeout and keepalive and I see the effect. For 2.4.x I test as well and need a slight adjustment to event.c. Could you look if that ok? Then I would propose that for backport. Cheers, Stefan h2-keepalive-yann-v2.patch

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 2:03 PM Stefan Eissing wrote: > > > Am 03.07.2019 um 13:57 schrieb Yann Ylavic : > > > > On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing > > wrote: > >> > >> HE IS ALIVE! \o/ > > > > Yes :)) still a bit overwhelmed at day $job though :/ > > It's a shabby world where open

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
> Am 03.07.2019 um 13:57 schrieb Yann Ylavic : > > On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing > wrote: >> >> HE IS ALIVE! \o/ > > Yes :)) still a bit overwhelmed at day $job though :/ It's a shabby world where open source devs need to pay rent and food+drinks in restaurants...

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 1:50 PM Stefan Eissing wrote: > > HE IS ALIVE! \o/ Yes :)) still a bit overwhelmed at day $job though :/

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
HE IS ALIVE! \o/ Great! I will try this in trunk later today. That there are two "queues", one with Timeout and one with KeepAliveTimeout, fixed for all connections, was my read, but I am not that deep into mpm_event. Thanks for confirming and the patch. Will report back. Cheers, Stefan >

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Yann Ylavic
On Wed, Jul 3, 2019 at 9:23 AM Stefan Eissing wrote: > > > Am 02.07.2019 um 14:00 schrieb Eric Covener : > > > > I think a successful exit of CONN_STATE_WRITE_COMPLETION would > > conceptually lead to keepalive state so that would be plausible. And > > a failed one would go into lingering close.

Re: connection state handling and KeepAliveTimeout

2019-07-03 Thread Stefan Eissing
> Am 02.07.2019 um 14:00 schrieb Eric Covener : > > On Tue, Jul 2, 2019 at 7:38 AM Stefan Eissing > wrote: >> >> >> >>> Am 02.07.2019 um 13:35 schrieb Eric Covener : >>> >>> On Tue, Jul 2, 2019 at 4:51 AM Stefan Eissing >>> wrote: People with in insight into your connection

Re: connection state handling and KeepAliveTimeout

2019-07-02 Thread Eric Covener
On Tue, Jul 2, 2019 at 7:38 AM Stefan Eissing wrote: > > > > > Am 02.07.2019 um 13:35 schrieb Eric Covener : > > > > On Tue, Jul 2, 2019 at 4:51 AM Stefan Eissing > > wrote: > >> > >> People with in insight into your connection state handling, please review: > >> > >>

Re: connection state handling and KeepAliveTimeout

2019-07-02 Thread Stefan Eissing
> Am 02.07.2019 um 13:35 schrieb Eric Covener : > > On Tue, Jul 2, 2019 at 4:51 AM Stefan Eissing > wrote: >> >> People with in insight into your connection state handling, please review: >> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=63534 >> >> describes an issue with HTTP/2 and

Re: connection state handling and KeepAliveTimeout

2019-07-02 Thread Eric Covener
On Tue, Jul 2, 2019 at 4:51 AM Stefan Eissing wrote: > > People with in insight into your connection state handling, please review: > > https://bz.apache.org/bugzilla/show_bug.cgi?id=63534 > > describes an issue with HTTP/2 and KeepAliveTimeout. Basically, HTTP/2 writes > response DATA, gets